Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor scheduler #259

Merged
merged 14 commits into from
Feb 17, 2022
Merged

Refactor scheduler #259

merged 14 commits into from
Feb 17, 2022

Conversation

blagoev
Copy link
Contributor

@blagoev blagoev commented Feb 16, 2022

Fixes scheduler for notifications.

blagoev and others added 13 commits February 10, 2022 15:02
Dart tests configured to be executed in random order.
* throw error on primary key set

* relax final on collections

fix tests

* fix setters in generated constructor to use RealmObject.set directly

* fix generator tests

* run realm_dart tests on generator change.

test only on Linux

* fix working directory

* fix workflow

* fix coverage file path

* get submodule
* clarify readme

* fix link

* handle PR feedback

* fix code samples
* run CI on every change

* use stable channel on CI
…eys and properties (#248)

Samples updated not to require final for properties, primary keys and lists when generating models.
* Realm object isValid and realm list isValid implementation
* Tests added for property isValid of RealmList and RealmObject
# Conflicts:
#	.github/workflows/realm-dart-linux.yml
#	test/realm_test.dart
@cla-bot cla-bot bot added the cla: yes label Feb 16, 2022
@blagoev blagoev changed the base branch from master to RealmResults.changed February 16, 2022 10:55
@blagoev blagoev marked this pull request as ready for review February 17, 2022 12:36
@blagoev blagoev merged commit a8ef4f7 into RealmResults.changed Feb 17, 2022
@blagoev blagoev deleted the refactor-scheduler branch February 17, 2022 12:37
blagoev added a commit that referenced this pull request Feb 18, 2022
* Add notifications to RealmResults

* Remove GC debug code that causes flutter macos build to fail

* Rename changed to changes

* Dart specific C api for notification callbacks

* Fix ios build

* Update bindings

* Use new dart specific c-api for results notifications

* Results notifications (#242)

* fixup results notifications

* fix results type constraints

* use stable channel on CI

* Remove callback_bridge.dart and controller_builder.dart (not needed for this PR anymore)

* Update public API

* Update README and CHANGELOG regarding RealmResults.changes

* Refactor scheduler (#259)

* remove commented notifications code

* refactor scheduler

* rerun tests

* randomize tests

* wait a bit longer for callback

* Randomize test execution ordering (#249)

Dart tests configured to be executed in random order.

* throw error on primary key set (#253)

* throw error on primary key set

* relax final on collections

fix tests

* fix setters in generated constructor to use RealmObject.set directly

* fix generator tests

* run realm_dart tests on generator change.

test only on Linux

* fix working directory

* fix workflow

* fix coverage file path

* get submodule

* clarify readme (#256)

* clarify readme

* fix link

* handle PR feedback

* fix code samples

* fix error install command message (#246)

* run CI on every change (#257)

* run CI on every change

* use stable channel on CI

* Samples and tests updated with relaxed final constraint for primary keys and properties (#248)

Samples updated not to require final for properties, primary keys and lists when generating models.

* isValid of realm list and object (#183)

* Realm object isValid and realm list isValid implementation
* Tests added for property isValid of RealmList and RealmObject

* fix scheduler

* fix public API

* revert multiple tests on linux

remove dead code

* fix up public api docs

* fix tests

* fix name

* refactor Results notifications

* fix wording, samples in readmem,  changelog

Co-authored-by: blagoev <lubo@blagoev.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants