Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Efficient list remove #915

Merged
merged 3 commits into from
Sep 23, 2022
Merged

Efficient list remove #915

merged 3 commits into from
Sep 23, 2022

Conversation

nielsenko
Copy link
Contributor

Use indexOf in managed list remove

@cla-bot cla-bot bot added the cla: yes label Sep 19, 2022
@nielsenko nielsenko marked this pull request as draft September 19, 2022 12:21
@nielsenko nielsenko self-assigned this Sep 19, 2022
@nielsenko nielsenko marked this pull request as ready for review September 20, 2022 13:03
@nielsenko nielsenko force-pushed the kn/efficient-list-remove branch 3 times, most recently from b14a440 to c5f1b8c Compare September 20, 2022 17:07
Copy link
Contributor

@desistefanova desistefanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we add something to changelog about this?

@nielsenko nielsenko force-pushed the kn/efficient-list-remove branch 2 times, most recently from 16f172b to 7f9c7e7 Compare September 21, 2022 11:10
Base automatically changed from kn/list-index-of to master September 21, 2022 12:49
@coveralls
Copy link

coveralls commented Sep 21, 2022

Pull Request Test Coverage Report for Build 3115114574

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.07%) to 86.602%

Totals Coverage Status
Change from base Build 3114049220: -1.07%
Covered Lines: 1797
Relevant Lines: 2075

💛 - Coveralls

CHANGELOG.md Outdated Show resolved Hide resolved
lib/src/list.dart Outdated Show resolved Hide resolved
test/list_test.dart Outdated Show resolved Hide resolved
@nielsenko nielsenko merged commit dfdb47f into master Sep 23, 2022
@nielsenko nielsenko deleted the kn/efficient-list-remove branch September 23, 2022 19:56
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants