Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run iOS tests on CI #2405

Merged
merged 40 commits into from
Jun 25, 2021
Merged

Run iOS tests on CI #2405

merged 40 commits into from
Jun 25, 2021

Conversation

LaPeste
Copy link
Contributor

@LaPeste LaPeste commented May 31, 2021

Description

To achieve this a js GH action to run the simulator was created.
To note that GH action should not be here, but rather on the CI repo. This will be done when everything is reviewed and approved, simply because referencing an action from another repo needs a "release" of the action.

Fixes #2286

@LaPeste LaPeste marked this pull request as ready for review June 18, 2021 11:47
@LaPeste LaPeste requested a review from nirinchev June 22, 2021 08:15
Copy link
Member

@nirinchev nirinchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a rebase on master to get the latest (some renaming around publishTestsResults) and I have some suggestions about making execCmd more streamlined.

.github/actions/run-ios-simulator/src/main.ts Outdated Show resolved Hide resolved
.github/actions/run-ios-simulator/src/main.ts Outdated Show resolved Hide resolved
.github/actions/run-ios-simulator/src/main.ts Outdated Show resolved Hide resolved
.github/actions/run-ios-simulator/src/main.ts Outdated Show resolved Hide resolved
.github/actions/run-ios-simulator/src/main.ts Outdated Show resolved Hide resolved
@@ -0,0 +1,19 @@
{
"compilerOptions": {
"target": "ES2018",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was changed to accomodate the interface of RegExpExecArray that contains groups

@LaPeste LaPeste requested a review from nirinchev June 23, 2021 13:10
Copy link
Member

@nirinchev nirinchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - only questions/nits from me.

.github/actions/run-ios-simulator/src/main.ts Outdated Show resolved Hide resolved
.github/actions/run-ios-simulator/src/main.ts Outdated Show resolved Hide resolved
.github/actions/run-ios-simulator/src/main.ts Outdated Show resolved Hide resolved
@LaPeste LaPeste merged commit bf5187b into master Jun 25, 2021
@LaPeste LaPeste deleted the ac/ci-ios-tests branch June 25, 2021 14:37
nirinchev added a commit that referenced this pull request Jul 6, 2021
* master:
  Update the AppConfiguration.Logger obsolete message (#2495)
  Add more serializer types to the preserved ones (#2489)
  Update changelog from Core (#2488)
  Build an xcframework for iOS (#2475)
  Prepare for vNext (#2487)
  Prepare for 10.2.1 (#2484)
  Fix TableKey / ObjKey conversion on Android x86 (#2477)
  Update the build manager locations (#2474)
  Clean up native resources on Unity application exit (#2467)
  Fix some native warnings (#2483)
  Don't try to get the app from a removed user (#2480)
  Use delete_files from core when deleting a Realm. (#2401)
  Fixes for the sync datatype tests (#2461)
  Clean up the package.json and add some docs (#2452)
  Run iOS tests on CI (#2405)
  Verify that objects do not belong to different realm when added to collection (#2465)
  Updated README instructions (#2459)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run tests for Xamarin.iOS on CI
2 participants