Clean up the package.json and add some docs #2452
Conversation
| @@ -0,0 +1,42 @@ | |||
|  | |||
|
|
|||
| Realm is an embedded mobile database that runs directly on phones, tablets, or desktops. | |||
There was a problem hiding this comment.
@mongomoe tagging you to review the Readme - this is what's going to be shown on npmjs - e.g. here: https://www.npmjs.com/package/moment as well as if the user clicks on it in the unity package manager.
| @@ -314,42 +314,18 @@ | |||
| <Reference Include="Mono.Cecil"> | |||
| <HintPath>C:\work\dotnet\Realm\Realm.Unity\Editor\Cecil\Mono.Cecil.dll</HintPath> | |||
| </Reference> | |||
| <Reference Include="Nito.AsyncEx.Tasks"> | |||
There was a problem hiding this comment.
Are these dependences gone because we, now, only do the non-bundled version of the package for unity, right? After re-reading better the description, I understand. Never mind my initial comment.
There was a problem hiding this comment.
It's a good amount of changes but all seemed geared toward suppliying ILRepack with the dependencies you want to ILMerge in the final dll.
I don't think I should read all the specifications of ILRepack to verify each single line of the new changes. Despite this, the overall "shape" of the changes look reasonable.
* master: Update the AppConfiguration.Logger obsolete message (#2495) Add more serializer types to the preserved ones (#2489) Update changelog from Core (#2488) Build an xcframework for iOS (#2475) Prepare for vNext (#2487) Prepare for 10.2.1 (#2484) Fix TableKey / ObjKey conversion on Android x86 (#2477) Update the build manager locations (#2474) Clean up native resources on Unity application exit (#2467) Fix some native warnings (#2483) Don't try to get the app from a removed user (#2480) Use delete_files from core when deleting a Realm. (#2401) Fixes for the sync datatype tests (#2461) Clean up the package.json and add some docs (#2452) Run iOS tests on CI (#2405) Verify that objects do not belong to different realm when added to collection (#2465) Updated README instructions (#2459)
Description
Changes how we distribute the Unity package to ILRepack its dependencies and make them internal (except for MongoDB.Bson which we have in the public API, but I don't expect it to conflict with other libraries being used in the Unity project).
ILRepacking our dependencies allows us to distribute a single package and the added managed library should be negligible compared to the native binaries and the actual game assets. If we do run into a situation where we conflict with another library referencing MongoDB.Bson, we'll have to figure out a way to distribute without it.
Overview of the changes