Nh/fix 1884 listener trigger #1892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhachicha
force-pushed
the
nh/fix-1884-listener-trigger
branch
from
c03f5c0 to
88e61b3
Compare
|
@realm/java |
| @@ -74,7 +74,11 @@ public DynamicRealmObject createObject(String className) { | |||
| checkIfValid(); | |||
| Table table = schema.getTable(className); | |||
| long rowIndex = table.addEmptyRow(); | |||
| return get(DynamicRealmObject.class, className, rowIndex); | |||
| DynamicRealmObject dynamicRealmObject = get(DynamicRealmObject.class, className, rowIndex); | |||
| if (handlerController != null) { | |||
There was a problem hiding this comment.
This is also part of the above get method?
|
👍 @realm/java |
| @@ -677,4 +677,9 @@ public static void exitOrThrow(final ExecutorService executorService, | |||
| throw throwable[0]; | |||
| } | |||
| } | |||
|
|
|||
|
Looks fine to me. |
|
👍 apart from minor indent issue |
|
fixed the indent issue. |
nhachicha
force-pushed
the
nh/fix-1884-listener-trigger
branch
from
55ab4e0 to
133cd43
Compare
|
👍 squashed |
|
retest this please |
2 similar comments
|
retest this please |
|
retest this please |
nhachicha
added a commit
that referenced
this pull request
Dec 11, 2015
Nh/fix 1884 listener trigger
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
register RealmObject created with + add their UnitTest