Nh/fix 1894 changelistener not called #1927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@realm/java |
| dog.addChangeListener(new RealmChangeListener() { | ||
| @Override | ||
| public void onChange() { | ||
| assertEquals("Akamaru", dog.getName()); |
There was a problem hiding this comment.
Even ninja dogs can't hide when they are in a Realm :-)
|
retest this please |
1 similar comment
|
retest this please |
| @@ -6,6 +6,9 @@ | |||
| * Updated ProGuard configuration (#1904). | |||
| * Fixed a bug which could cause a crash when closing Realm instances in change listeners (#1900). | |||
| * Fix a crash occurring during update of multiple async queries (#1895). | |||
| * Fix (#1884) listeners not triggered for RealmObject & RealmResults created using copy or create methods. | |||
| * Fix (#1894) RealmChangeListener never called inside RealmResults. | |||
|
Small comment about wording in the changelog, otherwise 👍 |
nhachicha
force-pushed
the
nh/fix_1894_changelistener_not_called
branch
from
e399a1f to
734f03e
Compare
|
👍 |
nhachicha
added a commit
that referenced
this pull request
Dec 11, 2015
…lled Nh/fix 1894 changelistener not called
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1894 + provide a work around for #1886 while waiting for core fix, the work around avoid calling sync_if_needed if the RealmObject/RealmResults doesn't have any listeners
Note: it will be faster (small diff) to review this PR first #1892