Add retry custom confirmation logic #7079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rorbech
reviewed
Sep 7, 2020
realm/realm-library/src/objectServer/java/io/realm/mongodb/auth/EmailPasswordAuth.java
Show resolved
Hide resolved
realm/realm-library/src/objectServer/java/io/realm/mongodb/auth/EmailPasswordAuth.java
Show resolved
Hide resolved
cmelchior
reviewed
Sep 7, 2020
| * @param email the email of the user. | ||
| * @throws AppException if the server failed to confirm the user. | ||
| */ | ||
| public void callCustomConfirmationFunction(String email) throws AppException { |
There was a problem hiding this comment.
We should make sure we call this method the same across SDK's. Right now it doesn't seem to be documented on the website (most likely because the old SDK did not have it).
Especially since it is described as rerunning the registration. This makes me wonder if we should rename this to rerunCustomConfirmationFunction since it already ran once when registering and reword the javadoc appropriately?
|
I have modified the integration test cases as they were not actually calling the custom confirmation function. |
rorbech
approved these changes
Sep 14, 2020
edualonso
approved these changes
Sep 14, 2020
|
Unfortunately, this was merged in ObjectStore after the multiple app changes. After this we can bump this PR to the correct OS version. App PR: #7095 |
# Conflicts: # CHANGELOG.md # realm/realm-library/src/main/cpp/object-store
|
PR has been brought up to date. Merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR request allows the users to call a custom confirmation function to validate their registration.