This repository has been archived by the owner on Nov 8, 2021. It is now read-only.
Custom confirmation logic support #1080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsflax
reviewed
Sep 3, 2020
| @@ -228,6 +228,29 @@ void App::UsernamePasswordProviderClient::resend_confirmation_email(const std::s | |||
| }, handler); | |||
| } | |||
|
|
|||
| void App::UsernamePasswordProviderClient::retry_custom_confirmation(const std::string& email, | |||
There was a problem hiding this comment.
Is this the correct function name? Maybe I'm misunderstanding, but it seems like call_custom_confirmation_function might be a bit clearer.
There was a problem hiding this comment.
Sounds like we need to agree on how to expose this to users 😅 realm/realm-java#7079 (comment)
There was a problem hiding this comment.
By popular vote, we agreed on retry_custom_confirmation
cmelchior
reviewed
Sep 7, 2020
src/sync/app.hpp
Outdated
| /// Calls the custom confirmation function on a user for a given email. | ||
| /// @param email The email address of the user to call the custom confirmation for. | ||
| /// @param completion_block A callback to be invoked once the call is complete. | ||
| void call_custom_confirmation_function(const std::string& email, |
There was a problem hiding this comment.
Is there no way to test this in ObjectStore?
There was a problem hiding this comment.
Have added test cases for the custom confirmation function, following the same pattern as call_reset_password_function.
ironage
approved these changes
Sep 11, 2020
cmelchior
approved these changes
Sep 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for calling the custom confirmation function from the SDKs