Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unneeded files from our archive #4061

Closed
wants to merge 16 commits into from

Conversation

kraenhansen
Copy link
Member

What, How & Why?

This closes #4060 cutting our NPM unpacked archive by 30 MB from ~320 MB to ~290 MB.

☑️ ToDos

  • 📝 Changelog entry
  • 📝 Compatibility label is updated or copied from previous entry
  • 🚦 Tests
  • 📝 Public documentation PR created or is not necessary
  • 💥 Breaking label has been applied or is not necessary

@kraenhansen kraenhansen self-assigned this Nov 2, 2021
@cla-bot cla-bot bot added the cla: yes label Nov 2, 2021
@kraenhansen kraenhansen marked this pull request as draft November 3, 2021 09:59
@kraenhansen
Copy link
Member Author

kraenhansen commented Nov 3, 2021

I've drafted this again, since we're relying on building from source when running tests on Jenkins: https://github.com/realm/realm-js/blob/kh/less-files-in-archive/scripts/test.sh#L453

kraenhansen and others added 15 commits July 7, 2022 09:26
* Throw if constructors doesn't extend Realm.Object

* Updating existing tests to the breaking change.

* Adding a note to the changelog
* Adding a cast to Value operator on ReturnType

* Adding integration tests of class constructors

* Made the test reporter print stack

* Implemented Realm.Object constructor

* Added node implementation and fixed legacy tests

* Read from this.constructor instead of new.target

* Fixing JSC implementation

* Updating types and tests

* Fixed Person and Dog constructors

* Updated @realm/react useObject + useQuery

* Updated types to fix an issue

* Dead code removal

* Updated tests to use default values

* Making the insertion types a bit more loose

* Adding documentation

* Renamed realm_object_object

* Made the constructor "values" required

* Renamed "RealmInsertionModel" to "Unmanged"

* Adding a note to the changelog

* Apply suggestions to docstrings

Co-authored-by: Kenneth Geisshirt <k@zigzak.net>

* Add docstring of set_internal and get_internal

* Expect 2 arguments on the C++ code as well

Co-authored-by: Kenneth Geisshirt <k@zigzak.net>
* [10.20.0-alpha.0] PRE-RELEASE - DO NOT USE IN PRODUCTION

* [10.20.0-alpha.1] Bump version

* [10.20.0-alpha.2] Bump version

Rename namespaces in the JSI codebase to reflect that it doesn't just support Hermes (#4079)

Rework the namespace names in our Hermes/JSI layer to more accurately reflect that we support JSI, and to remove ambiguities and namespace clashes.

This closes RJS-1337.

Fixing C++ lint error

* [10.20.0-beta.0] Bump version

Hermes: Fixing a couple of breaking tests (#4120)

* Relaxing error message asserting tests

* Fixing testListSubscriptSetters

Catching missing libjsi.so as librealm.so loads (#4123)

Updated RN peer dependency version (#4124)

Fix classes not extending `Realm.Object` (#4125)

* Fixing custom classes not extending Realm.Object

* Adding a note to the changelog

* Update CHANGELOG.md

Co-authored-by: FFranck <franck.franck@mongodb.com>

Co-authored-by: FFranck <franck.franck@mongodb.com>

Fixed throwing "Illegal constructor" (#4128)

Clarifying the get_internal early return

Refixed throwing "Illegal constructor"

Various JSI fixes to greenlight more tests (#4129)

Flipper doesnt support inlined sourcemaps

Return an existing s_ctor

Testing with Hermes on CI (#4106)

* Adding hermes as target branch for the integration tests workflow

* Reading environment variable when enabling Hermes

* Adding test app to watchable directories

* Adding a hermes variant when testing React Native

* Making the ccache engine specific

* Moved react-native entry point to fix lint error

* Attempt at fixing ReactTestAppTests

* Update Podfile to work around the Catalyst issue

Fixes for type conversions and minor cleanups (#4137)

* [10.20.0-beta.1] Bump version

Clean up JavaScriptCore & legacy Chrome debugger RPC layer (#4203)

* Removed 0xd3adc0d3

* Providing a "soft" landing for users running in legacy debugging mode

* Simplified index.js as we have react-native/index.js

* Removed some logging

* Adding a note to the CHANGELOG

* Stop integration testing in legacy debug mode

* Incorporated feedback

* Fixed the environment check 🤦‍♂️

* Removed all mentions of GCDWebServer

Prevent dangling objects on JSCRuntime destruction (#4228)

* WIP

* Refactored to a separate js_notifications.hpp

* Using the NotificationBucket throughout the codebase

* Adding a note to the changelog

* Fixed compiling on GCC

* Trigger garbage collection after every test

* Ensure s_tokens static gets initialized before use

Removed a bash only prepare command

* [10.20.0-beta.2] Bump version

Adding changelog template

Updated package-locks

Copied up the change log

* [10.20.0-beta.3] Bump version

* [10.20.0-beta.4] Bump version

Hermes: Adding an index.native.js (#4461)

* Ading an index.native.js to help bundlers

* Adding a note to the changelog

Update CMakeLists.txt to resolve "react-native" (#4466)

* Update CMakeLists.txt to resolve "react-native"

This enables end-users to build the iOS XCFramework locally from our npm package, if they need it built with the same version of Xcode as they're using to build their app.

* Update CHANGELOG.md

* Updating package-lock.json

* Adding changelog template

* [10.20.0-beta.5] Bump version

* Adding changelog template

* Rolling up relevant notes in changelog

* Class models: `Realm.Object#constructor` for JSI / Hermes (#4435)

* Create prototyped object instead of constructor call

Recreated package-lock

* Ran lint fix

Co-authored-by: Mathias Stearn <redbeard0531@gmail.com>

Updated the merge
* Improving ClassModel type

* Fixed changelog
Updating package-lock

Rebuild package-lock.json
Rearranged jsi_init

Refactored flush of UI queue for JSI
@kraenhansen kraenhansen force-pushed the kh/less-files-in-archive branch from d5ca9e4 to c2103b7 Compare July 9, 2022 06:00
@kraenhansen kraenhansen changed the base branch from master to v11 July 9, 2022 06:00
@kraenhansen
Copy link
Member Author

Closing as we won't be adding features to v11

@kraenhansen kraenhansen closed this Jan 8, 2024
@kraenhansen kraenhansen deleted the kh/less-files-in-archive branch January 8, 2024 09:22
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove source files from NPM package
1 participant