Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow opening Realms with asymmetric tables #1592

Merged
merged 5 commits into from
Sep 11, 2023

Conversation

nirinchev
Copy link
Member

Fixes #1591

@nirinchev nirinchev requested a review from elle-j September 7, 2023 13:16
Copy link
Contributor

@elle-j elle-j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix Nikola!

@@ -6,7 +6,7 @@

### Fixed

- None
- Fixed a bug where opening a Realm that contains asymmetric tables will crash the process with an error saying `You cannot query an asymmetric class`. ([#1591](https://github.com/realm/realm-studio/issues/1591))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this should be moved to CHANGELOG instead?

src/ui/RealmBrowser/Content/AsymmetricObjectCollection.ts Outdated Show resolved Hide resolved
src/ui/RealmBrowser/Content/AsymmetricObjectCollection.ts Outdated Show resolved Hide resolved
src/ui/RealmBrowser/focus.ts Outdated Show resolved Hide resolved
src/ui/RealmBrowser/index.tsx Outdated Show resolved Hide resolved
@nirinchev nirinchev requested a review from elle-j September 8, 2023 10:22
Co-authored-by: LJ <81748770+elle-j@users.noreply.github.com>
@nirinchev nirinchev merged commit fa2ef2e into channel/major-14 Sep 11, 2023
@nirinchev nirinchev deleted the ni/asymmetric-objects branch September 11, 2023 11:45
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't open a Realm that has asymmetric tables
3 participants