-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow opening Realms with asymmetric tables #1592
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
f2b22bf
Allow opening Realms with asymmetric tables
nirinchev 8b15d51
Fix lint errors
nirinchev 7a1e79e
CR comments
nirinchev 5dbe8dd
Merge branch 'channel/major-14' into ni/asymmetric-objects
nirinchev d5cb82c
Update src/ui/RealmBrowser/Content/AsymmetricObjectCollection.ts
nirinchev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,94 @@ | ||
//////////////////////////////////////////////////////////////////////////// | ||
// | ||
// Copyright 2023 Realm Inc. | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
// | ||
//////////////////////////////////////////////////////////////////////////// | ||
|
||
/** | ||
* Mock implementation of Realm.Result<T> that returns empty results. This is because an asymmetric table | ||
* cannot be queried and thus we cannot obtain the results wrapping it. | ||
*/ | ||
export class AsymmetricObjectCollection<T extends Realm.Object> | ||
extends Array<T> | ||
implements Realm.Results<T> | ||
{ | ||
public readonly type: Realm.PropertyType; | ||
public readonly optional = false; | ||
|
||
constructor(schema: Realm.ObjectSchema) { | ||
super(); | ||
this.type = schema.name; | ||
} | ||
|
||
public toJSON(): any[] { | ||
return this.toJSON(); | ||
} | ||
|
||
public update(): void { | ||
throw new Error('Not implemented'); | ||
} | ||
|
||
public description(): string { | ||
throw new Error('Not implemented'); | ||
} | ||
|
||
public isValid(): boolean { | ||
return true; | ||
} | ||
|
||
public isEmpty(): boolean { | ||
return true; | ||
} | ||
|
||
public min(property: string): any { | ||
throw new Error('Not implemented'); | ||
} | ||
|
||
public max(property: string): any { | ||
throw new Error('Not implemented'); | ||
} | ||
|
||
public sum(property: string): any { | ||
throw new Error('Not implemented'); | ||
} | ||
|
||
public avg(property: string): any { | ||
throw new Error('Not implemented'); | ||
} | ||
|
||
public filtered(): Realm.Results<T> { | ||
return this; | ||
} | ||
|
||
public sorted(): Realm.Results<T> { | ||
return this; | ||
} | ||
|
||
public snapshot(): Realm.Results<T> { | ||
return this; | ||
} | ||
|
||
public addListener(): void { | ||
throw new Error('Not implemented'); | ||
} | ||
|
||
public removeListener(): void { | ||
throw new Error('Not implemented'); | ||
} | ||
|
||
public removeAllListeners(): void { | ||
throw new Error('Not implemented'); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this should be moved to CHANGELOG instead?