Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Price per m2 is not necessary when advertismentType is "rent" #74

Open
vire opened this issue Mar 30, 2017 · 0 comments
Open

Price per m2 is not necessary when advertismentType is "rent" #74

vire opened this issue Mar 30, 2017 · 0 comments
Assignees
@vire
Labels
bug

Comments

@vire
Copy link
Collaborator

vire commented Mar 30, 2017

No description provided.

@vire vire added the bug label Mar 30, 2017
@vire vire self-assigned this Mar 30, 2017
vire added a commit to vire/reality-plugin that referenced this issue Mar 31, 2017
@vire
fix: Remove price per m2 from rental ads
5b50057 
Added logic to check if ad is type of RENT and when yes omit price per m2 extraction

Removed location.hostname passing from contentscript to sites

Small refactorings

Fixes realreality#74
vire added a commit to vire/reality-plugin that referenced this issue Apr 1, 2017
@vire
fix: Remove price per m2 from rental ads
811ca4f 
Added logic to check if ad is type of RENT and when yes omit price per m2 extraction

Removed location.hostname passing from contentscript to sites

Small refactorings

Fixes realreality#74
@vire vire mentioned this issue Apr 1, 2017
Closed
vire added a commit to vire/reality-plugin that referenced this issue Apr 3, 2017
@vire
build: Use typescript, update webpack, linters etc.
c3de6ca 
* added 🐶husky to run prepush
* fix .editorconfig - corrected to use LF setting for all files
* lint: semi set to never
* lint: comma dange - always-multiline, because of duplicating lines
* moved jest config into .jestrc
* update package.json scripts
* added tsconfig, tslint, tsfmt for styling codebase
* migrated all impl to ts
* migrated non-vue tests to ts

Closes realreality#74 realreality#75
vire added a commit to vire/reality-plugin that referenced this issue Apr 3, 2017
@vire
build: Use typescript, update webpack, linters etc.
e86bc12 
* added 🐶husky to run prepush
* fix .editorconfig - corrected to use LF setting for all files
* lint: semi set to never
* lint: comma dange - always-multiline, because of duplicating lines
* moved jest config into .jestrc
* update package.json scripts
* added tsconfig, tslint, tsfmt for styling codebase
* migrated all impl to ts
* migrated non-vue tests to ts

Closes realreality#74 realreality#75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vire vire

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vire