Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove price per m2 from rental ads #76

Closed

Conversation

vire
Copy link
Collaborator

@vire vire commented Apr 1, 2017

Added logic to check if ad is type of RENT and when yes omit price per m2 extraction

Removed location.hostname passing from contentscript to sites

Small refactorings

Fixes #74

Added logic to check if ad is type of RENT and when yes omit price per m2 extraction

Removed location.hostname passing from contentscript to sites

Small refactorings

Fixes realreality#74
@vire vire requested a review from michalbcz April 1, 2017 11:11
@codecov-io
Copy link

Codecov Report

Merging #76 into master will increase coverage by 4.25%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #76      +/-   ##
==========================================
+ Coverage   15.05%   19.31%   +4.25%     
==========================================
  Files          14       14              
  Lines         352      378      +26     
  Branches       45       51       +6     
==========================================
+ Hits           53       73      +20     
- Misses        299      305       +6
Impacted Files Coverage Δ
src/js/contentscript.js 0% <0%> (ø) ⬆️
src/js/utils.js 0% <0%> (ø) ⬆️
src/js/sites/fixtures/index.js 90.41% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2afd012...811ca4f. Read the comment docs.

@vire
Copy link
Collaborator Author

vire commented Apr 3, 2017

Fixed by PR#78

@vire vire closed this Apr 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants