Fix navigation bar in light mode #1350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CranberrySoup
commented
Sep 24, 2024
| <item android:color="?attr/textColor" android:state_checked="false"/> |
There was a problem hiding this comment.
item_select_color.xml is only used within the navigation rail. This should not have any side effects
|
No special need for the WhiteSmoke , you can remove it 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1349
This does however use textColor. It is similar, but not identical to the previous shade of white.
@KingLucius is there any specific intent behind the shade? Is textColor satisfactory? It is possible to make whiteSmoke dynamic, but that felt like overkill given the available option of textColor.
Previous:
New:
Previous:
New:
