Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix incorrect wrapping_mul doc #218

Merged
merged 3 commits into from
May 11, 2023
Merged

Conversation

DaniPopes
Copy link
Contributor

Motivation

Uint::wrapping_mul has the same rustdoc as Uint::saturating_mul, incorrectly stating that it saturates instead of overflowing

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog

@DaniPopes DaniPopes requested a review from recmo as a code owner January 3, 2023 11:09
@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@d6f8288). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head ac0a1c8 differs from pull request most recent head dbf498b. Consider uploading reports for the commit dbf498b to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #218   +/-   ##
=======================================
  Coverage        ?   84.39%           
=======================================
  Files           ?       49           
  Lines           ?     5870           
  Branches        ?        0           
=======================================
  Hits            ?     4954           
  Misses          ?      916           
  Partials        ?        0           
Impacted Files Coverage Δ
src/mul.rs 93.18% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@prestwich prestwich self-requested a review as a code owner May 11, 2023 23:06
@prestwich prestwich enabled auto-merge May 11, 2023 23:06
@prestwich prestwich merged commit 151e68e into recmo:main May 11, 2023
@DaniPopes DaniPopes deleted the incorrect-doc branch May 12, 2023 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants