Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: from_base_be overflow #253

Merged
merged 1 commit into from
May 30, 2023
Merged

fix: from_base_be overflow #253

merged 1 commit into from
May 30, 2023

Conversation

DaniPopes
Copy link
Contributor

Motivation

LIMBS can be 0, which panics at runtime on subtraction overflow

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog

@DaniPopes DaniPopes requested a review from prestwich as a code owner May 30, 2023 20:40
@prestwich prestwich enabled auto-merge May 30, 2023 21:52
prestwich
prestwich approved these changes May 30, 2023
View reviewed changes
Copy link
Collaborator

@prestwich prestwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing my mistake 🖖

@prestwich prestwich merged commit 9538ff4 into recmo:main May 30, 2023
@DaniPopes DaniPopes deleted the fix-overflow branch May 30, 2023 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prestwich prestwich prestwich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DaniPopes @prestwich