Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make add and sub const fns #324

Merged
merged 1 commit into from
Sep 30, 2023
Merged

Conversation

DaniPopes
Copy link
Contributor

@DaniPopes DaniPopes commented Sep 30, 2023

Motivation

By changing for with while we can make mark add and sub functions as const.

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog

@codecov
Copy link

codecov bot commented Sep 30, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (706ffd0) 80.63% compared to head (038ac4c) 80.49%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #324      +/-   ##
==========================================
- Coverage   80.63%   80.49%   -0.14%     
==========================================
  Files          54       54              
  Lines        6036     6040       +4     
==========================================
- Hits         4867     4862       -5     
- Misses       1169     1178       +9     
Files Coverage Δ
src/cmp.rs 100.00% <ø> (ø)
src/add.rs 74.82% <81.81%> (+0.72%) ⬆️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prestwich prestwich merged commit a52ea9e into recmo:main Sep 30, 2023
@DaniPopes DaniPopes deleted the const-add-sub branch September 30, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants