chore: simplify mul #325
Merged
chore: simplify mul #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #325 +/- ##
==========================================
- Coverage 80.54% 80.51% -0.04%
==========================================
Files 54 54
Lines 6040 6034 -6
==========================================
- Hits 4865 4858 -7
- Misses 1175 1176 +1
☔ View full report in Codecov by Sentry. |
DaniPopes
force-pushed
the
simplify-mul
branch
from
7c61d9b to
3ed970b
Compare
prestwich
approved these changes
Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Use slice/array patterns to simplify
addmul.Reduces LLVM generated which may or may not improve performance or binary size.
Solution
PR Checklist