feat: make {from,to}_{b,l}e_bytes const
#329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestwich
reviewed
Oct 13, 2023
prestwich
reviewed
Oct 13, 2023
Comment on lines
+195
to
+196
| /// Converts a big-endian byte array of size exactly | ||
| /// [`Self::BYTES`] to [`Uint`]. |
There was a problem hiding this comment.
any reason for reordering methods?
There was a problem hiding this comment.
ya, just makes the functional review harder
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #329 +/- ##
==========================================
+ Coverage 80.55% 80.78% +0.22%
==========================================
Files 54 54
Lines 6039 6111 +72
==========================================
+ Hits 4865 4937 +72
Misses 1174 1174
☔ View full report in Codecov by Sentry. |
This was referenced Oct 13, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Const impl + some perf gains
Solution
Hand roll use of iterators, for loops and
slice::reversePR Checklist