fix: modify overflowing_shr
to fix overflow check
#347
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
overflowing_shr
algorithm seems to give incorrect overflow results: #337.Should close #337.
Solution
overflow
is set totrue
, indicating a floating-point result.overflowing_shr
function to differentiate between floating-point and integer outcomes after the shift operation.This enhancement improves the functionality of the
overflowing_shr
method, providing a mechanism to determine whether the result represents a floating-point or integer value.PR Checklist