Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps #406

Closed
wants to merge 1 commit into from
Closed

Update deps #406

wants to merge 1 commit into from

Conversation

kpp
Copy link

@kpp kpp commented Nov 27, 2024

Update deps.

@kpp kpp requested a review from prestwich as a code owner November 27, 2024 07:22
@prestwich
Copy link
Collaborator

prestwich commented Nov 28, 2024

wrt optional deps, our semver policy treats their breaking changes as semver major for us. We typically update by adding support for specific versions (see #403 and the discussion in #404). If you have a need for support for these crates at specific versions we can add those versions to the support directory, but modifying (removing) the existing support is a no go from our side

@kpp
Copy link
Author

kpp commented Dec 3, 2024

Can you help me with that? I wanted to update deps to reduce the number of outdated deps in my project.

If I want to update primitive-types, rlp and ethereum_ssz, I have to add new features for those updated deps?

@prestwich
Copy link
Collaborator

Can you help me with that? I wanted to update deps to reduce the number of outdated deps in my project.

I think that #403 is a pretty good roadmap for achieving that. The basic steps are

  • add the new dependency with version number in name (renaming the old one to include a version number too)
  • add the new file to support/
  • edit the existing support to use the renamed version of the old package
  • do NOT edit the feature name

@prestwich prestwich added wontfix This will not be worked on dependencies Pull requests that update a dependency file labels Dec 16, 2024
@prestwich
Copy link
Collaborator

in the meantime, i'm closing this as wontfix as this PR would violate our semver policies. would love to see followup PRs tho :)

@prestwich prestwich closed this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants