Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CodingStyle] Add %s for pass PHP_EOL constant on EncapsedStringsToSprintfRector #5072

Merged
merged 8 commits into from
Jan 2, 2021
Merged

[CodingStyle] Add %s for pass PHP_EOL constant on EncapsedStringsToSprintfRector #5072

merged 8 commits into from
Jan 2, 2021

Conversation

samsonasik
Copy link
Member

Closes #5060

@samsonasik samsonasik mentioned this pull request Jan 2, 2021
Closed
@samsonasik
Copy link
Member Author

@brucealdridge I think this still needs improvement for multi \n, for example:

return "prefix $format\n\n";

@samsonasik
Copy link
Member Author

I skipped multiple eol.

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@TomasVotruba
Copy link
Member

Thank you 👍

@TomasVotruba TomasVotruba merged commit cc20158 into master Jan 2, 2021
@TomasVotruba TomasVotruba deleted the close-5060 branch January 2, 2021 22:00
TomasVotruba added a commit that referenced this pull request Sep 23, 2023
@TomasVotruba
Updated Rector to commit 8bfaf450145e25e27e33e0ba2ead4c7348c6aa43
4b7d5cb 
rectorphp/rector-src@8bfaf45  [Php80] Mirror switch comment to match to ChangeSwitchToMatchRector  (#5072)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samsonasik @TomasVotruba @brucealdridge