Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RootElement attributes not created on client transition #73

Closed
gigabo opened this issue Apr 5, 2016 · 1 comment
Closed

RootElement attributes not created on client transition #73

gigabo opened this issue Apr 5, 2016 · 1 comment
Labels
bug An issue with the system
Milestone
v0.3.0

Comments

@gigabo
Copy link
Contributor

gigabo commented Apr 5, 2016

They're only added during server render.

<RootElement className="foo">
  <div>...</div>
</RootElement>

^ That won't get class name on client transition.
This was referenced Apr 5, 2016
Closed
Merged
@gigabo gigabo added the bug An issue with the system label Apr 29, 2016
@gigabo gigabo added this to the v0.3.0 milestone Apr 29, 2016
gigabo added a commit to gigabo/react-server that referenced this issue May 25, 2016
@gigabo
Update root container attributes on client transition with reuseDom
f1626c4 
Fixes redfin#73.
@gigabo gigabo mentioned this issue May 25, 2016
Merged
@gigabo
Copy link
Contributor Author

gigabo commented May 25, 2016

Turns out <RootElement>s are actually fine on client transition, and <RootContainer>s are fine on normal client transition. But <RootContainer> with reuseDom doesn't update. #218 addresses that (and adds a test page for it).

@gigabo gigabo closed this as completed in 9ea54a8 May 25, 2016
davidalber pushed a commit to davidalber/react-server that referenced this issue Jul 24, 2016
@gigabo @davidalber
Update root container attributes on client transition with reuseDom
845638c 
Fixes redfin#73.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug An issue with the system
Projects
None yet
Milestone
v0.3.0
Development

No branches or pull requests
1 participant
@gigabo