Client transition dom #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BTW - As mentioned in doug-wade#2: Still need to deal with root container/element attribute differences, but probably should fix #73 first. |
|
Added some commentary to explain the DOM re-use strategy and hopefully help ease review here. |
Merged
| `div[${REACT_SERVER_DATA_ATTRIBUTE}="${index}"]` | ||
| ); | ||
| var oldRootContainer = document.querySelector( | ||
| `div[${PAGE_CONTAINER_NODE_ID}="${index}"]` |
There was a problem hiding this comment.
Code style nit: defining these vars inside the if-statement with intent to use them outside. Works in JS, but is not what I would call expected. :)
There was a problem hiding this comment.
Pulled the declarations out next to the one for mountNode.
|
LGTM 👍 (with the exception of the vars-inside-if-block thing I left a comment on) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking over responsibility for getting @doug-wade's awesome DOM preservation changes shepherded into master, since he's getting pulled in three different directions in his day job.
This is #70 with a few patches to get things working in some cases that didn't come up during the hackathon that spawned it.