Add react server module tagger #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doug-wade
force-pushed
the
add-react-server-module-tagger
branch
from
5033208
to
a34f964
Compare
| @@ -13,6 +13,7 @@ | |||
| "react-dom": "~0.14.2", | |||
| "react-server": "../react-server", | |||
| "react-server-cli": "../react-server-cli", | |||
| "react-server-module-tagger": "../react-server-module-tagger", | |||
There was a problem hiding this comment.
I make this transitive dependency a direct dependency so that react-server-module-tagger's prepublish script is called; otherwise, we get module not found errors from react-server-gulp-module-tagger and babel-plugin-react-server
doug-wade
force-pushed
the
add-react-server-module-tagger
branch
from
a34f964
to
d5e97b9
Compare
doug-wade
force-pushed
the
add-react-server-module-tagger
branch
2 times, most recently
from
af74ab3
to
a92164d
Compare
doug-wade
force-pushed
the
add-react-server-module-tagger
branch
from
a92164d
to
1a1587c
Compare
| var isWindows = ('win32' === process.platform); | ||
|
|
||
| /** | ||
| * A util function for tagging modules. Expects to find data on its prototype |
There was a problem hiding this comment.
It expects to find data in its context, right? Doesn't need to be on the prototype.
|
Looks reasonable to me, though I didn't go line by line through the stuff that was moved from |
|
Yeah, LGTM, too. 👍 I've got some interface shuffling itches, but nothing prohibitive. |
davidalber
pushed a commit
to davidalber/react-server
that referenced
this pull request
Jul 24, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continue breaking up #280 (see also #294 and #297)