Add babel module tagging #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doug-wade
force-pushed
the
add-babel-module-tagging
branch
from
d9ae70e
to
be2be2a
Compare
doug-wade
force-pushed
the
add-babel-module-tagging
branch
2 times, most recently
from
a2b313f
to
a1edf06
Compare
doug-wade
force-pushed
the
add-babel-module-tagging
branch
from
a1edf06
to
4b4b400
Compare
| const config = { trim: state.opts.trim }; | ||
| const parent = path.resolve(path.join(process.cwd(), '..')) + path.sep; | ||
| const fp = this.file.opts.filename.replace(parent, ''); | ||
| const file = { path: fp }; |
There was a problem hiding this comment.
Yeah, a nicer interface for the module tagger would eliminate the need for this nonsense.
davidalber
pushed a commit
to davidalber/react-server
that referenced
this pull request
Jul 24, 2016
* Add api and cli for module tagging * Add module tagging babel plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continue the breakup of #280 . Includes #294, #297 and #300