Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

odo is failing when devfile container component defines command #5620

Closed
kadel opened this issue Apr 4, 2022 · 0 comments · Fixed by #5639
Closed

odo is failing when devfile container component defines command #5620

kadel opened this issue Apr 4, 2022 · 0 comments · Fixed by #5639
Assignees
@rm3l
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/Critical We need to stop doing everything and fix this ASAP. It is making the project unusable.

Comments

@kadel
Copy link
Member

kadel commented Apr 4, 2022 •
edited
Loading

devfile/registry#102 (comment)

Odo is not able to use devfiles that have container component with a custom command. Problem is that in the current odo implementation it overrides the default process in deployment which means that supervisord is not started. When supervisord is not running, odo is not able to execute any commands in the container.

It needs to be backported into v2, and we have to release new v2 release.

A quick fix is for odo to ignore command and args fields in container components.

The proper fix is going to be to keep using supervisord as pid1, and execute the commmand with args "on the side" as a separate process.

Because this needs to be fixed ASAP, we will start with quick fix and than work on a proper fix once we are not pressured by time.

/kind bug
/priority high
@openshift-ci openshift-ci bot added kind/bug Categorizes issue or PR as related to a bug. priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)). labels Apr 4, 2022
@kadel kadel added priority/Critical We need to stop doing everything and fix this ASAP. It is making the project unusable. and removed priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)). labels Apr 6, 2022
rm3l added a commit to rm3l/odo that referenced this issue Apr 7, 2022
@rm3l
Always ignore command and args fields in Devfile container compon…
5207ac9 
…ents

This is a hotfix for [1], until a proper fix is implemented, which would
consist in keeping using supervisord as pid1, and executing the command
with args "on the side" as a separate process.

[1] redhat-developer#5620
rm3l added a commit to rm3l/odo that referenced this issue Apr 7, 2022
@rm3l
Always ignore command and args fields in Devfile container compon…
81d846f 
…ents

This is a hotfix for [1], until a proper fix is implemented, which would
consist in keeping using supervisord as pid1, and executing the command
with args "on the side" as a separate process.

[1] redhat-developer#5620
rm3l added a commit to rm3l/odo that referenced this issue Apr 7, 2022
@rm3l
Always ignore command and args fields in Devfile container compon…
3ed93c3 
…ents

This is a hotfix for [1], until a proper fix is implemented, which would
consist in keeping using supervisord as pid1, and executing the command
with args "on the side" as a separate process.

[1] redhat-developer#5620
This was referenced Apr 7, 2022
Merged
Merged
@rm3l rm3l linked a pull request Apr 7, 2022 that will close this issue
[Hotfix][v2] Always ignore command and args defined in Devfile container components #5640
Merged
3 tasks
@rm3l rm3l moved this to In Progress in odo v3-beta1 Apr 7, 2022
@rm3l rm3l removed a link to a pull request Apr 7, 2022
[Hotfix][v2] Always ignore command and args defined in Devfile container components #5640
Merged
3 tasks
@rm3l rm3l moved this from In Progress to For Review in odo v3-beta1 Apr 7, 2022
@kadel kadel mentioned this issue Apr 8, 2022
Closed
openshift-merge-robot pushed a commit that referenced this issue Apr 8, 2022
@rm3l
[Hotfix][v2] Always ignore command and args defined in Devfile co…
5d79cb5 
…ntainer components (#5640)

* Reproduce the issue via a test case with `odo push`

* Always ignore `command` and `args` fields in Devfile container components

This is a hotfix for [1], until a proper fix is implemented, which would
consist in keeping using supervisord as pid1, and executing the command
with args "on the side" as a separate process.

[1] #5620
openshift-merge-robot pushed a commit that referenced this issue Apr 8, 2022
@rm3l
[Hotfix] Always ignore command and args defined in Devfile contai…
13bbc37 
…ner components (#5639)

* Reproduce the issue via a test case with `odo dev`

* Always ignore `command` and `args` fields in Devfile container components

This is a hotfix for [1], until a proper fix is implemented, which would
consist in keeping using supervisord as pid1, and executing the command
with args "on the side" as a separate process.

[1] #5620
Repository owner moved this from For Review to Done in odo v3-beta1 Apr 8, 2022
rm3l added a commit to rm3l/odo that referenced this issue May 27, 2022
@rm3l
Define 'command' and/or 'args' as needed in test Devfiles
13c715c 
Otherwise, the default images used spwan containers that terminate right away,
which would prevent us from using the new '--no-supervisord' flag.

This has no impact when running with Supervisord,
because [1] introduced a workaround this that always
overrides the container entrypoint.

[1] redhat-developer#5620
rm3l added a commit to rm3l/odo that referenced this issue May 30, 2022
@rm3l
Define 'command' and/or 'args' as needed in test Devfiles
88e0c73 
Otherwise, the default images used spwan containers that terminate right away,
which would prevent us from using the new '--no-supervisord' flag.

This has no impact when running with Supervisord,
because [1] introduced a workaround this that always
overrides the container entrypoint.

[1] redhat-developer#5620
rm3l added a commit to rm3l/odo that referenced this issue May 31, 2022
@rm3l
Define 'command' and/or 'args' as needed in test Devfiles
54f559f 
Otherwise, the default images used spwan containers that terminate right away,
which would prevent us from using the new '--no-supervisord' flag.

This has no impact when running with Supervisord,
because [1] introduced a workaround this that always
overrides the container entrypoint.

[1] redhat-developer#5620
rm3l added a commit to rm3l/odo that referenced this issue May 31, 2022
@rm3l
Define 'command' and/or 'args' as needed in test Devfiles
6b6c2e5 
Otherwise, the default images used spwan containers that terminate right away,
which would prevent us from using the new '--no-supervisord' flag.

This has no impact when running with Supervisord,
because [1] introduced a workaround this that always
overrides the container entrypoint.

[1] redhat-developer#5620
rm3l added a commit to rm3l/odo that referenced this issue Jun 3, 2022
@rm3l
Define 'command' and/or 'args' as needed in test Devfiles
415d6c3 
Otherwise, the default images used spwan containers that terminate right away,
which would prevent us from using the new '--no-supervisord' flag.

This has no impact when running with Supervisord,
because [1] introduced a workaround this that always
overrides the container entrypoint.

[1] redhat-developer#5620
cdrage pushed a commit to cdrage/odo that referenced this issue Aug 31, 2022
@rm3l @cdrage
[Hotfix] Always ignore command and args defined in Devfile contai…
f6fbb1f 
…ner components (redhat-developer#5639)

* Reproduce the issue via a test case with `odo dev`

* Always ignore `command` and `args` fields in Devfile container components

This is a hotfix for [1], until a proper fix is implemented, which would
consist in keeping using supervisord as pid1, and executing the command
with args "on the side" as a separate process.

[1] redhat-developer#5620
@rm3l rm3l added the v3 label Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rm3l rm3l

Labels
kind/bug Categorizes issue or PR as related to a bug. priority/Critical We need to stop doing everything and fix this ASAP. It is making the project unusable.
Projects
No open projects
odo v3-beta1
Status: Done
Milestone
No milestone
2 participants
@kadel @rm3l