Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hotfix][v2] Always ignore command and args defined in Devfile container components #5640

Merged
merged 2 commits into from
Apr 8, 2022
Merged

[Hotfix][v2] Always ignore command and args defined in Devfile container components #5640

merged 2 commits into from
Apr 8, 2022

Conversation

rm3l
Copy link
Member

@rm3l rm3l commented Apr 7, 2022 •
edited
Loading

What type of PR is this:
/kind bug
/kind hotfix

What does this PR do / why we need it:
This backports the hotfix done in #5639 to v2.
I am manually creating a separate PR because the test cases are different for v2 and main branches, so I cannot rely on openshift-bot to cherry-pick commits and create a new PR automatically.
This adapts the tests by using odo push instead of odo dev.

Before this fix, running odo push would not succeed if the Devfile defines a container component with command or args.

Which issue(s) this PR fixes:
Fixes #5620

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

rm3l added 2 commits April 7, 2022 13:48
@rm3l
Reproduce the issue via a test case with odo push
f0bd63d
@rm3l
Always ignore command and args fields in Devfile container compon…
3ed93c3 
…ents

This is a hotfix for [1], until a proper fix is implemented, which would
consist in keeping using supervisord as pid1, and executing the command
with args "on the side" as a separate process.

[1] redhat-developer#5620
@rm3l rm3l requested review from kadel and feloy April 7, 2022 11:59
@openshift-ci
Copy link

openshift-ci bot commented Apr 7, 2022

@rm3l: The label(s) kind/hotfix cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this:
/kind bug
/kind hotfix

What does this PR do / why we need it:
This backports the hotfix done in #5639 to v2.
I am manually creating a separate PR because the test cases are different for v2 and main branches, so I cannot rely on openshift-bot to auto-cherry-picks commits and create a new PR.
This adapts the tests by using odo push instead of odo dev.

Before this fix, running odo push would not succeed if the Devfile defines a container component with command or args.

Which issue(s) this PR fixes:
Fixes #5620

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Apr 7, 2022
@openshift-ci openshift-ci bot requested a review from dharmit April 7, 2022 11:59
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 7, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 5 Code Smells

No Coverage information No Coverage information
2.6% 2.6% Duplication

@rm3l rm3l changed the title [Hotfix][v2] Always ignore command and args fields in Devfile container components [Hotfix][v2] Always ignore command and args defined in Devfile container components Apr 7, 2022
@rm3l rm3l linked an issue Apr 7, 2022 that may be closed by this pull request
odo is failing when devfile container component defines command #5620
Closed
@rm3l rm3l removed a link to an issue Apr 7, 2022
odo is failing when devfile container component defines command #5620
Closed
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Apr 7, 2022
@kadel
Copy link
Member

kadel commented Apr 8, 2022

/approve

@openshift-ci
Copy link

openshift-ci bot commented Apr 8, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Apr 8, 2022
@openshift-merge-robot openshift-merge-robot merged commit 5d79cb5 into redhat-developer:v2 Apr 8, 2022
@rm3l rm3l deleted the v2-5620-odo-is-failing-when-devfile-container-component-defines-command branch April 8, 2022 10:15
@rm3l rm3l added the v2 Issue or PR that applies to the v2 of odo label Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feloy feloy feloy approved these changes

@kadel kadel Awaiting requested review from kadel

@dharmit dharmit Awaiting requested review from dharmit

Assignees

@feloy feloy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow. v2 Issue or PR that applies to the v2 of odo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rm3l @kadel @feloy @openshift-merge-robot