Fixes list and describe of secure URLs for not pushed components

[mik-dass]

What type of PR is this?
/kind bug

What does does this PR do / why we need it:

Fixes list and describe of secure URLs for not pushed components

Which issue(s) this PR fixes:

Fixes #3060

How to test changes / Special notes to the reviewer:

odo create nodejs
odo url create example --secure
odo url list                   // secure should be true for the not pushed URL
odo url list -o json       // secure should be true for the not pushed URL
odo describe -o json   // secure should be true for the not pushed URL
odo push
odo url list                     // secure should be true for the pushed URL
odo url list -o json         // secure should be true for the pushed URL
odo describe -o json     // secure should be true for the pushed URL

[codecov]

Codecov Report

Merging #3269 into master will increase coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #3269      +/-   ##
==========================================
+ Coverage   45.45%   45.47%   +0.02%     
==========================================
  Files         110      110              
  Lines       10853    10854       +1     
==========================================
+ Hits         4933     4936       +3     
  Misses       5446     5446              
+ Partials      474      472       -2     

Impacted Files	Coverage Δ
pkg/url/url.go	63.81% <0.00%> (-0.15%)	⬇️
pkg/sync/sync.go	49.50% <0.00%> (+2.97%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46ea6c3...f925d0f. Read the comment docs.

[dharmit]

@mik-dass I'm not sure what's the expected behaviour here but, odo url list shows if a URL is secure or not. However, odo url describe <url> doesn't. Is this expected?:

$ odo url list 
Found the following URLs for component nodejs-nodejs-ex-zali in application app:
NAME     STATE          URL     PORT     SECURE
url1     Not Pushed     ://     8080     true
url2     Not Pushed     ://     8080     false
There are local changes. Please run 'odo push'.

$ odo url describe url2                                    
NAME     STATE          URL     PORT
url2     Not Pushed     ://     8080
There are local changes. Please run 'odo push'.

$ odo url describe url1
NAME     STATE          URL     PORT
url1     Not Pushed     ://     8080
There are local changes. Please run 'odo push'.

Things look good otherwise.

[dharmit]

Besides that, is it expected that we don't get the URL info after doing odo push? Here's the output I'm seeing after doing odo push. Note that odo url describe <url> doesn't show the URL while odo url list does:

$ odo url describe url2        
NAME     STATE      URL     PORT
url2     Pushed     ://     8080

$ odo url describe url1 
NAME     STATE      URL     PORT
url1     Pushed     ://     8080

$ odo url list
Found the following URLs for component nodejs-nodejs-ex-zali in application app:
NAME     STATE      URL                                             PORT     SECURE
url1     Pushed     https://url1-app-myproject.apps-crc.testing     8080     true
url2     Pushed     http://url2-app-myproject.apps-crc.testing      8080     false

[mik-dass]

@mik-dass I'm not sure what's the expected behaviour here but, odo url list shows if a URL is secure or not. However, odo url describe doesn't. Is this expected?:

Yes because currently, for the master branch, the ouput of url describe doesn't have a secure column for displaying secure or not. It shows the info in json output though.

Besides that, is it expected that we don't get the URL info after doing odo push? Here's the output I'm seeing after doing odo push. Note that odo url describe doesn't show the URL while odo url list does

This seems to be in the latest master too

[mrinaldas@localhost che-nodejs]$ odo url list
Found the following URLs for component nodejs-che-nodejs-ybjc in application app:
NAME        STATE      URL                                                        PORT     SECURE
example     Pushed     http://example-app-blah.b6ff.rh-idev.openshiftapps.com     8080     false
[mrinaldas@localhost che-nodejs]$ odo url describe example
NAME        STATE      URL     PORT
example     Pushed     ://     8080

[dharmit]

This seems to be in the latest master too

[mrinaldas@localhost che-nodejs]$ odo url list
Found the following URLs for component nodejs-che-nodejs-ybjc in application app:
NAME        STATE      URL                                                        PORT     SECURE
example     Pushed     http://example-app-blah.b6ff.rh-idev.openshiftapps.com     8080     false
[mrinaldas@localhost che-nodejs]$ odo url describe example
NAME        STATE      URL     PORT
example     Pushed     ://     8080

Do you think it should be fixed? I can open a different issue for it since it's obviously not a part of this PR. WDYT?

[mik-dass]

Do you think it should be fixed? I can open a different issue for it since it's obviously not a part of this PR. WDYT?

Created issue #3274

[dharmit]

/lgtm

[kadel]

/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [kadel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[mik-dass]

[odo] I0603 00:45:27.083489   12865 occlient.go:1764] Status of ref-test-app-1 build is Failed
[odo]  ✗  Waiting for build to finish [1m]
[odo]  ✗  Failed to create component with name ref-test. Please use `odo config view

/retest

[mik-dass]

• Failure [317.853 seconds]
odo devfile watch command tests
/go/src/github.com/openshift/odo/tests/integration/devfile/cmd_devfile_watch_test.go:15
  when executing odo watch after odo push with custom commands
  /go/src/github.com/openshift/odo/tests/integration/devfile/cmd_devfile_watch_test.go:115
    should listen for file changes [It]
    /go/src/github.com/openshift/odo/tests/integration/devfile/cmd_devfile_watch_test.go:116
    Timeout out after � minutes
    /go/src/github.com/openshift/odo/tests/helper/helper_generic.go:148

/retest

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.