Update dependencies in glide.yaml for make to succeed in building odo binary #3369

dharmit · 2020-06-17T13:39:48Z

What type of PR is this?
/kind code-refactoring

What does does this PR do / why we need it:
This PR is based on doing glide update -v and trying to fix the errors to help make succeed in building the odo binary. This is proposed as a separate PR because glide update -v on the current master branch breaks make.

Which issue(s) this PR fixes:
None. But it unblocks #2920 as well as @mik-dass.
More info can be found on #2920 (comment) and discussion thereafter.

How to test changes / Special notes to the reviewer:
CI should pass.

pkg/lclient/fakeclient.go

mik-dass · 2020-06-18T06:04:58Z

pkg/lclient/fakeclient.go

+	},
+	types.ContainerJSON{
+		ContainerJSONBase: &types.ContainerJSONBase{
+			Name:  "/go-test",


You need to update the config labels for this too https://github.com/openshift/odo/blob/master/pkg/lclient/fakeclient.go#L61

Why? It's not related to anything we've modified so far in this. 🤔

Also, the tests are complaining elsehwere:

Applying URL changes ✓ URL example: https://example.com created Applying URL changes ✓ URL example: https://example.com created --- FAIL: TestListDockerURL (0.00s) url_test.go:1471: Expected error since no physical env file to write url_test.go:1476: Expected error since no physical env file to write --- FAIL: TestListDockerURL/Case_1:_Successfully_retrieve_the_URL_list (0.00s) panic: runtime error: invalid memory address or nil pointer dereference [recovered] panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x1f22172] goroutine 73 [running]: testing.tRunner.func1.1(0x2091700, 0x3455d90) /usr/lib/golang/src/testing/testing.go:940 +0x421 testing.tRunner.func1(0xc000223680) /usr/lib/golang/src/testing/testing.go:943 +0x600 panic(0x2091700, 0x3455d90) /usr/lib/golang/src/runtime/panic.go:975 +0x3e3 github.com/openshift/odo/pkg/url.ListDockerURL(0xc000560b20, 0x22673bc, 0x6, 0xc00007fbc0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...) /home/dshah/go/src/github.com/openshift/odo/pkg/url/url.go:528 +0xc92 github.com/openshift/odo/pkg/url.TestListDockerURL.func1(0xc000223680) /home/dshah/go/src/github.com/openshift/odo/pkg/url/url_test.go:1528 +0xd1 testing.tRunner(0xc000223680, 0xc000560f40) /usr/lib/golang/src/testing/testing.go:991 +0x1ec created by testing.(*T).Run /usr/lib/golang/src/testing/testing.go:1042 +0x661 FAIL github.com/openshift/odo/pkg/url 0.758s ok github.com/openshift/odo/pkg/url/labels (cached) --- FAIL: TestGetAbsPath (0.00s) util_test.go:513: Running test: Case 1: Valid abs path resolution of `~` --- FAIL: TestGetAbsPath/Case_1:_Valid_abs_path_resolution_of_`~` (0.00s) util_test.go:538: Expected /home/dshah/, got /home/dshah util_test.go:513: Running test: Case 2: Valid abs path resolution of `.` FAIL FAIL github.com/openshift/odo/pkg/util 0.504s ? github.com/openshift/odo/pkg/version [no test files] ok github.com/openshift/odo/pkg/watch (cached) FAIL make: *** [Makefile:144: test] Error 1

Why? It's not related to anything we've modified so far in this. 🤔

Ah, my bad.

pkg/lclient/fakeclient.go

dharmit · 2020-06-18T08:27:32Z

Travis failure looks unrelated to the changes made:

[odo]  ✗  Creating component [192ms]
[odo]  ✗  Failed to create component with name nodejs. Please use `odo config view` to view settings used to create component. Error: failed to create component with args {Name:nodejs SourcePath:./ SourceRef: SourceType:local ImageName:nodejs EnvVars:[DEBUG_PORT=5858] Ports:[8080/TCP] Resources:&ResourceRequirements{Limits:ResourceList{},Requests:ResourceList{},} ApplicationName:nodeapp Wait:false StorageToBeMounted:map[/mnt/pv1:&PersistentVolumeClaim{ObjectMeta:{pv1-nodeapp-pvc  ckbbugylgw /api/v1/namespaces/ckbbugylgw/persistentvolumeclaims/pv1-nodeapp-pvc 17dc54ec-b137-11ea-bac5-42010a1e0034 3398 0 2020-06-18 07:41:16 +0000 UTC <nil> <nil> map[app:nodeapp app.kubernetes.io/instance:nodejs app.kubernetes.io/managed-by:odo app.kubernetes.io/managed-by-version:v1.2.2 app.kubernetes.io/part-of:nodeapp app.kubernetes.io/storage-name:pv1] map[] [] [kubernetes.io/pvc-protection]  []},Spec:PersistentVolumeClaimSpec{AccessModes:[ReadWriteOnce],Resources:ResourceRequirements{Limits:ResourceList{},Requests:ResourceList{storage: {{1073741824 0} {<nil>} 1Gi BinarySI},},},VolumeName:,Selector:nil,StorageClassName:nil,VolumeMode:nil,DataSource:nil,},Status:PersistentVolumeClaimStatus{Phase:Pending,AccessModes:[],Capacity:ResourceList{},Conditions:[]PersistentVolumeClaimCondition{},},}] StdOut:<nil>}: unable to update owner reference of storage: Operation cannot be fulfilled on persistentvolumeclaims "pv1-nodeapp-pvc": the object has been modified; please apply your changes to the latest version and try again
Deleting project: ckbbugylgw
Running odo with args [odo project delete ckbbugylgw -f]
[odo] I0618 07:41:17.459903   24338 application.go:49] Unable to list Service Catalog instances: unable to list ServiceInstances: serviceinstances.servicecatalog.k8s.io is forbidden: User "developer" cannot list serviceinstances.servicecatalog.k8s.io in the namespace "ckbbugylgw": no RBAC policy matched
[odo] This project contains the following applications, which will be deleted
[odo] Application nodeapp
[odo] I0618 07:41:17.473653   24338 occlient.go:2825] Getting DeploymentConfig: nodejs-nodeapp
[odo] I0618 07:41:17.496363   24338 component.go:987] Source for component nodejs is  (local)
[odo] I0618 07:41:17.496379   24338 url.go:379] Listing routes with label selector: app.kubernetes.io/part-of=nodeapp,app.kubernetes.io/instance=nodejs
[odo] I0618 07:41:17.496384   24338 occlient.go:2684] Listing routes with label selector: app.kubernetes.io/part-of=nodeapp,app.kubernetes.io/instance=nodejs
[odo] I0618 07:41:17.510614   24338 occlient.go:2825] Getting DeploymentConfig: nodejs-nodeapp
[odo] This application has following components that will be deleted
[odo] I0618 07:41:17.551070   24338 occlient.go:2825] Getting DeploymentConfig: nodejs-nodeapp
[odo] I0618 07:41:17.554933   24338 component.go:987] Source for component nodejs is  (local)
[odo] I0618 07:41:17.554953   24338 url.go:379] Listing routes with label selector: app.kubernetes.io/part-of=nodeapp,app.kubernetes.io/instance=nodejs
[odo] I0618 07:41:17.554958   24338 occlient.go:2684] Listing routes with label selector: app.kubernetes.io/part-of=nodeapp,app.kubernetes.io/instance=nodejs
[odo] I0618 07:41:17.560637   24338 occlient.go:2825] Getting DeploymentConfig: nodejs-nodeapp
[odo] I0618 07:41:17.623986   24338 request.go:565] Throttling request took 63.29841ms, request: GET:https://127.0.0.1:8443/apis/apps.openshift.io/v1/namespaces/ckbbugylgw/deploymentconfigs/nodejs-nodeapp
[odo] I0618 07:41:17.824009   24338 request.go:565] Throttling request took 196.963633ms, request: GET:https://127.0.0.1:8443/apis/apps.openshift.io/v1/namespaces/ckbbugylgw/deploymentconfigs?labelSelector=app.kubernetes.io%2Fpart-of%3Dnodeapp%2Capp.kubernetes.io%2Finstance%3Dnodejs
[odo] component named nodejs
[odo] No services / could not get services
[odo] I0618 07:41:17.830676   24338 project.go:136] unable to list services: unable to list ServiceInstances: serviceinstances.servicecatalog.k8s.io is forbidden: User "developer" cannot list serviceinstances.servicecatalog.k8s.io in the namespace "ckbbugylgw": no RBAC policy matched
[odo]  ✓  Deleted project : ckbbugylgw
[odo]  ⚠  Warning! Projects are deleted from the cluster asynchronously. Odo does its best to delete the project. Due to multi-tenant clusters, the project may still exist on a different node.
[odo] I0618 07:41:17.836219   24338 odo.go:72] Could not get the latest release information in time. Never mind, exiting gracefully :)
Deleting dir: /tmp/836974187
• Failure [3.114 seconds]
odo storage command tests
/home/travis/gopath/src/github.com/openshift/odo/tests/integration/cmd_storage_test.go:13
  when using storage command with default flag values
  /home/travis/gopath/src/github.com/openshift/odo/tests/integration/cmd_storage_test.go:53
    should add a storage, list and delete it [It]
    /home/travis/gopath/src/github.com/openshift/odo/tests/integration/cmd_storage_test.go:54
    No future change is possible.  Bailing out early after 0.594s.
    Running odo with args [odo push --context /tmp/836974187]
    Expected
        <int>: 1
    to match exit code:
        <int>: 0
    /home/travis/gopath/src/github.com/openshift/odo/tests/helper/helper_run.go:34

dharmit · 2020-06-18T09:28:22Z

/test v4.5-integration-e2e
#2641

 • Failure [341.483 seconds]
odo supported images e2e tests
/go/src/github.com/openshift/odo/tests/e2escenarios/e2e_images_test.go:14
  odo supported images deployment
  /go/src/github.com/openshift/odo/tests/e2escenarios/e2e_images_test.go:83
    Should be able to verify the centos7-s2i-nodejs:10.x image [It]
[Fail] odo supported images e2e tests odo supported images deployment [It] Should be able to verify the centos7-s2i-nodejs:10.x image 
/go/src/github.com/openshift/odo/tests/helper/helper_generic.go:140
Ran 23 of 23 Specs in 873.305 seconds
FAIL! -- 22 Passed | 1 Failed | 0 Pending | 0 Skipped

codecov · 2020-06-18T12:03:11Z

Codecov Report

Merging #3369 into master will increase coverage by 0.16%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #3369      +/-   ##
==========================================
+ Coverage   45.94%   46.11%   +0.16%     
==========================================
  Files         111      111              
  Lines       11034    11064      +30     
==========================================
+ Hits         5070     5102      +32     
+ Misses       5474     5470       -4     
- Partials      490      492       +2

Impacted Files	Coverage Δ
pkg/lclient/fakeclient.go	`82.11% <0.00%> (+4.13%)`	⬆️
pkg/url/url.go	`64.14% <0.00%> (+0.83%)`	⬆️
pkg/sync/sync.go	`48.51% <0.00%> (+2.97%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6766eb0...09841c4. Read the comment docs.

dharmit · 2020-06-18T13:38:50Z

@johnmcollier @yangcao77 We need your inputs on this. Not just PR review, but we need you to let us know if the changes proposed in this PR could break anything w.r.t. docker support. Pinged you folks because you worked the most on adding docker support.

@adisky @girishramnani @kadel if you have any inputs on this, please let us know.

yangcao77 · 2020-06-18T18:37:59Z

Most of the PR changes are dependencies changes, I don't see any impact on docker URL, which I was specifically working on.
The changes to test code looks good to me as well.

dharmit · 2020-06-19T06:47:34Z

Looks like the tests failed because of lack of resources on the infra.
4.2 failure logs:

 2020/06/18 12:24:41 Acquiring lease for "aws-quota-slice"
2020/06/18 14:24:41 No custom metadata found and prow metadata already exists. Not updating the metadata.
2020/06/18 14:24:42 Ran for 2h3m37s
error: some steps failed:
  * could not run steps: step integration-e2e failed: failed to acquire lease: resources not found
time="2020-06-18T14:24:42Z" level=info msg="Reporting job state \"failed\" with reason \"executing_graph:step_failed:utilizing_lease:acquiring_lease\""

4.5 failure logs:

 2020/06/18 14:24:55 No custom metadata found and prow metadata already exists. Not updating the metadata.
2020/06/18 14:24:56 Ran for 2h4m4s
error: some steps failed:
  * could not run steps: step integration-e2e failed: failed to acquire lease: resources not found
time="2020-06-18T14:24:56Z" level=info msg="Reporting job state \"failed\" with reason \"executing_graph:step_failed:utilizing_lease:acquiring_lease\""

/retest

dharmit · 2020-06-19T06:53:25Z

Travis failures look to be related to failure in pulling images from quay.io:

[odo]  ✗  Failed to start component with name gmerej.
[odo] Error: Failed to create the component: unable to create or update component: unable to pull and start container runtime for component gmerej: Unable to pull quay.io/eclipse/che-nodejs10-ubi:nightly image: Unable to pull image: Error response from daemon: Get https://quay.io/v2/: EOF
[odo]  ✗  Pulling image quay.io/eclipse/che-nodejs10-ubi:nightly [78ms]
Removing locally running Docker images with label component=gmerejListing locally running Docker images with label component=gmerejRunning docker with args [docker ps -q --filter label=component=gmerej]
Setting current dir to: /home/travis/gopath/src/github.com/openshift/odo/tests/integration/devfile/docker
Deleting dir: /tmp/419640540
• Failure [16.312 seconds]
odo docker devfile url pushtarget command tests
/home/travis/gopath/src/github.com/openshift/odo/tests/integration/devfile/docker/cmd_docker_devfile_url_pushtarget_test.go:14
  Switching pushtarget
  /home/travis/gopath/src/github.com/openshift/odo/tests/integration/devfile/docker/cmd_docker_devfile_url_pushtarget_test.go:44
    switch from kube to docker, odo push should display warning [It]
    /home/travis/gopath/src/github.com/openshift/odo/tests/integration/devfile/docker/cmd_docker_devfile_url_pushtarget_test.go:63

and

[odo] I0618 12:47:50.059616   10676 utils.go:86] Found component "Container" with name "runtime"
[odo]  •  Pulling image quay.io/eclipse/che-nodejs10-ubi:nightly  ...
[odo]  ✗  Pulling image quay.io/eclipse/che-nodejs10-ubi:nightly [15s]
[odo]  ✗  Failed to start component with name lhvfye.

girishramnani · 2020-06-19T07:01:32Z

/approve

openshift-ci-robot · 2020-06-19T07:01:51Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: girishramnani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [girishramnani]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

adisky · 2020-06-19T07:03:51Z

@dharmit looks good to me, There should be no problem in future too as we updated our docker mock client as per docker api.

dharmit · 2020-06-19T12:58:00Z

4.5 failure looks like a flake since it's happening in JustBeforeEach IIUC:

 Created dir: /tmp/745678176
Creating a new project: esmqrrjxge
Running odo with args [odo project create esmqrrjxge -w -v4]
[odo]  ✗  invalid configuration: [context was not found for specified context: uujiobnmxh/api-ci-op-c6zsjp7f-2f74e-origin-ci-int-aws-dev-rhcloud-com:6443/developer, cluster has no server defined]
[odo] Please login to your server: 
[odo] 
[odo] odo login https://mycluster.mydomain.com
[odo] 
Deleting project: amcjulaaaa
Running odo with args [odo project delete amcjulaaaa -f]
[odo]  ✗  The project amcjulaaaa does not exist. Please check the list of projects using `odo project list`
Deleting dir: /tmp/745678176
• Failure in Spec Setup (JustBeforeEach) [0.820 seconds]
odo component command tests
/go/src/github.com/openshift/odo/tests/integration/cmd_cmp_test.go:13
  Creating component
  /go/src/github.com/openshift/odo/tests/integration/component.go:52
    should error when listing components (basically anything other then creating) with --project and --context  [JustBeforeEach]
    /go/src/github.com/openshift/odo/tests/integration/component.go:80
    No future change is possible.  Bailing out early after 0.134s.
      
    Running odo with args [odo project create esmqrrjxge -w -v4]
    Expected
        <int>: 1
    to match exit code:
        <int>: 0

Weirdly, 4.2 is also failing due to project creation error:

 Created dir: /tmp/880224045
Creating a new project: nckoeoehmn
Running odo with args [odo project create nckoeoehmn -w -v4]
[odo]  •  Waiting for project to come up  ...
[odo]  ✗  Timeout: request did not complete within requested timeout 30s
[odo]  ✗  Waiting for project to come up [30s]
Deleting project: 
Running odo with args [odo project delete  -f]
[odo] I0619 07:31:24.680148    9656 request.go:757] Error in request: resource name may not be empty
[odo]  ✗  The project  does not exist. Please check the list of projects using `odo project list`
• Failure in Spec Setup (BeforeEach) [31.058 seconds]
odo storage command tests
/go/src/github.com/openshift/odo/tests/integration/cmd_storage_test.go:13
  when running storage list command to check state [BeforeEach]
  /go/src/github.com/openshift/odo/tests/integration/cmd_storage_test.go:144
    should list storage with correct state
    /go/src/github.com/openshift/odo/tests/integration/cmd_storage_test.go:145
    No future change is possible.  Bailing out early after 30.622s.
      
    Running odo with args [odo project create nckoeoehmn -w -v4]
    Expected
        <int>: 1
    to match exit code:
        <int>: 0

/retest

girishramnani · 2020-06-19T16:37:28Z

I am gonna LGTM this even though I am also the approver because the AC of this PR is about updating the deps and make the tests pass in the process. Which is achieved.
/lgtm

openshift-bot · 2020-06-19T23:46:12Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-06-20T07:20:59Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-06-20T14:03:54Z

/retest

Please review the full test history for this PR and help us cut down flakes.

dharmit · 2020-06-22T05:21:17Z

I am gonna LGTM this even though I am also the approver because the AC of this PR is about updating the deps and make the tests pass in the process. Which is achieved.
/lgtm

Thank you!

@cdrage

* add mik-dass and dharmit as top level approvers (redhat-developer#3189) * Add .gitignore files for jekyll / site (redhat-developer#3171) **What type of PR is this?** > Uncomment only one ` /kind` line, and delete the rest. > For example, `> /kind bug` would simply become: `/kind bug` /kind code-refactoring **What does does this PR do / why we need it**: Updates the `.gitignore` for html and jekyll information. As I kept having to `git clean` the dir. **Which issue(s) this PR fixes**: N/A **How to test changes / Special notes to the reviewer**: N/A Signed-off-by: Charlie Drage <charlie@charliedrage.com> * Performance improvement for odo catalog list components when using devfiles (redhat-developer#3112) * feat: parallel fetching of component types to improve performance Fix redhat-developer#3105 as we now also fetch devfiles for completion, which was previously prohibitively slow. * fix: add missing mutex, rename existing one for clarity * refactor: simplify getDevfileWith by computing link within function * docs: add documentation, update existing one * refactor: rename wg to devfileWG for clarity * fix: improper test setup * fix: only filter components if there's no error * fix: re-implement using channels, handle error and timeout better * fix: no need to pass error * fix: populate base in GetDevfileIndex, use registry URL, hiding path * fix: properly retrieve all devfiles Performance is not that great so investigating better options. * fix: use new ConcurrentTasks support, allowing proper error reporting * fix: adapt to dynamic registries * feat: simplify ConcurrentTask by hiding WaitGroup It was too easy to forget calling Done in ToRun leading to deadlocks. * fix: broken tests * fix: wording [skip ci] * fix: remove unused function, added doc [skip ci] * fix: remove unused ErrorWrapper [skip ci] * fix: rename package import [skip ci] * fix: test getDevfileIndexEntries directly, remove now unused function * JSON output for service list in experimental mode (redhat-developer#3186) * JSON output for service list in experimental mode * Changes to tests as per PR feedback redhat-developer#3186 (review) * Adds a document for debugging applications using devfiles (redhat-developer#3187) * Adds a document for debugging applications using devfiles * Updated syntax and improving the wording Signed-off-by: mik-dass <mrinald7@gmail.com> * Actually wait for the project to be deleted.. (redhat-developer#2397) Actually wait.. Signed-off-by: Charlie Drage <charlie@charliedrage.com> * Run devfile docker url tests without kube config (redhat-developer#3223) * Run devfile docker url tests without kube config Signed-off-by: John Collier <John.J.Collier@ibm.com> * Update target Signed-off-by: John Collier <John.J.Collier@ibm.com> * Fix typo Signed-off-by: John Collier <John.J.Collier@ibm.com> * Setting golang version uniformly accross repo and updating docs (redhat-developer#3204) * Setting golang version uniformly accross repo and updating docs - All golang version references now uniformly updated to 1.12 - Adding all golang version references to development.adoc Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com> * Adding golang warning to admonition block Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com> * Removing unnessasary space Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com> * Adding back warning as github does not render admonition in normal view Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com> * Fixing the warning to look better Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com> * Fixing up the list title Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com> * Fixing up admonishments Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com> * Fixing commits as per @cdrage comments Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com> * Fix odo describe not listing all the ports after first url is created (redhat-developer#3224) * Fix odo describe not listing all the ports after first url is created This PR fixes redhat-developer#3201. Signed-off-by: Denis Golovin dgolovin@redhat.com * update tests Co-authored-by: Tomas Kral <tkral@redhat.com> * Support listing devfile components with no devBuild command (redhat-developer#3172) * Don't require devfiles to have a devBuild command Signed-off-by: John Collier <John.J.Collier@ibm.com> * Update integration tests Signed-off-by: John Collier <John.J.Collier@ibm.com> * Update integration test Signed-off-by: John Collier <John.J.Collier@ibm.com> * Update integration test for odo create Signed-off-by: John Collier <John.J.Collier@ibm.com> * Make devRun check case-insensitive Signed-off-by: John Collier <John.J.Collier@ibm.com> * replace secured with secure (redhat-developer#3238) A typo existing in sample file * Running devfile integration tests on kubernetes cluster (redhat-developer#3233) * Document to run tests on kubernetes cluster * Addressed review comment * Updated the doc as per reviewer request * Modify operator hub tests to run in separate namespaces (redhat-developer#3239) * Modify operator hub tests to run in separate namespaces **What type of PR is this?** /kind cleanup /kind failing-test **What does does this PR do / why we need it**: This PR ensures that each test spec for operator hub is run in a separate namespace. This is needed because these tests were written in a stringent fashion which tied the hands while writing additional tests for the feature. This PR should help take the tests out of the "odo test statistics" dashboard. **Which issue(s) this PR fixes**: Fixes redhat-developer#3193 **How to test changes / Special notes to the reviewer**: CI should pass. Specially for Operator Hub tests under `tests/integration/operatorhub` * Changes as per PR review * Remove createEtcdClusterService function and more separate specs - Removed the function because it *seemed* to be leading to race conditions - Separating specs for the same reason * Loop for two operators * Make operator hub tests sequential We're doing this because parallel run is causing numerous failures in CI and local. In spite of debugging it for some time, we're not able to fix it. However, we're on a deadline because operator hub failures are showing up across the PRs. Hence, for time being, we're making these tests sequential. redhat-developer#3244 * Add devfile command flags to watch (redhat-developer#3075) * save non default devfile cmd in env.yaml for push and watch Signed-off-by: Maysun J Faisal <maysun.j.faisal@ibm.com> * Add and update tests for envinfo Signed-off-by: Maysun J Faisal <maysun.j.faisal@ibm.com> * Update watch test to incl new watch param Signed-off-by: Maysun J Faisal <maysun.j.faisal@ibm.com> * watch integration test Signed-off-by: Maysun J Faisal <maysun.j.faisal@ibm.com> * Display msg when devfile commands are changed via odo push Signed-off-by: Maysun J Faisal <maysun.j.faisal@ibm.com> * Change Logic for watch flag + feedback 1 Signed-off-by: Maysun J Faisal <maysun.j.faisal@ibm.com> * Update Watch tests with feedback Signed-off-by: Maysun J Faisal <maysun.j.faisal@ibm.com> * disable watch test on kube since we now use oc Signed-off-by: Maysun J Faisal <maysun.j.faisal@ibm.com> * Watch test feedback 2 Signed-off-by: Maysun J Faisal <maysun.j.faisal@ibm.com> * Adding sparseCheckoutDir functionality to devfiles (redhat-developer#3042) * Initial commit * added devfile * added tests * commented out tests * change to validpath statement * changed method of extracting zip * changed pathsToUnzip to pathToUnzip * Added error message when no files are unzipped * cleaned up conditional prefix trim * Changes from feedback * feedback changes and unit tests for util func * check for empty pathToUnzip * changed error message format * cleaned up path separator for windows * fixed return pathToUnzip * use hassuffix * moved to function * fromslash * minor fixes * lowercase fix for test * Run test locally against 4.* Cluster (redhat-developer#3218) * Run test locally against 4.* Cluster * Added review comments * Added few more review comments * Addressed review comments * Addressed review comments * Addressed correct format review comments * Update samples for deploying a devfile in deploying-a-devfile-using-odo.adoc (redhat-developer#3163) * Update devfile doc samples [skip ci] Signed-off-by: John Collier <John.J.Collier@ibm.com> * Address review comments Signed-off-by: John Collier <John.J.Collier@ibm.com> * Fix formatting Signed-off-by: John Collier <John.J.Collier@ibm.com> * Replace multiple expect statement with MatchAllInOutput and DontMatchAllInOutput (redhat-developer#3251) * Replaced multiple expect assert statement with MatchAllInOutput * Replaced multiple expect check within same variable with MatchAllInOutput and DontMatchAllInOutput throughout the test * Formatted string array which were exceeding 120 character * add state to ingress list and describe (redhat-developer#3160) * add state to ingress list and describe Signed-off-by: Stephanie <stephanie.cao@ibm.com> * use URL struct in url describe and list * add unit tests Signed-off-by: Stephanie <stephanie.cao@ibm.com> * modify integration test and add more unit tests Signed-off-by: Stephanie <stephanie.cao@ibm.com> * remove types created * address review comment * delete removed tests Signed-off-by: Stephanie <stephanie.cao@ibm.com> * return error if the error is not notfound Signed-off-by: Stephanie <stephanie.cao@ibm.com> * list multiple ulrs in test Signed-off-by: Stephanie <stephanie.cao@ibm.com> * Don't prompt for namespace if pushtarget is Docker (redhat-developer#3248) Signed-off-by: John Collier <John.J.Collier@ibm.com> * Fix windows incompatibility with /tmp (redhat-developer#3252) * Fix checkForImageStream to return correct result. (redhat-developer#3281) * Add Support for Devfile V2 (redhat-developer#3216) * Add Devfile Parser V2, Update Common Structs (redhat-developer#3188) * Add Devfile Parser for Version 2.0.0 Added Devfile V2 Go Structures Added converter for v2 ro common types Signed-off-by: adisky <adsharma@redhat.com> * Add example V2 devfile added example nodejs V2 devfile * Add Common Types as V2 Add common types as v2 Add Converter from common to v1 * Updated example devfile with group * Fixes command.go and kubernetes adapter (redhat-developer#3194) Signed-off-by: mik-dass <mrinald7@gmail.com> * Fixes utils of k8s adapter (redhat-developer#3195) * Update Command Logic to use groups (redhat-developer#3196) * Updates create logic to v2 (redhat-developer#3200) * Fixes utils of docker docker adapter (redhat-developer#3198) Signed-off-by: mik-dass <mrinald7@gmail.com> * Update Docker and Kubernetes adapter to use groups (redhat-developer#3206) * Update Docker and Kubernetes adapter to use groups * Update Some Validation Incorporate some review comments for commands Map Update Some Validation logic * Updated Logs for V2 (redhat-developer#3208) Fixed interface implementation for v2 Updated logs refactored commands.go * Avoid String Pointers (redhat-developer#3209) While converting v1 to v2 types, string pointers are prone to cause null pointer error. This PR updates struct fields from string pointers to string * Update commands check * Fixes lower and upper case for commands (redhat-developer#3219) * Fixes type of project and components for devfile v1 (redhat-developer#3228) * Update testing utils (redhat-developer#3220) * Update command tests Updated Command tests to v2 Removed some cases like command type validation, that will be validated by schema only. * Fix common adapters tests All devfile.adapters.common unit tests are fixed * Add tests for Mismatched type Fix devfile.adapters.Kubernetes.Component unit tests * Add TestCase for default command * Design proposal: Event notification support for build and application status for IDE integration for devfile scenarios (redhat-developer#2550) (redhat-developer#3177) * Add event notification proposal [skip ci] * Update event-notification.md * Update event-notification.md * Update event-notification.md * Update event-notification.md * Update event-notification.md * Update event-notification.md * Update event-notification.md * Update event-notification.md * Fix Integration tests for devfile v2 (redhat-developer#3236) * Fix Integration tests Correct volume structure Fix supervisord binary insertion for docker Insert command and args in build container fr docker * Fix Integration tests Revert commands, args removal Add commands, args in v2 common structs Fix duplicate volume error * Fixes unit tests (redhat-developer#3240) Signed-off-by: mik-dass <mrinald7@gmail.com> * Add devfiles V2 examples (redhat-developer#3253) Add devfiles v2 examples for springboot and nodejs * Fix regression by sparse checkout dir PR (redhat-developer#3258) fix regression caused by rebase to master. Also add github, zip as supported project types. * Address review comments (redhat-developer#3267) * Address review comments part 2 fix log levels to v4 fix error formatting add case no's in test cases update some comments * Address review comments part 2 Remove validation for group Co-authored-by: Mrinal Das <mrinald7@gmail.com> Co-authored-by: Jonathan West <jgwest@users.noreply.github.com> * devfile push Integration test on kubernetes cluster (redhat-developer#3041) * Running devfile push integration test on kubernetes cluster * Updated xenial insecure registry path * Modifying Runner variable name to cliRunner * Common project Create and Delete function according to the running cluster * Added checks for CI to copy kubeconfig to temp dir * Skipping Kubeconfig set to temporary config file for prow * Set Kubeconfig in temporary config file on kubernetes cluster only * Fixes Kubeconfig code sync * Separate out function for getting cliRunner * Release 1.2.2 of odo (redhat-developer#3294) **What type of PR is this?** > Uncomment only one ` /kind` line, and delete the rest. > For example, `> /kind bug` would simply become: `/kind bug` /kind feature **What does does this PR do / why we need it**: Releases 1.2.1 of odo **Which issue(s) this PR fixes**: N/A **How to test changes / Special notes to the reviewer**: N/A Signed-off-by: Charlie Drage <charlie@charliedrage.com> * Fixes list and describe of secure URLs for not pushed components (redhat-developer#3269) * Don't show imagestreams error on experimental mode (redhat-developer#3265) * Don't show imagestreams error on experimental mode Signed-off-by: John Collier <John.J.Collier@ibm.com> * Remove unnecessary line Signed-off-by: John Collier <John.J.Collier@ibm.com> * Move where error message printed Signed-off-by: John Collier <John.J.Collier@ibm.com> * Use %q instead Signed-off-by: John Collier <John.J.Collier@ibm.com> * remove openshift logo from readme (redhat-developer#3301) * Remove unnecessary preference set (redhat-developer#3287) * report error can't find the app (redhat-developer#2927) * Update build/VERSION to 1.2.2 (redhat-developer#3306) **What type of PR is this?** > Uncomment only one ` /kind` line, and delete the rest. > For example, `> /kind bug` would simply become: `/kind bug` /kind feature **What does does this PR do / why we need it**: Updates the build version to 1.2.2 **Which issue(s) this PR fixes**: N/A **How to test changes / Special notes to the reviewer**: N/A Signed-off-by: Charlie Drage <charlie@charliedrage.com> * Update tests to use java-openliberty (redhat-developer#3318) * Removing install script and update other references (redhat-developer#3202) * Removing installer scripts and references in other scripts and readme Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com> * Removing installer reference from development.adoc Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com> * Adding a message to installer script so as to not break it for existing users Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com> * Removing unused variable which is no longer needed Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com> * Removing installer again Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com> * Removing unused secret directory (redhat-developer#3290) * devfile delete Integration test on kubernetes cluster (redhat-developer#2913) * Run devfile delete integration test on kubernetes cluster * Adding insecure registry in Docker configuration xenial ubuntu * Fix namespace issue for url create --now (redhat-developer#3321) * Add --devfile flag support (redhat-developer#3118) * feat: add --devfile flag support Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com> * fix: fix gosec G307 issue Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com> * fix: update error handling Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com> * style: Update help and error messages Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com> * fix: Improve performance of error handling Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com> * style: Improve error message Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com> * fix: Fix remove file error on Windows Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com> * fix: Use existing structure to handle temp file Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com> * refactor: improve code readability and structure Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com> * docs: update variable comments Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com> * feat: --devfile value supports http(s) Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com> * feat: remove --devfile for all other commands Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com> * feat: add new design for existing devfile support Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com> * test: update TestCopyFile test cases Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com> * test: refactor file copy util function for test Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com> * test: fix TestCopyFile test cases Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com> * test: add integration tests for existing devfile Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com> * fix: gosec issue Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com> * test: fix docker url integration tests Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com> * fix: context support Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com> * test: fix docker url integration tests Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com> * fix: handle edge cases and add related tests Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com> * refactor: separate spinner for existing devfile Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com> * test: fix docker watch tests Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com> * test: fix url tests Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com> * Updating travis env variable and adding docker version info (redhat-developer#3068) * 'odo login' command should suggest 'odo project list' instead of 'odo projects' (redhat-developer#3262) * use a more specific error message for when image is not found (redhat-developer#3322) * use a specific error message for when image is not found * added amit's changes * devfile create Interation test on kubernetes cluster using travis CI (redhat-developer#2884) * Run devfile create Interation test on kubernetes cluster * Skipping s2i image related test on kubernetes cluster * Updating url delete to apply `--now` on devfile (redhat-developer#3139) * Creating a function for setting devfile path * updating url delete to do devfile push post delete Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com> * Adding URL now flag delete test Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com> * Fixing missing `-f` Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com> * Changing position of copyexample Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com> * Merging url delete with now with create Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com> * Removing old devfilepath logic Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com> * Adding Devfile flag to url delete Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com> * CompleteDevfilePath now happens irrespective of now Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com> * list devfile components catalog in json format (redhat-developer#3264) * list catalog in json format for devfile components Signed-off-by: Stephanie <stephanie.cao@ibm.com> * list devfile registries in list * combined two list into one single list Signed-off-by: Stephanie <stephanie.cao@ibm.com> * add omitempty * Fix unsafe data race in ExecuteCommand (redhat-developer#3310) **What type of PR is this?** /kind bug **What does does this PR do / why we need it**: Fixes a potential flake with regards to when writing to cmdOutput at the same time that log.ErrorF(...) is reading from it. **Which issue(s) this PR fixes**: Closes redhat-developer#2828 **How to test changes / Special notes to the reviewer**: N/A, honestly not too sure * Fix Docker Supervisord Vol Initialization (redhat-developer#3129) * apply stashed supervisord docker changes from PR Signed-off-by: Maysun J Faisal <maysun.j.faisal@ibm.com> * rebase 1 with master Signed-off-by: Maysun J Faisal <maysun.j.faisal@ibm.com> * Converts v1 devfiles to v2 (redhat-developer#3279) * Converts v1 devfiles to v2 * Moves init tests to devfilesV1 folder * Adding oc to bin path for multistage testing (redhat-developer#3351) * Revert "Adding oc to bin path for multistage testing (redhat-developer#3351)" (redhat-developer#3360) This reverts commit fa9f7b9. * resolved the gosec issue failing unit tests (redhat-developer#3358) * resolved the gosec issue failing unit tests * resolved typo in the comment * DRYed the code * Warn if --app and --all-apps coexist (redhat-developer#2941) * url list routes and ingress (redhat-developer#3305) * list routes and ingress Signed-off-by: Stephanie <stephanie.cao@ibm.com> * add unit tests * add integration tests and describe partially works Signed-off-by: Stephanie <stephanie.cao@ibm.com> * finished unit test and integration for describe urls * address review comments Signed-off-by: Stephanie <stephanie.cao@ibm.com> * add more unit tests Signed-off-by: Stephanie <stephanie.cao@ibm.com> * fix unit test failure Signed-off-by: Stephanie <stephanie.cao@ibm.com> * fix integration test failure Signed-off-by: Stephanie <stephanie.cao@ibm.com> * use ownerreference to distinguish real route vs route created from ingress Signed-off-by: Stephanie <stephanie.cao@ibm.com> * fix integration test Signed-off-by: Stephanie <stephanie.cao@ibm.com> * address review comment Signed-off-by: Stephanie <stephanie.cao@ibm.com> * fix a bug Signed-off-by: Stephanie <stephanie.cao@ibm.com> * fix a bug Signed-off-by: Stephanie <stephanie.cao@ibm.com> * also test secure state in url describe and list Signed-off-by: Stephanie <stephanie.cao@ibm.com> * try to avoid G404 error in unit test Signed-off-by: Stephanie <stephanie.cao@ibm.com> * Fix 'odo version' integration test. (redhat-developer#3326) * Validate application exist before describe it (redhat-developer#3349) * Update events (redhat-developer#3370) **What type of PR is this?** > Uncomment only one ` /kind` line, and delete the rest. > For example, `> /kind bug` would simply become: `/kind bug` /kind documentation [skip ci] **What does does this PR do / why we need it**: Updates the events to list that they happened in the past **Which issue(s) this PR fixes**: N/A **How to test changes / Special notes to the reviewer**: N/A Signed-off-by: Charlie Drage <charlie@charliedrage.com> * Updates the v2 schema to the latest (redhat-developer#3352) * fix: properly check that odo version contains the server URL (redhat-developer#3365) * fix: properly check that odo version contains the server URL Fixes redhat-developer#3342 * fix: simplify test by removing server url regexp check * Create periodic script for odo periodic job (redhat-developer#3376) * Adds debug command for devfiles (redhat-developer#3059) * Adds debug command for devfiles * Fixes comments and variable names * Adds devfile debug test on kubernetes cluster * Fixes adapter code for debug Signed-off-by: mik-dass <mrinald7@gmail.com> * Converts v1 debug test devfile to v2 * Moves container arg and command overriding to a new function * Simplifies conditions in test * Modifies execDevfile for kubernetes component adapter * Simplies error checking logic in TestUpdateContainersWithSupervisord * Removes unnecessary else if conditions * Installs socat before running tests on kubernetes cluster * Show error message if no registries are configured (redhat-developer#3339) * Show error message if no registries are configured Signed-off-by: John Collier <John.J.Collier@ibm.com> * Clean up Signed-off-by: John Collier <John.J.Collier@ibm.com> * Added few supported container images to e2e image test (redhat-developer#3315) * Fix multiple registry related issues (redhat-developer#3341) * feat: fix registry issues Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com> * docs: improve error/help message Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com> * test: improve registry tests Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com> * feat: github raw url conversion support Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com> * test: refactor testing output format Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com> * test: fix breaking tests Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com> * refactor: add validation for raw url conversion Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com> * Update dependencies in glide.yaml for make to succeed in building odo binary (redhat-developer#3369) * Execute `glide update -v` to update the dependencies * Use ContainerJSON in place of Container struct * Push support: Event notification support for build and application status for IDE integration for devfile scenarios (redhat-developer#3003) * Add machine readable event logging support * Add machine readable event logging support * Add machine readable event logging support * Add machine readable event logging support * Add machine readable event logging support * Add machine readable event logging support * Add machine readable event logging support * Remove --devfile * Remove incorrect constraint * Add odo push -o json example * Rebase and add debug action logging to new methods * Adding oc binary to bin path for multi stage test infra (redhat-developer#3362) * Adding oc binary to bin path for multi stage test infra * Added file permission locally and excluding it from docker file * Created different dockerfile to avoid master break and proceed with multistage changes * Update devfile log levels from 3 to 4 to be consistent (redhat-developer#3408) Signed-off-by: Maysun J Faisal <maysun.j.faisal@ibm.com> * Design proposal: secure registry support (redhat-developer#3329) * docs: add secure registry design proposal Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com> * docs: add create component section Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com> * Add command design for basic auth Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com> * Proposal for odo deploy (redhat-developer#3368) * docs: Initial design proposal for odo deploy command Initial design proposal for adding a odo deply command. This is related to redhat-developer#3300 Signed-off by: Neeraj Laad <neeraj.laad@gmail.com> * Updated future evolution Updated future evolution Signed-off-by: Neeraj Laad <neeraj.laad@gmail.com> * Updates to design Signed-off-by: Neeraj Laad <neeraj.laad@gmail.com> * Update odo-deploy.md * Updated metadata to attributes Updated metadata to attributes * Fixed formatting Fixed formatting for yaml * [skip ci] updated design doc * [skip ci] made credentials flag optional made credentials flag optional * [skip ci] clarify the deplyment example clarify the deplyment example * [skip ci] Updated proposal to sue buildconfig / kaniko * [skip ci] update attribites to metadata * [skip ci] add `alpha.` suffix to metadata keys to indicate this is temporary * [skip ci] Use COMPONENT_NAME as placeholder * Updating script path in Dockerfile for multistage test (redhat-developer#3412) * Invalid ANSI colouring on Windows when doing devfile push (redhat-developer#3327) * show catalog component list -o json as before if experimental mode is off (redhat-developer#3399) Signed-off-by: Stephanie <stephanie.cao@ibm.com> * removed deprecated and nodejs 8 images from e2e tests and README (redhat-developer#3414) * removed deprecated and nodejs 8 images from e2e tests * removed the unsupported images from readme and removed bucharest-gold/centos7-s2i-node from everywhere as the repo has been archived * adjusted the table * Update changelog script (redhat-developer#3421) **What type of PR is this?** > Uncomment only one ` /kind` line, and delete the rest. > For example, `> /kind bug` would simply become: `/kind bug` /kind code-refactoring **What does does this PR do / why we need it**: Updates the changelog script since we were having issues with changelog not completing due to hitting the GitHub API limit. **Which issue(s) this PR fixes**: N/A **How to test changes / Special notes to the reviewer**: N/A Signed-off-by: Charlie Drage <charlie@charliedrage.com> * Release 1.2.3 (redhat-developer#3422) **What type of PR is this?** > Uncomment only one ` /kind` line, and delete the rest. > For example, `> /kind bug` would simply become: `/kind bug` /kind feature **What does does this PR do / why we need it**: Release 1.2.3 of odo **Which issue(s) this PR fixes**: N/A **How to test changes / Special notes to the reviewer**: N/A Signed-off-by: Charlie Drage <charlie@charliedrage.com> * fix 'Timeout out' typo and fix formatting (redhat-developer#3404) * fix 'Timeout out' typo and fix formating * fix typo * pull changes from upstream master * add wwhrd check execption for knative.dev/pkg/test/... Co-authored-by: Tomas Kral <tkral@redhat.com> Co-authored-by: Charlie Drage <charlie@charliedrage.com> Co-authored-by: Chris Laprun <metacosm@users.noreply.github.com> Co-authored-by: Dharmit Shah <shahdharmit@gmail.com> Co-authored-by: Mrinal Das <mrinald7@gmail.com> Co-authored-by: John Collier <John.J.Collier@ibm.com> Co-authored-by: Mohammed Ahmed <mohammed.zee1000@gmail.com> Co-authored-by: Denis Golovin <dgolovin@users.noreply.github.com> Co-authored-by: ji chen <jichenjc@cn.ibm.com> Co-authored-by: Priti Kumari <pkumari@redhat.com> Co-authored-by: Maysun J Faisal <31771087+maysunfaisal@users.noreply.github.com> Co-authored-by: CameronMcWilliam <Cameron.McWilliam@ibm.com> Co-authored-by: Amit Rout <arout@redhat.com> Co-authored-by: Stephanie Cao <stephanie.cao@ibm.com> Co-authored-by: Zheng Xiao Mei <xmzheng@cn.ibm.com> Co-authored-by: Aditi Sharma <adsharma@redhat.com> Co-authored-by: Jonathan West <jgwest@users.noreply.github.com> Co-authored-by: Jingfu Wang <jingfu.j.wang@ibm.com> Co-authored-by: Devang Gaur <dgaur@redhat.com> Co-authored-by: Girish Ramnani <gramnani@redhat.com> Co-authored-by: Girish Ramnani <girishramnani95@gmail.com> Co-authored-by: Neeraj Laad <neeraj.laad@gmail.com>

Execute glide update -v to update the dependencies

c0333b0

openshift-ci-robot added the kind/code-refactoring label Jun 17, 2020

openshift-ci-robot requested review from maysunfaisal and prietyc123 June 17, 2020 13:41

mik-dass reviewed Jun 17, 2020

View reviewed changes

pkg/lclient/fakeclient.go Outdated Show resolved Hide resolved

mik-dass reviewed Jun 18, 2020

View reviewed changes

pkg/lclient/fakeclient.go Outdated Show resolved Hide resolved

mik-dass removed the request for review from prietyc123 June 18, 2020 05:48

mik-dass reviewed Jun 18, 2020

View reviewed changes

pkg/lclient/fakeclient.go Show resolved Hide resolved

dharmit removed the request for review from maysunfaisal June 18, 2020 07:50

dharmit added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jun 18, 2020

dharmit removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jun 18, 2020

dharmit changed the title ~~[DO NOT MERGE] Update dependencies in glide.yaml~~ Update dependencies in glide.yaml for make to succeed in building odo binary Jun 18, 2020

Use ContainerJSON in place of Container struct

09841c4

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Jun 19, 2020

openshift-ci-robot assigned girishramnani Jun 19, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jun 19, 2020

openshift-merge-robot merged commit f736e3b into redhat-developer:master Jun 20, 2020

dharmit deleted the docker-and-glide branch June 22, 2020 05:21

rm3l added the area/refactoring Issues or PRs related to code refactoring label Jun 19, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update dependencies in glide.yaml for make to succeed in building odo binary #3369

Update dependencies in glide.yaml for make to succeed in building odo binary #3369

dharmit commented Jun 17, 2020 •

edited

Loading

mik-dass Jun 18, 2020 •

edited

Loading

dharmit Jun 18, 2020

dharmit Jun 18, 2020

dharmit commented Jun 18, 2020 •

edited

Loading

dharmit commented Jun 18, 2020

codecov bot commented Jun 18, 2020 •

edited

Loading

dharmit commented Jun 18, 2020

yangcao77 commented Jun 18, 2020

dharmit commented Jun 19, 2020

dharmit commented Jun 19, 2020

girishramnani commented Jun 19, 2020

openshift-ci-robot commented Jun 19, 2020

adisky commented Jun 19, 2020

dharmit commented Jun 19, 2020

girishramnani commented Jun 19, 2020

openshift-bot commented Jun 19, 2020

openshift-bot commented Jun 20, 2020

openshift-bot commented Jun 20, 2020

dharmit commented Jun 22, 2020

Update dependencies in glide.yaml for make to succeed in building odo binary #3369

Update dependencies in glide.yaml for make to succeed in building odo binary #3369

Conversation

dharmit commented Jun 17, 2020 • edited Loading

mik-dass Jun 18, 2020 • edited Loading

Choose a reason for hiding this comment

dharmit Jun 18, 2020

Choose a reason for hiding this comment

dharmit Jun 18, 2020

Choose a reason for hiding this comment

dharmit commented Jun 18, 2020 • edited Loading

dharmit commented Jun 18, 2020

codecov bot commented Jun 18, 2020 • edited Loading

Codecov Report

dharmit commented Jun 18, 2020

yangcao77 commented Jun 18, 2020

dharmit commented Jun 19, 2020

dharmit commented Jun 19, 2020

girishramnani commented Jun 19, 2020

openshift-ci-robot commented Jun 19, 2020

adisky commented Jun 19, 2020

dharmit commented Jun 19, 2020

girishramnani commented Jun 19, 2020

openshift-bot commented Jun 19, 2020

openshift-bot commented Jun 20, 2020

openshift-bot commented Jun 20, 2020

dharmit commented Jun 22, 2020

dharmit commented Jun 17, 2020 •

edited

Loading

mik-dass Jun 18, 2020 •

edited

Loading

dharmit commented Jun 18, 2020 •

edited

Loading

codecov bot commented Jun 18, 2020 •

edited

Loading