Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CI reference doc #4265

Merged
merged 2 commits into from
Dec 9, 2020
Merged

Update CI reference doc #4265

merged 2 commits into from
Dec 9, 2020

Conversation

amitkrout
Copy link
Contributor

@amitkrout amitkrout commented Nov 27, 2020 •
edited
Loading

What type of PR is this?
/kind cleanup
/kind documentation
[skip ci]

What does does this PR do / why we need it:
Doc - https://github.com/openshift/odo/blob/master/docs/dev/ci-reference.adoc is outdated.
Which issue(s) this PR fixes:

Fixes - Updated https://github.com/openshift/odo/blob/master/docs/dev/ci-reference.adoc

NOTE: I was referring odo ci-reference doc for the current project i am working on and found the doc was referring to template base testing and travis CI snippet was pretty old.

PR acceptance criteria:

How to test changes / Special notes to the reviewer:
https://github.com/openshift/odo/blob/master/docs/dev/ci-reference.adoc should be updated as per the recent ci structure used in odo.

mohammedzee1000
mohammedzee1000 approved these changes Nov 27, 2020
View reviewed changes
Copy link
Contributor

@mohammedzee1000 mohammedzee1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Nov 27, 2020
@prietyc123
Copy link
Contributor

/approve

@amitkrout
Copy link
Contributor Author

amitkrout commented Nov 27, 2020 •
edited
Loading 

[odo]  ✗  Waiting for component to start [5m]
[odo]  ✗  Failed to start component with name szfwrg. Error: Failed to create the component: error while waiting for
 deployment rollout: timeout while waiting for szfwrg deployment roll out

Details log - https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_odo/4265/pull-ci-openshift-odo-master-v4.5-integration-e2e/1332269239624536064#1:build-log.txt%3A1366

@prietyc123 AFAIK similar kind of or very same failure has been tracked in some issues, if not please create an issue.

@girishramnani @dharmit As this pr comprises only doc changes, then integration test job failure does not matter IMO. So you can overwrite the failure job just by applying /override v4.5-integration-e2e label

@amitkrout
Copy link
Contributor Author

/test all

@openshift-merge-robot
Copy link
Collaborator

openshift-merge-robot commented Nov 30, 2020 •
edited
Loading

@amitkrout: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/v4.5-integration-e2e c9e4b85 link /test v4.5-integration-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dharmit
Copy link
Member

dharmit commented Nov 30, 2020 

[odo]  ✗  Waiting for component to start [5m]
[odo]  ✗  Failed to start component with name szfwrg. Error: Failed to create the component: error while waiting for
 deployment rollout: timeout while waiting for szfwrg deployment roll out

Details log - https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_odo/4265/pull-ci-openshift-odo-master-v4.5-integration-e2e/1332269239624536064#1:build-log.txt%3A1366

@prietyc123 AFAIK similar kind of or very same failure has been tracked in some issues, if not please create an issue.

#3256

@dharmit
Copy link
Member

dharmit commented Nov 30, 2020

@girishramnani @dharmit As this pr comprises only doc changes, then integration test job failure does not matter IMO. So you can overwrite the failure job just by applying /override v4.5-integration-e2e label

@amitkrout is there a doc where we can refer these commands? I'm sure I'd forget that if I can't refer it somewhere. 😞

overriding integration checks since this is docs PR.

/override v4.5-integration-e2e
/override v4.6-integration-e2e

@openshift-ci-robot
Copy link
Collaborator

@dharmit: /override requires a failed status context to operate on.
The following unknown contexts were given:

  • v4.5-integration-e2e
  • v4.6-integration-e2e

Only the following contexts were expected:

  • ci/prow/unit
  • ci/prow/v4.5-integration-e2e
  • ci/prow/v4.6-integration-e2e
  • tide

In response to this:

@girishramnani @dharmit As this pr comprises only doc changes, then integration test job failure does not matter IMO. So you can overwrite the failure job just by applying /override v4.5-integration-e2e label

@amitkrout is there a doc where we can refer these commands? I'm sure I'd forget that if I can't refer it somewhere. 😞

overriding integration checks since this is docs PR.

/override v4.5-integration-e2e
/override v4.6-integration-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dharmit
Copy link
Member

dharmit commented Nov 30, 2020

/override ci/prow/v4.6-integration-e2e

@openshift-ci-robot
Copy link
Collaborator

@dharmit: Overrode contexts on behalf of dharmit: ci/prow/v4.6-integration-e2e

In response to this:

/override ci/prow/v4.6-integration-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@prietyc123
Copy link
Contributor

@girishramnani @dharmit As this pr comprises only doc changes, then integration test job failure does not matter IMO. So you can overwrite the failure job just by applying /override v4.5-integration-e2e label

@amitkrout is there a doc where we can refer these commands? I'm sure I'd forget that if I can't refer it somewhere. 😞

overriding integration checks since this is docs PR.

/override v4.5-integration-e2e
/override v4.6-integration-e2e

@dharmit Yes, we have documented it in our development guide - https://github.com/openshift/odo/blob/master/docs/dev/development.adoc#about-prow. But unfortunately the link https://deck-ci.svc.ci.openshift.org/command-help is broken.
This is correct link for prow commands - https://prow.ci.openshift.org/command-help. Please bookmark it for a quick access.
I will create a pr to consume this new working link.

@prietyc123 prietyc123 mentioned this pull request Nov 30, 2020
Merged
4 tasks
@prietyc123
Copy link
Contributor

I will create a pr to consume this new working link.

Opened a PR #4268

dharmit
dharmit approved these changes Dec 9, 2020
View reviewed changes
Copy link
Member

@dharmit dharmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amitkrout, dharmit, prietyc123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Dec 9, 2020
@openshift-merge-robot openshift-merge-robot merged commit f4682bc into redhat-developer:master Dec 9, 2020
@anandrkskd anandrkskd mentioned this pull request Dec 16, 2020
Closed
@rm3l rm3l added the area/refactoring Issues or PRs related to code refactoring label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohammedzee1000 mohammedzee1000 mohammedzee1000 approved these changes

@dharmit dharmit dharmit approved these changes

@adisky adisky Awaiting requested review from adisky

@girishramnani girishramnani Awaiting requested review from girishramnani

Assignees

@dharmit dharmit

@mohammedzee1000 mohammedzee1000

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. area/refactoring Issues or PRs related to code refactoring lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@amitkrout @prietyc123 @openshift-merge-robot @dharmit @openshift-ci-robot @mohammedzee1000 @rm3l