Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the prow help command link #4268

Conversation

prietyc123
Copy link
Contributor

What type of PR is this?

/kind documentation
[skip ci]

What does does this PR do / why we need it:

Update the correct link for prow help command

Which issue(s) this PR fixes:

Fixes - comment #4265 (comment)

PR acceptance criteria:

How to test changes / Special notes to the reviewer:

We should be able to see the help commands with the update link.

@adisky
Copy link
Contributor

adisky commented Dec 1, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Dec 1, 2020
@prietyc123
Copy link
Contributor Author

/retest

Copy link
Member

@dharmit dharmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What type of PR is this?
/kind documentation
[skip ci]

We still haven't managed to prevent CI builds for a docs PR that has skip ci mentioned in PR template as well as git commit! 😞

/approve
/override ci/prow/unit
/override ci/prow/v4.5-integration-e2e
/override ci/prow/v4.6-integration-e2e

@openshift-ci-robot
Copy link
Collaborator

@dharmit: /override requires a failed status context to operate on.
The following unknown contexts were given:

  • ci/prow/v4.5-integration-e2e

Only the following contexts were expected:

  • ci/prow/unit
  • ci/prow/v4.6-integration-e2e
  • tide

In response to this:

What type of PR is this?
/kind documentation
[skip ci]

We still haven't managed to prevent CI builds for a docs PR that has skip ci mentioned in PR template as well as git commit! 😞

/approve
/override ci/prow/unit
/override ci/prow/v4.5-integration-e2e
/override ci/prow/v4.6-integration-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dharmit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Dec 2, 2020
@openshift-merge-robot openshift-merge-robot merged commit c787d21 into redhat-developer:master Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants