Change ephemeral default to false

[kadel]

What type of PR is this:

/kind feature

Feel free to use other labels as needed. However one of the above labels must be present or the PR will not be reviewed. This instruction is for reviewers as well.
-->

What does this PR do / why we need it:

Which issue(s) this PR fixes:
fixes #5241

PR acceptance criteria:

• Unit test

• Integration test

• Documentation

How to test changes / Special notes to the reviewer:

[netlify]

✅ Deploy Preview for odo-docusaurus-preview ready!

Name	Link
🔨 Latest commit	ba15cda
🔍 Latest deploy log	https://app.netlify.com/sites/odo-docusaurus-preview/deploys/62b5b2f9c3c2af000854646a
😎 Deploy Preview	https://deploy-preview-5795--odo-docusaurus-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[odo-robot]

Unit Tests on commit f35493c finished successfully.
View logs: TXT HTML

[odo-robot]

Kubernetes Tests on commit f35493c finished successfully.
View logs: TXT HTML

[odo-robot]

Windows Tests (OCP) on commit f35493c finished successfully.
View logs: TXT HTML

[odo-robot]

Validate Tests on commit f35493c finished successfully.
View logs: TXT HTML

[odo-robot]

OpenShift Tests on commit f35493c finished successfully.
View logs: TXT HTML

[feloy]

All the integration tests are now running with non-ephemeral volumes for component's project directory.

IMO, this has some effect on the limits of resources on the cluster, and could slow down the tests (with 32 tests running in parallel, we can easily find Pod in Pending state for lack of memory)

Perhaps do we want to switch the preference to ephemeral during the tests?

[feloy]

All the integration tests are now running with non-ephemeral volumes for component's project directory.

IMO, this has some effect on the limits of resources on the cluster, and could slow down the tests (with 32 tests running in parallel, we can easily find Pod in Pending state for lack of memory)

Perhaps do we want to switch the preference to ephemeral during the tests?

@kadel, what's your opinion?

[kadel]

All the integration tests are now running with non-ephemeral volumes for component's project directory.

IMO, this has some effect on the limits of resources on the cluster, and could slow down the tests (with 32 tests running in parallel, we can easily find Pod in Pending state for lack of memory)

Perhaps do we want to switch the preference to ephemeral during the tests?

This is a good point.
I'll change our tests to use ephemeral by default.
There already is at least one test that verifies that ephemeral=false works correctly (https://github.com/redhat-developer/odo/blob/main/tests/integration/devfile/cmd_dev_test.go#L269)

[feloy]

There already is at least one test that verifies that ephemeral=false works correctly (https://github.com/redhat-developer/odo/blob/main/tests/integration/devfile/cmd_dev_test.go#L269)

You will need to update this test to now force the odo set preference command, or it will refuse because the value is now already set:

[odo] ? ephemeral is already set. Do you want to override it in the config (y/N)
I0616 07:53:42.259922   22593 common.go:17] Encountered an error processing prompt: EOF
[odo] Aborted by the user

[feloy]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feloy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [feloy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[feloy]

/lgtm

[feloy]

/override ci/prow/unit
/override ci/prow/v4.10-integration-e2e

Tests pass on IBM Cloud

[openshift-ci]

@feloy: Overrode contexts on behalf of feloy: ci/prow/unit, ci/prow/v4.10-integration-e2e

In response to this:

/override ci/prow/unit
/override ci/prow/v4.10-integration-e2e

Tests pass on IBM Cloud

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[feloy]

/override ci/prow/v4.10-integration-e2e

[openshift-ci]

@feloy: Overrode contexts on behalf of feloy: ci/prow/v4.10-integration-e2e

In response to this:

/override ci/prow/v4.10-integration-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.