Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to ginkgo v2 #5809

Merged
merged 10 commits into from
Jul 6, 2022
Merged

Migrate to ginkgo v2 #5809

merged 10 commits into from
Jul 6, 2022

Conversation

anandrkskd
Copy link
Contributor

What type of PR is this:

/kind tests

What does this PR do / why we need it:

Which issue(s) this PR fixes:
Fixes #5791

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jun 9, 2022
@netlify
Copy link

netlify bot commented Jun 9, 2022 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview ready!

Name Link
🔨 Latest commit 2f96d0a
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/62befdc4e5b3330009495d9b
😎 Deploy Preview https://deploy-preview-5809--odo-docusaurus-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@openshift-ci openshift-ci bot added kind/tests needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. labels Jun 9, 2022
@openshift-ci openshift-ci bot requested review from feloy and rm3l June 9, 2022 10:52
@anandrkskd anandrkskd force-pushed the migrate-to-ginkgoV2-try1 branch from d7df6ab to 2d7ca85 Compare June 9, 2022 10:52
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label Jun 9, 2022
@anandrkskd anandrkskd force-pushed the migrate-to-ginkgoV2-try1 branch from 2d7ca85 to e2d86d4 Compare June 9, 2022 10:55
@odo-robot
Copy link

odo-robot bot commented Jun 9, 2022 •
edited
Loading

Windows Tests (OCP) on commit f2d2bba finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 9, 2022 •
edited
Loading

Unit Tests on commit f2d2bba finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 9, 2022 •
edited
Loading

Validate Tests on commit f2d2bba finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 9, 2022 •
edited
Loading

OpenShift Tests on commit f2d2bba finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 9, 2022 •
edited
Loading

Kubernetes Tests on commit f2d2bba finished successfully.
View logs: TXT HTML

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label Jun 13, 2022
@anandrkskd anandrkskd force-pushed the migrate-to-ginkgoV2-try1 branch from e2d86d4 to 7cf8650 Compare June 16, 2022 10:14
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label Jun 16, 2022
@anandrkskd
Copy link
Contributor Author

/retest

@anandrkskd anandrkskd force-pushed the migrate-to-ginkgoV2-try1 branch 2 times, most recently from a0fc119 to 82075ff Compare June 20, 2022 09:26
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label Jun 21, 2022
@anandrkskd anandrkskd force-pushed the migrate-to-ginkgoV2-try1 branch from 4dc83fe to 244649e Compare June 23, 2022 07:41
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label Jun 23, 2022
@anandrkskd anandrkskd force-pushed the migrate-to-ginkgoV2-try1 branch from 5461d84 to 8a478af Compare June 23, 2022 07:59
@anandrkskd anandrkskd changed the title [WIP] Migrate to ginkgo v2 Migrate to ginkgo v2 Jun 23, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jun 23, 2022
@anandrkskd
Copy link
Contributor Author

/test v4.10-integration-e2e

1 similar comment
@anandrkskd
Copy link
Contributor Author

/test v4.10-integration-e2e

feloy
feloy suggested changes Jun 24, 2022
View reviewed changes
tests/integration/cmd_namespace_test.go Outdated Show resolved Hide resolved
tests/e2escenarios/e2e_devfile_test.go Outdated Show resolved Hide resolved
feloy
feloy reviewed Jun 29, 2022
View reviewed changes
scripts/generate-mod.sh Outdated Show resolved Hide resolved
@rm3l rm3l mentioned this pull request Jun 29, 2022
Merged
3 tasks
@anandrkskd anandrkskd closed this Jun 29, 2022
@anandrkskd anandrkskd reopened this Jun 29, 2022
@anandrkskd anandrkskd closed this Jun 30, 2022
@anandrkskd anandrkskd reopened this Jun 30, 2022
@feloy
Copy link
Contributor

feloy commented Jul 1, 2022

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jul 1, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feloy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Jul 1, 2022
rm3l
rm3l reviewed Jul 1, 2022
View reviewed changes
.ibm/pipelines/kubernetes-tests.sh Outdated Show resolved Hide resolved
.ibm/pipelines/openshift-tests.sh Outdated Show resolved Hide resolved
scripts/generate-mod.sh Show resolved Hide resolved
scripts/openshiftci-presubmit-all-tests.sh Outdated Show resolved Hide resolved
scripts/generate-mod.sh
@@ -0,0 +1,30 @@
#!/bin/sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@feloy Unless I've missed something about the usage of this script, I'm wondering if it wouldn't make sense to run this as part of CI, to detect cases where the go.mod file would be edited directly without updating this script (e.g, Dependabot PRs or someone updating/adding a new dependency). This way, we would be aware of editing this file if there is a diff.
But I guess it might not be straightforward especially where this script might potentially update dependencies with go get -u..

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that I would make sense. I remember we discussd to put in place a script to check these kind of generated code (mocks at least); that would be part of this work

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, I also remember a discussion around such checks. I'll try to find a related issue (or create a new one) to track this.

@anandrkskd
remove unnecessary goget-ginkgo from sctipt
2f96d0a 
Signed-off-by: anandrkskd <anandrkskd@gmail.com>
@anandrkskd anandrkskd force-pushed the migrate-to-ginkgoV2-try1 branch from 0001050 to 2f96d0a Compare July 1, 2022 13:59
dharmit
dharmit reviewed Jul 1, 2022
View reviewed changes
scripts/generate-mod.sh Show resolved Hide resolved
scripts/generate-mod.sh Show resolved Hide resolved
scripts/generate-mod.sh Show resolved Hide resolved
@rm3l rm3l mentioned this pull request Jul 1, 2022
Merged
@anandrkskd anandrkskd closed this Jul 4, 2022
@anandrkskd anandrkskd reopened this Jul 4, 2022
@anandrkskd anandrkskd closed this Jul 5, 2022
@anandrkskd anandrkskd reopened this Jul 5, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jul 5, 2022
@anandrkskd anandrkskd closed this Jul 5, 2022
@anandrkskd anandrkskd reopened this Jul 5, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jul 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.3% 0.3% Duplication

@feloy
Copy link
Contributor

feloy commented Jul 6, 2022

/override ci/prow/unit
/override ci/prow/v4.10-integration-e2e

@openshift-ci
Copy link

openshift-ci bot commented Jul 6, 2022

@feloy: Overrode contexts on behalf of feloy: ci/prow/unit, ci/prow/v4.10-integration-e2e

In response to this:

/override ci/prow/unit
/override ci/prow/v4.10-integration-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot merged commit 7220206 into redhat-developer:main Jul 6, 2022
@anandrkskd anandrkskd mentioned this pull request Jul 20, 2022
Closed
cdrage pushed a commit to cdrage/odo that referenced this pull request Aug 31, 2022
@anandrkskd @cdrage
Migrate to ginkgo v2 (redhat-developer#5809)
0bfbee5 
* migrate to ginkgo v2 for tests

Signed-off-by: anandrkskd <anandrkskd@gmail.com>

* update to ginkgo/v2

Signed-off-by: anandrkskd <anandrkskd@gmail.com>

* update to ginkgo v2

Signed-off-by: anandrkskd <anandrkskd@gmail.com>

* use ginkgo binary for tests

Signed-off-by: anandrkskd <anandrkskd@gmail.com>

* update to ginkgo v2

Signed-off-by: anandrkskd <anandrkskd@gmail.com>

* remove GOFLAG while downloading ginkgo

Signed-off-by: anandrkskd <anandrkskd@gmail.com>

* remove FlakeAttempts from tests

Signed-off-by: anandrkskd <anandrkskd@gmail.com>

* use ginkgo v2.1.4

Signed-off-by: anandrkskd <anandrkskd@gmail.com>

* mod cleanup and use mod to run ginkgo

Signed-off-by: anandrkskd <anandrkskd@gmail.com>

* remove unnecessary goget-ginkgo from sctipt

Signed-off-by: anandrkskd <anandrkskd@gmail.com>
@anandrkskd anandrkskd deleted the migrate-to-ginkgoV2-try1 branch October 13, 2022 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feloy feloy feloy requested changes

@dharmit dharmit dharmit left review comments

@rm3l rm3l rm3l approved these changes

Assignees

@rm3l rm3l

@feloy feloy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade ginkgo to version 2.0
4 participants
@anandrkskd @feloy @rm3l @dharmit