Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Dependabot #5827

Merged
merged 4 commits into from
Jun 29, 2022
Merged

Enable Dependabot #5827

merged 4 commits into from
Jun 29, 2022

Conversation

rm3l
Copy link
Member

@rm3l rm3l commented Jun 14, 2022

What type of PR is this:
/area dependency

What does this PR do / why we need it:
As quickly discussed during the last Cabal meeting, this PR configures Dependabot in our repo. Dependabot will automatically create PRs with dependency updates for the package managers we configured. As such, I added a minimal configuration file that maintains both our Go and NPM dependencies.

The goal is to see if Dependabot could be relevant in helping us keep our dependencies up-to-date.

Once this is merged, we will see what kind of PRs Dependabot raises. We can revert this later or disable Dependabot if the PRs it creates do not make sense.

I think GitHub Dependabot is free for public repos.

Which issue(s) this PR fixes:
-

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:
Didn't try it, but it might be possible to test Dependabot locally, per this blog post. But the goal here is to have this merged and take a look at Dependabot PRs.

@rm3l rm3l requested review from kadel and feloy June 14, 2022 16:05
@netlify
Copy link

netlify bot commented Jun 14, 2022

Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 7d7594f
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/62a8b1d144990d00084b01f9

@openshift-ci openshift-ci bot added the area/dependency Issues or PRs related to dependency changes. This label is also used on all Dependabot PRs label Jun 14, 2022
@openshift-ci openshift-ci bot requested review from dharmit and valaparthvi June 14, 2022 16:05
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@odo-robot
Copy link

odo-robot bot commented Jun 14, 2022

Unit Tests on commit fe8db85 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 14, 2022

Windows Tests (OCP) on commit fe8db85 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 14, 2022

Kubernetes Tests on commit fe8db85 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 14, 2022

OpenShift Tests on commit fe8db85 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jun 14, 2022

Validate Tests on commit fe8db85 finished successfully.
View logs: TXT HTML

@rm3l
Copy link
Member Author

rm3l commented Jun 15, 2022

/hold

Will come back to this at a later time (at the end of the current Sprint, to not disturb it).

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Jun 15, 2022
@feloy
Copy link
Contributor

feloy commented Jun 15, 2022

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jun 15, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feloy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Jun 15, 2022
@valaparthvi
Copy link
Contributor

/lgtm

@rm3l I think now might be a good time to merge this PR and put it to test. If you agree, please cancel the hold.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jun 29, 2022
@valaparthvi
Copy link
Contributor

/override ci/prow/unit
/override ci/prow/v4.10-integration-e2e

@openshift-ci
Copy link

openshift-ci bot commented Jun 29, 2022

@valaparthvi: Overrode contexts on behalf of valaparthvi: ci/prow/unit, ci/prow/v4.10-integration-e2e

In response to this:

/override ci/prow/unit
/override ci/prow/v4.10-integration-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rm3l
Copy link
Member Author

rm3l commented Jun 29, 2022

/lgtm

@rm3l I think now might be a good time to merge this PR and put it to test. If you agree, please cancel the hold.

Thanks for the reminder. Yup, I think we can merge this now too.

/override ci/prow/unit
/override ci/prow/v4.10-integration-e2e

@feloy I guess the PRs that Dependabot will create will likely "conflict" with what you did with the go.mod generation script, because those PRs would be modifying the go.mod and go.sum files directly.. If I am not wrong, this script has been integrated into the "Ginkgo V2 migration" PR (#5809)..
But this might actually not be an issue, as we can always annotate/comment Dependabot PRs with additional things to do before merging if needed.

@openshift-ci
Copy link

openshift-ci bot commented Jun 29, 2022

@rm3l: Overrode contexts on behalf of rm3l: ci/prow/unit, ci/prow/v4.10-integration-e2e

In response to this:

/lgtm

@rm3l I think now might be a good time to merge this PR and put it to test. If you agree, please cancel the hold.

Thanks for the reminder. Yup, I think we can merge this now too.

/override ci/prow/unit
/override ci/prow/v4.10-integration-e2e

@feloy I guess the PRs that Dependabot will create will likely "conflict" with what you did with the go.mod generation script, because those PRs would be modifying the go.mod and go.sum files directly.. If I am not wrong, this script has been integrated into the "Ginkgo V2 migration" PR (#5809)..
But this might actually not be an issue, as we can always annotate/comment Dependabot PRs with additional things to do before merging if needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rm3l
Copy link
Member Author

rm3l commented Jun 29, 2022

/hold cancel

Let's see what we have. If it makes sense, we can see in the future how to update (annotate/label/comment/push) Dependabot PRs accordingly.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Jun 29, 2022
@rm3l
Copy link
Member Author

rm3l commented Jun 29, 2022

/override ci/prow/unit
/override ci/prow/v4.10-integration-e2e

@openshift-ci
Copy link

openshift-ci bot commented Jun 29, 2022

@rm3l: Overrode contexts on behalf of rm3l: ci/prow/unit, ci/prow/v4.10-integration-e2e

In response to this:

/override ci/prow/unit
/override ci/prow/v4.10-integration-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot merged commit 1605196 into redhat-developer:main Jun 29, 2022
cdrage pushed a commit to cdrage/odo that referenced this pull request Aug 31, 2022
* Configure Dependabot for watching and maintaining our Go dependencies

* Configure Dependabot for watching and maintaining our NPM dependencies (website)

* Add more comments

* Add "ok-to-test" label to Dependabot PRs
@rm3l rm3l deleted the dependabot branch December 1, 2022 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. area/dependency Issues or PRs related to dependency changes. This label is also used on all Dependabot PRs lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants