Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds tabs for podman/docker docs and OS differences #6115

Merged

Conversation

cdrage
Copy link
Member

@cdrage cdrage commented Sep 12, 2022

Adds tabs for mac / windows / linux environments in docs

What type of PR is this:

/kind documentation

What does this PR do / why we need it:

  • Updates the documentation with regards to different operating systems
    when deploying an image

Which issue(s) this PR fixes:

Fixes #6085

@netlify
Copy link

netlify bot commented Sep 12, 2022

Deploy Preview for odo-docusaurus-preview ready!

Name Link
🔨 Latest commit f6d59ee
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/63207c32297daa0008d2a615
😎 Deploy Preview https://deploy-preview-6115--odo-docusaurus-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@odo-robot
Copy link

odo-robot bot commented Sep 12, 2022

Unit Tests on commit feba146 finished successfully.
View logs: TXT HTML

@cdrage cdrage changed the title Reorganize and separate language / framework tutorials. Adds tabs for podman/docker docs and OS differences Sep 12, 2022
<!--
Thank you for opening a PR! Here are some things you need to know before submitting:

1. Please read our developer guideline: https://github.com/redhat-developer/odo/wiki/Dev:-odo-Dev-Guidelines
2. Label this PR accordingly with the '/kind' line
3. Ensure you have written and ran the appropriate tests: https://github.com/redhat-developer/odo/wiki/Dev:-Writing-and-running-tests
4. Read how we approve and LGTM each PR: https://github.com/redhat-developer/odo/wiki/Pull-Requests:-Review-guideline

Documentation:

If you are pushing a change to documentation, please read: https://github.com/redhat-developer/odo/wiki/Documentation:-Contributing
-->

**What type of PR is this:**

<!--
Add one of the following kinds:
/kind bug
/kind feature
/kind cleanup
/kind tests

Feel free to use other [labels](https://github.com/redhat-developer/odo/labels) as needed. However one of the above labels must be present or the PR will not be reviewed. This instruction is for reviewers as well.
-->

/kind documentation

**What does this PR do / why we need it:**
* Updates the documentation with regards to different operating systems
  when deploying an image

**Which issue(s) this PR fixes:**
<!--
Specifying the issue will automatically close it when this PR is merged
-->

Fixes redhat-developer#6085
@odo-robot
Copy link

odo-robot bot commented Sep 12, 2022

Validate Tests on commit feba146 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 12, 2022

OpenShift Tests on commit feba146 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 12, 2022

Kubernetes Tests on commit feba146 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 12, 2022

Windows Tests (OCP) on commit feba146 finished successfully.
View logs: TXT HTML

Co-authored-by: Armel Soro <armel@rm3l.org>
@sonarcloud
Copy link

sonarcloud bot commented Sep 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.5% 0.5% Duplication

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Sep 13, 2022
@rm3l
Copy link
Member

rm3l commented Sep 13, 2022

/approve

@openshift-ci
Copy link

openshift-ci bot commented Sep 13, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rm3l

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Sep 13, 2022
@openshift-merge-robot openshift-merge-robot merged commit 8a99a86 into redhat-developer:main Sep 13, 2022
valaparthvi pushed a commit to valaparthvi/odo that referenced this pull request Sep 15, 2022
…#6115)

* Adds tabs for mac / windows / linux environments in docs

<!--
Thank you for opening a PR! Here are some things you need to know before submitting:

1. Please read our developer guideline: https://github.com/redhat-developer/odo/wiki/Dev:-odo-Dev-Guidelines
2. Label this PR accordingly with the '/kind' line
3. Ensure you have written and ran the appropriate tests: https://github.com/redhat-developer/odo/wiki/Dev:-Writing-and-running-tests
4. Read how we approve and LGTM each PR: https://github.com/redhat-developer/odo/wiki/Pull-Requests:-Review-guideline

Documentation:

If you are pushing a change to documentation, please read: https://github.com/redhat-developer/odo/wiki/Documentation:-Contributing
-->

**What type of PR is this:**

<!--
Add one of the following kinds:
/kind bug
/kind feature
/kind cleanup
/kind tests

Feel free to use other [labels](https://github.com/redhat-developer/odo/labels) as needed. However one of the above labels must be present or the PR will not be reviewed. This instruction is for reviewers as well.
-->

/kind documentation

**What does this PR do / why we need it:**
* Updates the documentation with regards to different operating systems
  when deploying an image

**Which issue(s) this PR fixes:**
<!--
Specifying the issue will automatically close it when this PR is merged
-->

Fixes redhat-developer#6085

* Update docs/website/docs/user-guides/deploy/_prerequisites.mdx

Co-authored-by: Armel Soro <armel@rm3l.org>

Co-authored-by: Armel Soro <armel@rm3l.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tabs for Mac / Windows / Linux environments & warn users on differences.
3 participants