Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add exit code check for no-cluster tests #6345

Merged
merged 1 commit into from
Nov 24, 2022

Conversation

anandrkskd
Copy link
Contributor

Signed-off-by: anandrkskd anandrkskd@gmail.com

What type of PR is this:
/kind bug
/kind tests

What does this PR do / why we need it:
This PR adds the check for exit code in windows tests for no-cluster tests

Which issue(s) this PR fixes:

Fixes #6342

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

Signed-off-by: anandrkskd <anandrkskd@gmail.com>
@netlify
Copy link

netlify bot commented Nov 24, 2022

Deploy Preview for odo-docusaurus-preview ready!

Name Link
🔨 Latest commit 23cb3a0
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/637f1b4eccf1f50008edd1b7
😎 Deploy Preview https://deploy-preview-6345--odo-docusaurus-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@openshift-ci openshift-ci bot added kind/bug Categorizes issue or PR as related to a bug. kind/tests labels Nov 24, 2022
@openshift-ci openshift-ci bot requested review from feloy and rm3l November 24, 2022 07:21
@odo-robot
Copy link

odo-robot bot commented Nov 24, 2022

Windows Tests (OCP) on commit 509bfdd finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 24, 2022

NoCluster Tests on commit 509bfdd finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 24, 2022

Unit Tests on commit 509bfdd finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 24, 2022

Validate Tests on commit 509bfdd finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 24, 2022

Kubernetes Tests on commit 509bfdd finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 24, 2022

OpenShift Tests on commit 509bfdd finished with errors.
View logs: TXT HTML

@feloy
Copy link
Contributor

feloy commented Nov 24, 2022

@anandrkskd Thanks for the fix
/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Nov 24, 2022
@openshift-ci
Copy link

openshift-ci bot commented Nov 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feloy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Nov 24, 2022
@anandrkskd anandrkskd closed this Nov 24, 2022
@anandrkskd anandrkskd reopened this Nov 24, 2022
@sonarcloud
Copy link

sonarcloud bot commented Nov 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@feloy
Copy link
Contributor

feloy commented Nov 24, 2022

/override windows-integration-test/Windows-test

[FAILED] [1.706 seconds]
odo init interactive command tests [nocluster]
C:/Users/Administrator.ANSIBLE-TEST-VS/2605/tests/integration/interactive_init_test.go:21
  [It] should print automation command with proper values
  C:/Users/Administrator.ANSIBLE-TEST-VS/2605/tests/integration/interactive_init_test.go:96

/override OpenShift-Integration-tests/OpenShift-Integration-tests
Flaky test

odo logs command tests
/go/odo_1/tests/integration/cmd_logs_test.go:14
  when component is created and odo logs is executed
  /go/odo_1/tests/integration/cmd_logs_test.go:69
    when running in both Dev and Deploy mode [BeforeEach]
    /go/odo_1/tests/integration/cmd_logs_test.go:177
      should successfully show logs of the running component
      /go/odo_1/tests/integration/cmd_logs_test.go:189

/override ci/prow/v4.11-integration-e2e
Not related

@openshift-ci
Copy link

openshift-ci bot commented Nov 24, 2022

@feloy: Overrode contexts on behalf of feloy: OpenShift-Integration-tests/OpenShift-Integration-tests, ci/prow/v4.11-integration-e2e, windows-integration-test/Windows-test

In response to this:

/override windows-integration-test/Windows-test

[FAILED] [1.706 seconds]
odo init interactive command tests [nocluster]
C:/Users/Administrator.ANSIBLE-TEST-VS/2605/tests/integration/interactive_init_test.go:21
 [It] should print automation command with proper values
 C:/Users/Administrator.ANSIBLE-TEST-VS/2605/tests/integration/interactive_init_test.go:96

/override OpenShift-Integration-tests/OpenShift-Integration-tests
Flaky test

odo logs command tests
/go/odo_1/tests/integration/cmd_logs_test.go:14
 when component is created and odo logs is executed
 /go/odo_1/tests/integration/cmd_logs_test.go:69
   when running in both Dev and Deploy mode [BeforeEach]
   /go/odo_1/tests/integration/cmd_logs_test.go:177
     should successfully show logs of the running component
     /go/odo_1/tests/integration/cmd_logs_test.go:189

/override ci/prow/v4.11-integration-e2e
Not related

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit ab273dc into redhat-developer:main Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wins tests fail only if e2e tests fail
3 participants