Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest Alizer #6378

Merged
merged 4 commits into from
Dec 5, 2022

Conversation

kadel
Copy link
Member

@kadel kadel commented Dec 5, 2022

What does this PR do / why we need it:
Updates Alizer to the current main branch.

There has been a fix to .NET detection (redhat-developer/alizer#112). Without this odo/alizer won't correctly assign Devfiles from the registry to .NET projects.

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@netlify
Copy link

netlify bot commented Dec 5, 2022

Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 5802930
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/638e179d3f52f8000816e89d

@odo-robot
Copy link

odo-robot bot commented Dec 5, 2022

NoCluster Tests on commit 64ac354 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Dec 5, 2022

Validate Tests on commit 64ac354 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Dec 5, 2022

Unit Tests on commit 64ac354 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Dec 5, 2022

Kubernetes Tests on commit 64ac354 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Dec 5, 2022

Windows Tests (OCP) on commit 64ac354 finished successfully.
View logs: TXT HTML

@sonarcloud
Copy link

sonarcloud bot commented Dec 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@odo-robot
Copy link

odo-robot bot commented Dec 5, 2022

OpenShift Tests on commit 64ac354 finished successfully.
View logs: TXT HTML

Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In #6365 (port detection feature), I had to update Alizer as well (to their latest commit when I checked last week but I haven't checked recently for new changes).
I think we can merge your PR, and I will remove the commit containing the Alizer update from #6365

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Dec 5, 2022
@rm3l rm3l added this to the v3.4.0 🚀 milestone Dec 5, 2022
@rm3l
Copy link
Member

rm3l commented Dec 5, 2022

/override ci/prow/v4.11-integration-e2e

Infra errors, and all tests are passing on IBM Cloud.

@openshift-ci
Copy link

openshift-ci bot commented Dec 5, 2022

@rm3l: Overrode contexts on behalf of rm3l: ci/prow/v4.11-integration-e2e

In response to this:

/override ci/prow/v4.11-integration-e2e

Infra errors, and all tests are passing on IBM Cloud.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 6883fb9 into redhat-developer:main Dec 5, 2022
@kadel kadel deleted the update-alizer branch March 9, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants