Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change wording for dev/deploy #6408

Merged
merged 4 commits into from
Jan 9, 2023
Merged

Change wording for dev/deploy #6408

merged 4 commits into from
Jan 9, 2023

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Dec 14, 2022

What type of PR is this:

/kind bug

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #6387

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Dec 14, 2022
@openshift-ci openshift-ci bot requested review from anandrkskd and rm3l December 14, 2022 08:32
@netlify
Copy link

netlify bot commented Dec 14, 2022 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 4f0efc6
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/63bc4432c61dcd0009098b29

@odo-robot
Copy link

odo-robot bot commented Dec 14, 2022 •
edited
Loading

OpenShift Tests on commit d4331ee finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Dec 14, 2022 •
edited
Loading

NoCluster Tests on commit d4331ee finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Dec 14, 2022 •
edited
Loading

Unit Tests on commit d4331ee finished successfully.
View logs: TXT HTML

@feloy feloy changed the title Change wording for dev/deploy [WIP] Change wording for dev/deploy Dec 14, 2022
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Dec 14, 2022
@odo-robot
Copy link

odo-robot bot commented Dec 14, 2022 •
edited
Loading

Validate Tests on commit d4331ee finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Dec 14, 2022 •
edited
Loading

Kubernetes Tests on commit d4331ee finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Dec 14, 2022 •
edited
Loading

Windows Tests (OCP) on commit d4331ee finished successfully.
View logs: TXT HTML

@feloy
Copy link
Contributor Author

feloy commented Dec 14, 2022 

[FAILED] [257.808 seconds]
odo dev command tests
/go/odo_1/tests/integration/cmd_dev_test.go:31
  port-forwarding for the component
  /go/odo_1/tests/integration/cmd_dev_test.go:595
    when devfile has single endpoint
    /go/odo_1/tests/integration/cmd_dev_test.go:596
      when running odo dev
      /go/odo_1/tests/integration/cmd_dev_test.go:605
        when modifying memoryLimit for container in Devfile [BeforeEach]
        /go/odo_1/tests/integration/cmd_dev_test.go:639
          should expose the endpoint on localhost
          /go/odo_1/tests/integration/cmd_dev_test.go:655

@feloy feloy closed this Dec 14, 2022
@feloy feloy reopened this Dec 14, 2022
@feloy
Copy link
Contributor Author

feloy commented Dec 15, 2022

These changes will modify lots of commands outputs displayed in doc.
Blocked by #6192

@feloy feloy added the status/blocked Denotes an issue or PR that is blocked on something (e.g., issue/PR in different repo) label Dec 15, 2022
@feloy feloy force-pushed the doc-6387/reword-deploy branch from 4d9d365 to 6065c46 Compare January 6, 2023 08:12
@feloy feloy force-pushed the doc-6387/reword-deploy branch from 6065c46 to 3f2eeb5 Compare January 9, 2023 12:57
@feloy feloy removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. status/blocked Denotes an issue or PR that is blocked on something (e.g., issue/PR in different repo) labels Jan 9, 2023
@feloy feloy changed the title [WIP] Change wording for dev/deploy hange wording for dev/deploy Jan 9, 2023
@feloy feloy changed the title hange wording for dev/deploy Change wording for dev/deploy Jan 9, 2023
rm3l
rm3l requested changes Jan 9, 2023
View reviewed changes
cmd/odo/help_test.go Outdated
@@ -29,8 +29,8 @@ Examples:

mainCommands = `Main Commands:
build-images Build images
deploy Deploy components
dev Deploy component to development cluster
deploy Run components in Deploy mode
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be consistent with the help message for dev:

Suggested change
deploy Run components in Deploy mode
deploy Run your application on the cluster in the Deploy mode

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jan 9, 2023
@feloy
Copy link
Contributor Author

feloy commented Jan 9, 2023

/override OpenShift-Integration-tests/OpenShift-Integration-tests
Flaky e2e test

@openshift-ci
Copy link

openshift-ci bot commented Jan 9, 2023

@feloy: Overrode contexts on behalf of feloy: OpenShift-Integration-tests/OpenShift-Integration-tests

In response to this:

/override OpenShift-Integration-tests/OpenShift-Integration-tests
Flaky e2e test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feloy
Copy link
Contributor Author

feloy commented Jan 9, 2023

/override ci/prow/v4.11-integration-e2e

@openshift-ci
Copy link

openshift-ci bot commented Jan 9, 2023

@feloy: Overrode contexts on behalf of feloy: ci/prow/v4.11-integration-e2e

In response to this:

/override ci/prow/v4.11-integration-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 06b95fc into redhat-developer:main Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rm3l rm3l rm3l approved these changes

@anandrkskd anandrkskd Awaiting requested review from anandrkskd

Assignees

@rm3l rm3l

Labels
kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

reword help and documentation messages to not use "deploy" in context with odo dev
3 participants
@feloy @rm3l @openshift-merge-robot