Implement odo delete component --running-in
#6485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for odo-docusaurus-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
openshift-ci
bot
added
the
kind/feature
rm3l
requested review from
feloy and
valaparthvi
and removed request for
kadel and
anandrkskd
valaparthvi
suggested changes
Jan 13, 2023
valaparthvi
reviewed
Jan 13, 2023
valaparthvi
reviewed
Jan 13, 2023
rm3l
force-pushed
the
6409-odo-delete-component-running-in
branch
from
a558005 to
4045ad0
Compare
|
/hold
|
openshift-ci
bot
added
the
do-not-merge/hold
|
Blocked by #6499, which should allow running Podman tests in isolated namespaces. |
openshift-merge-robot
added
the
needs-rebase
3 tasks
rm3l
force-pushed
the
6409-odo-delete-component-running-in
branch
from
4045ad0 to
26a11de
Compare
openshift-merge-robot
removed
the
needs-rebase
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
feloy
approved these changes
Jan 23, 2023
openshift-ci
bot
added
the
lgtm
…ion on both cluster and Podman
…ntion the provided value for 'running-in'
rm3l
force-pushed
the
6409-odo-delete-component-running-in
branch
from
26a11de to
b94c566
Compare
openshift-ci
bot
removed
the
lgtm
|
Kudos, SonarCloud Quality Gate passed!
|
|
Rebased and force-pushed to fix Git conflicts. |
feloy
approved these changes
Jan 23, 2023
openshift-ci
bot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this:
/kind feature
What does this PR do / why we need it:
See #6409 for the rationale.
Which issue(s) this PR fixes:
Fixes #6409
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer:
running-inis not specified,odo delete componentdeletes resources running in bothdevanddeploy. If the experimental mode is on, it also tries to delete resources deployed on Podman.odo delete component --running-in <dev|deploy>.--nameflag, and on Podman as well.