Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make bump-version.sh also update the version in documentation sample outputs #6608

Conversation

rm3l
Copy link
Member

@rm3l rm3l commented Feb 20, 2023

What type of PR is this:

What does this PR do / why we need it:
bump-version.sh is used whenever we are ready to tag a new version. But now that documentation tests are integrated into the CI jobs (#6521), checks for the new version would not pass straight away, and we would need to manually figure out which files would need to be updated.
This happened in the PR for v3.7.0: #6596 (comment)

So this PR is about ensuring the odo version is also updated accordingly in the documentation sample outputs potentially referenced by the Docs tests.

Which issue(s) this PR fixes:
Related to #6192

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:
Run the script and make sure it updated the relevant *.mdx files under docs/website/docs/**/docs-mdx/**/.

@netlify
Copy link

netlify bot commented Feb 20, 2023

Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 8f1a736
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/63f37a47ad973900086a763c

@rm3l rm3l added this to the v3.8.0 🚀 milestone Feb 20, 2023
@odo-robot
Copy link

odo-robot bot commented Feb 20, 2023

OpenShift Unauthenticated Tests on commit b352491 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 20, 2023

NoCluster Tests on commit b352491 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 20, 2023

Unit Tests on commit b352491 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 20, 2023

Validate Tests on commit b352491 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 20, 2023

Kubernetes Tests on commit b352491 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 20, 2023

Windows Tests (OCP) on commit b352491 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 20, 2023

OpenShift Tests on commit b352491 finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 20, 2023

Kubernetes Docs Tests on commit e32024f finished successfully.
View logs: TXT HTML

@rm3l rm3l closed this Feb 20, 2023
@rm3l rm3l reopened this Feb 20, 2023
@sonarcloud
Copy link

sonarcloud bot commented Feb 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Feb 21, 2023
@rm3l
Copy link
Member Author

rm3l commented Feb 21, 2023


  Expected
      <*url.Error | 0xc0005f22a0>: {
          Op: "Post",
          URL: "http://127.0.0.1:36991/api/newuser",
          Err: <*errors.errorString | 0xc0001120f0>{s: "EOF"},
      }
  to be nil
  In [It] at: /go/odo_1/tests/e2escenarios/e2e_test.go:306

Summarizing 1 Failure:
  [FAIL] E2E Test starting with non-empty Directory add Binding [It] should verify developer workflow of using binding as env in innerloop
  /go/odo_1/tests/e2escenarios/e2e_test.go:306

Ran 7 of 7 Specs in 150.795 seconds
FAIL! -- 6 Passed | 1 Failed | 0 Pending | 0 Skipped

Flaky E2E test - will be addressed in #6582

/override OpenShift-Integration-tests/OpenShift-Integration-tests

@openshift-ci
Copy link

openshift-ci bot commented Feb 21, 2023

@rm3l: Overrode contexts on behalf of rm3l: OpenShift-Integration-tests/OpenShift-Integration-tests

In response to this:


 Expected
     <*url.Error | 0xc0005f22a0>: {
         Op: "Post",
         URL: "http://127.0.0.1:36991/api/newuser",
         Err: <*errors.errorString | 0xc0001120f0>{s: "EOF"},
     }
 to be nil
 In [It] at: /go/odo_1/tests/e2escenarios/e2e_test.go:306

Summarizing 1 Failure:
 [FAIL] E2E Test starting with non-empty Directory add Binding [It] should verify developer workflow of using binding as env in innerloop
 /go/odo_1/tests/e2escenarios/e2e_test.go:306

Ran 7 of 7 Specs in 150.795 seconds
FAIL! -- 6 Passed | 1 Failed | 0 Pending | 0 Skipped

Flaky E2E test - will be addressed in #6582

/override OpenShift-Integration-tests/OpenShift-Integration-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 34c2728 into redhat-developer:main Feb 21, 2023
anandrkskd pushed a commit to anandrkskd/odo that referenced this pull request Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants