Use custom address for port forwarding #6766

valaparthvi · 2023-04-24T06:58:37Z

What type of PR is this:
/kind feature

What does this PR do / why we need it:
With this PR, users can now provide custom address for port forwarding.
Which issue(s) this PR fixes:

Fixes #6479
Fixes part of #6744 (works as a workaround, need to document this behavior)

PR acceptance criteria:

Unit test
Integration test
Documentation

How to test changes / Special notes to the reviewer:
0. odo init --devfile go --starter go-starter --name custom-address-go-app

odo dev --address 192.168.0.2

netlify · 2023-04-24T06:58:42Z

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name	Link
🔨 Latest commit	`8c510d9`
🔍 Latest deploy log	https://app.netlify.com/sites/odo-docusaurus-preview/deploys/6450e4f13627d20008dc84f9

odo-robot · 2023-04-24T07:01:10Z

Validate Tests on commit ed4e9f8 finished successfully.
View logs: TXT HTML

odo-robot · 2023-04-24T07:05:03Z

OpenShift Unauthenticated Tests on commit ed4e9f8 finished successfully.
View logs: TXT HTML

odo-robot · 2023-04-24T07:05:11Z

NoCluster Tests on commit ed4e9f8 finished successfully.
View logs: TXT HTML

odo-robot · 2023-04-24T07:06:32Z

Unit Tests on commit ed4e9f8 finished successfully.
View logs: TXT HTML

odo-robot · 2023-04-24T07:47:04Z

Kubernetes Tests on commit ed4e9f8 finished with errors.
View logs: TXT HTML

odo-robot · 2023-04-24T07:51:22Z

OpenShift Tests on commit ed4e9f8 finished with errors.
View logs: TXT HTML

odo-robot · 2023-04-24T08:23:40Z

Windows Tests (OCP) on commit ed4e9f8 finished successfully.
View logs: TXT HTML

valaparthvi · 2023-04-24T15:57:50Z

  [FAILED] Timed out after 240.001s.
  Expected
      <string>: Updating Component...
      
      Error occurred on Push - watch command was unable to push component: unable to delete remote resources: unable to delete resource: ServiceBinding/my-nodejs-app-cluster-sample-k8s: timeout while waiting for "my-nodejs-app-cluster-sample-k8s" resource to be deleted
      
      Pushing files...
      
      
      File /tmp/416227824/devfile.yaml changed
       â€¢  Waiting for Kubernetes resources  ...
      Error occurred on Push - watch command was unable to push component: unable to delete remote resources: unable to delete resource: ServiceBinding/my-nodejs-app-cluster-sample-k8s: timeout while waiting for "my-nodejs-app-cluster-sample-k8s" resource to be deleted
      
       â€¢  Waiting for Kubernetes resources  ...
      Error occurred on Push - watch command was unable to push component: unable to delete remote resources: unable to delete resource: ServiceBinding/my-nodejs-app-cluster-sample-k8s: timeout while waiting for "my-nodejs-app-cluster-sample-k8s" resource to be deleted
      
       â€¢  Waiting for Kubernetes resources  ...
      
  to contain substring
      <string>: Dev mode
  In [BeforeEach] at: /go/odo_1/tests/helper/helper_run.go:54 @ 04/24/23 13:27:05.8

  [FAIL] odo remove binding command tests when the component with binding is bootstrapped (bindingName=my-nodejs-app-cluster-sample-k8s) when odo dev is running when binding is removed [BeforeEach] should have led odo dev to delete ServiceBinding from the cluster

  [odo] I0424 12:59:49.276697   20825 exec.go:49] ExecuteCommand returned an an err: error while streaming command: error sending request: Post "https://c100-e.eu-de.containers.cloud.ibm.com:31988/api/v1/namespaces/cmd-dev-test1984unx/pods/wevhqk-app-5467ccf857-2hwvc/exec?command=%2Fbin%2Fsh&command=-c&command=cat+%2Fopt%2Fodo%2F.odo_cmd_start.pid+%7C%7C+true&container=runtime&stderr=true&stdout=true": dial tcp: lookup c100-e.eu-de.containers.cloud.ibm.com: operation was canceled. for command '[/bin/sh -c cat /opt/odo/.odo_cmd_start.pid || true]'
  [odo] stdout: []
  [odo] stderr: []
  [odo] I0424 12:59:49.276755   20825 execute_run.go:36] error while running background command: unable to exec command [/bin/sh -c echo $$ > /opt/odo/.odo_cmd_start.pid && cd /projects &&  (npm start) 1>>/proc/1/fd/1 2>>/proc/1/fd/2; echo $? >> /opt/odo/.odo_cmd_start.pid]: error while streaming command: context canceled
  [odo] I0424 12:59:49.279169   20825 service.go:124] Getting instances of: servicebindings.servicebinding.io
  [odo] I0424 12:59:49.293852   20825 service.go:124] Getting instances of: servicebindings.servicebinding.io
  [odo] Cleaning resources, please wait
  [odo] I0424 12:59:49.467107   20825 all.go:46] starting to concurrently query 195 APIs
  [odo] I0424 12:59:49.475709   20825 all.go:62] fired up all goroutines to query APIs
  [odo] I0424 12:59:51.603322   20825 all.go:67] all goroutines have returned in 2.136211926s
  [odo] I0424 12:59:51.603410   20825 all.go:76] query result: objects=589
  [odo] I0424 13:00:24.308542   20825 all.go:46] starting to concurrently query 195 APIs
  [odo] I0424 13:00:24.308842   20825 all.go:62] fired up all goroutines to query APIs
  [odo] I0424 13:00:26.718846   20825 all.go:67] all goroutines have returned in 2.410359999s
  [odo] I0424 13:00:26.718914   20825 all.go:76] query result: objects=584
  [odo] I0424 13:00:29.037872   20825 all.go:46] starting to concurrently query 195 APIs
  [odo] I0424 13:00:29.041418   20825 all.go:62] fired up all goroutines to query APIs
  [odo] I0424 13:00:29.910789   20825 all.go:67] all goroutines have returned in 872.917324ms
  [odo] I0424 13:00:29.910856   20825 all.go:76] query result: objects=581
  [odo] Failed to delete the "Deployment" resource: my-k8s-component
  [odo] I0424 13:01:30.171792   20825 delete.go:94] failed to delete resource "my-k8s-component" (apps.v1.deployments): timeout while waiting for "my-k8s-component" resource to be deleted
  [odo]  âœ—  Dev mode interrupted by user
  Running oc with args [oc get deployments] and odo env: []
  [oc] NAME               READY   UP-TO-DATE   AVAILABLE   AGE
  [oc] my-k8s-component   0/1     0            0           4m28s
  [FAILED] in [It] - /go/odo_1/tests/integration/cmd_dev_test.go:2032 @ 04/24/23 13:01:30.827
  Deleting project: cmd-dev-test1984unx
  Running oc with args [oc delete project cmd-dev-test1984unx --wait=false] and odo env: []
  [oc] project.project.openshift.io "cmd-dev-test1984unx" deleted
  Setting current dir to: /go/odo_1/tests/integration
  Deleting dir: /tmp/556083651
  Deleting dir: /tmp/1211826814
  << Timeline

  [FAILED] Expected
      <string>: NAME               READY   UP-TO-DATE   AVAILABLE   AGE
      my-k8s-component   0/1     0            0           4m28s
      
  not to contain substring
      <string>: my-k8s-component
  In [It] at: /go/odo_1/tests/integrat

  [FAIL] odo dev command tests 1. devfile contains composite apply command when odo dev is running [It] should execute the composite apply commands successfully

odo-robot · 2023-04-26T14:13:57Z

Kubernetes Docs Tests on commit 191ee6f finished successfully.
View logs: TXT HTML

valaparthvi · 2023-04-27T04:40:16Z

Summarizing 2 Failures:

  [FAIL] odo delete command tests when a component is bootstrapped using a devfile.yaml with URI-referenced Kubernetes components when the component is running in both DEV and DEPLOY mode and dev mode is killed when the component is deleted using its name and namespace from another directory [It] should delete the appropriate resources
  C:/Users/Administrator.ANSIBLE-TEST-VS/3817/tests/helper/helper_oc.go:34
  Running oc.exe with args [oc get deployment -n cmd-delete-test670wxb] and odo env: []
  [oc] NAME           READY   UP-TO-DATE   AVAILABLE   AGE
  [oc] my-component   0/1     1            0           21s
  STEP: not deleting Deploy resources @ 04/26/23 10:08:53.757
  Running oc.exe with args [oc get deployment -n cmd-delete-test670wxb] and odo env: []
  [oc] Unable to connect to the server: dial tcp 161.156.12.82:31700: connectex: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.
  [FAILED] in [It] - C:/Users/Administrator.ANSIBLE-TEST-VS/3817/tests/helper/helper_oc.go:34 @ 04/26/23 10:09:14.936
  Deleting project: cmd-delete-test670wxb
  Running oc.exe with args [oc delete project cmd-delete-test670wxb --wait=false] and odo env: []
  [oc] project.project.openshift.io "cmd-delete-test670wxb" deleted
  Setting current dir to: C:\Users\Administrator.ANSIBLE-TEST-VS\3817\tests\integration
  Deleting dir: C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\4181276825
  Deleting dir: C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\3889731846
  << Timeline

  [FAILED] No future change is possible.  Bailing out early after 21.172s.
  Expected
      <int>: 1
  to match exit code:
      <int>: 0

  [FAIL] odo describe/list binding command tests [BeforeEach] when creating a component with a binding as files (service in namespace "binding-elm") when Starting a Pg service when running dev session when changing the current namespace should list the binding with --namespace flag
  C:/Users/Administrator.ANSIBLE-TEST-VS/3817/tests/helper/helper_cmd_wrapper.go:101

  Running oc.exe with args [oc create configmap config-map-for-cleanup --from-literal type=testing --from-literal team=odo -n cmd-describe-list-binding-test787rhg] and odo env: []
  [oc] error: failed to create configmap: Post "https://c115-e.eu-de.containers.cloud.ibm.com:31700/api/v1/namespaces/cmd-describe-list-binding-test787rhg/configmaps?fieldManager=kubectl-create": dial tcp 161.156.12.82:31700: connectex: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.
  [FAILED] in [BeforeEach] - C:/Users/Administrator.ANSIBLE-TEST-VS/3817/tests/helper/helper_cmd_wrapper.go:101 @ 04/26/23 10:32:00.503
  Deleting project: cmd-describe-list-binding-test787ail
  Running oc.exe with args [oc delete project cmd-describe-list-binding-test787ail --wait=false] and odo env: []
  [oc] Error from server (NotFound): namespaces "cmd-describe-list-binding-test787ail" not found
  [FAILED] in [AfterEach] - C:/Users/Administrator.ANSIBLE-TEST-VS/3817/tests/helper/helper_cmd_wrapper.go:101 @ 04/26/23 10:32:00.756
  << Timeline

  [FAILED] No future change is possible.  Bailing out early after 21.159s.
  Running oc.exe with args [oc create configmap config-map-for-cleanup --from-literal type=testing --from-literal team=odo -n cmd-describe-list-binding-test787rhg] and odo env: []
  Expected
      <int>: 1
  to match exit code:
      <int>: 0
  In [BeforeEach] at: C:/Users/Administrator.ANSIBLE-TEST-VS/3817/tests/helper/helper_cmd_wrapper.go:101 @ 04/26/23 10:32:00.503

/override windows-integration-test/Windows-test

openshift-ci · 2023-04-27T04:40:20Z

@valaparthvi: Overrode contexts on behalf of valaparthvi: windows-integration-test/Windows-test

In response to this:

Summarizing 2 Failures:

 [FAIL] odo delete command tests when a component is bootstrapped using a devfile.yaml with URI-referenced Kubernetes components when the component is running in both DEV and DEPLOY mode and dev mode is killed when the component is deleted using its name and namespace from another directory [It] should delete the appropriate resources
 C:/Users/Administrator.ANSIBLE-TEST-VS/3817/tests/helper/helper_oc.go:34
 Running oc.exe with args [oc get deployment -n cmd-delete-test670wxb] and odo env: []
 [oc] NAME           READY   UP-TO-DATE   AVAILABLE   AGE
 [oc] my-component   0/1     1            0           21s
 STEP: not deleting Deploy resources @ 04/26/23 10:08:53.757
 Running oc.exe with args [oc get deployment -n cmd-delete-test670wxb] and odo env: []
 [oc] Unable to connect to the server: dial tcp 161.156.12.82:31700: connectex: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.
 [FAILED] in [It] - C:/Users/Administrator.ANSIBLE-TEST-VS/3817/tests/helper/helper_oc.go:34 @ 04/26/23 10:09:14.936
 Deleting project: cmd-delete-test670wxb
 Running oc.exe with args [oc delete project cmd-delete-test670wxb --wait=false] and odo env: []
 [oc] project.project.openshift.io "cmd-delete-test670wxb" deleted
 Setting current dir to: C:\Users\Administrator.ANSIBLE-TEST-VS\3817\tests\integration
 Deleting dir: C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\4181276825
 Deleting dir: C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\3889731846
 << Timeline

 [FAILED] No future change is possible.  Bailing out early after 21.172s.
 Expected
     <int>: 1
 to match exit code:
     <int>: 0

 [FAIL] odo describe/list binding command tests [BeforeEach] when creating a component with a binding as files (service in namespace "binding-elm") when Starting a Pg service when running dev session when changing the current namespace should list the binding with --namespace flag
 C:/Users/Administrator.ANSIBLE-TEST-VS/3817/tests/helper/helper_cmd_wrapper.go:101

 Running oc.exe with args [oc create configmap config-map-for-cleanup --from-literal type=testing --from-literal team=odo -n cmd-describe-list-binding-test787rhg] and odo env: []
 [oc] error: failed to create configmap: Post "https://c115-e.eu-de.containers.cloud.ibm.com:31700/api/v1/namespaces/cmd-describe-list-binding-test787rhg/configmaps?fieldManager=kubectl-create": dial tcp 161.156.12.82:31700: connectex: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.
 [FAILED] in [BeforeEach] - C:/Users/Administrator.ANSIBLE-TEST-VS/3817/tests/helper/helper_cmd_wrapper.go:101 @ 04/26/23 10:32:00.503
 Deleting project: cmd-describe-list-binding-test787ail
 Running oc.exe with args [oc delete project cmd-describe-list-binding-test787ail --wait=false] and odo env: []
 [oc] Error from server (NotFound): namespaces "cmd-describe-list-binding-test787ail" not found
 [FAILED] in [AfterEach] - C:/Users/Administrator.ANSIBLE-TEST-VS/3817/tests/helper/helper_cmd_wrapper.go:101 @ 04/26/23 10:32:00.756
 << Timeline

 [FAILED] No future change is possible.  Bailing out early after 21.159s.
 Running oc.exe with args [oc create configmap config-map-for-cleanup --from-literal type=testing --from-literal team=odo -n cmd-describe-list-binding-test787rhg] and odo env: []
 Expected
     <int>: 1
 to match exit code:
     <int>: 0
 In [BeforeEach] at: C:/Users/Administrator.ANSIBLE-TEST-VS/3817/tests/helper/helper_cmd_wrapper.go:101 @ 04/26/23 10:32:00.503

/override windows-integration-test/Windows-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

feloy

Works great for me

Just a little typo

tests/integration/cmd_dev_test.go

pkg/kclient/port_forwarding.go

pkg/util/util.go

rm3l

One more thing I just noticed: I think the HostIp field for the Pod Spec on Podman should also be set to the custom address. Otherwise, Podman will try to listen on all interfaces by default:

$ nc -v -l 127.0.0.1 20001

# This should work, but fails with:
#  listen tcp 0.0.0.0:20001: bind: address already in use
$ odo dev --address=127.0.0.2 --port-forward 20001:8080 --platform podman

docs/website/docs/command-reference/dev.md

rm3l · 2023-05-02T07:52:15Z

docs/website/docs/command-reference/dev.md

+
+:::note
+If you are on macOS, you may not be able to run 2 podman sessions in parallel without defining a custom port mapping or custom address.
+By default, we use 127.0.0.1 address, so if 1 session is already using port 20001, the second session might also end up with port 20001 because macOS seems to think of it as a free port.


As discussed the other day, I think now that we are using 127.0.0.1 as the default address (even on Podman), and checking if the port is free using the same address we listen on, maybe this should work on MacOS now..
At least, that was the regression observed on the Linux kernel, but not sure on MacOS: the Linux kernel thought that 0.0.0.0:$port was free even if 127.0.0.1:$port was not, but it worked correctly if we were using the exact same address and port combination.
Can you confirm this on MacOS?

Oh you're right. It's works well in parallel for both podman and cluster on 127.0.0.1(default), but fails for cluster on 0.0.0.0.

tests/integration/cmd_dev_test.go

Signed-off-by: Parthvi Vala <pvala@redhat.com>

Co-authored-by: Armel Soro <armel@rm3l.org>

Signed-off-by: Parthvi Vala <pvala@redhat.com>

…alidate() method, add integration test for running parallel dev sessions on same platform, same port and different addresses Signed-off-by: Parthvi Vala <pvala@redhat.com>

Signed-off-by: Parthvi Vala <pvala@redhat.com>

rm3l

Thanks, Parthvi for your work on this!

rm3l · 2023-05-02T10:15:04Z

tests/integration/cmd_dev_test.go

+		podman := podman
+		Context(fmt.Sprintf("multiple dev sessions with different project are running on same platform (podman=%v), same port", podman), helper.LabelPodmanIf(podman, func() {
+			if runtime.GOOS == "darwin" {
+				Skip("cannot run this test out of the box on macOS because the test uses a custom address in the range 127.0.0/8 and for macOS we need to ensure the addresses are open for request before using them; Ref: https://superuser.com/questions/458875/how-do-you-get-loopback-addresses-other-than-127-0-0-1-to-work-on-os-x#458877")


I think Skip needs to be used on Ginkgo subject/setup nodes (BeforeEach for example). I guess it cannot be used on Context: https://onsi.github.io/ginkgo/#skipping-specs

Co-authored-by: Armel Soro <asoro@redhat.com> Signed-off-by: Parthvi Vala <pvala@redhat.com>

sonarcloud · 2023-05-02T10:25:54Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
4 Code Smells

No Coverage information
0.2% Duplication

valaparthvi · 2023-05-02T10:26:41Z

Windows failure:

 [FAILED] in [It] - C:/Users/Administrator.ANSIBLE-TEST-VS/3862/tests/e2escenarios/e2e_test.go:431 @ 05/02/23 04:56:24.933
  Deleting project: e2e-test462ijb
  Running oc.exe with args [oc delete project e2e-test462ijb --wait=false] and odo env: []
  [oc] project.project.openshift.io "e2e-test462ijb" deleted
  Setting current dir to: C:\Users\Administrator.ANSIBLE-TEST-VS\3862\tests\e2escenarios
  Deleting dir: C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\738157006
  Unable to delete C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\738157006 on attempt #1, trying again...
  [odo] I0502 04:56:25.323474   10608 watch.go:339] filesystem watch event: REMOVE        "C:\\Users\\Administrator.ANSIBLE-TEST-VS\\AppData\\Local\\Temp\\738157006\\.gitignore"
  [odo] I0502 04:56:25.323774   10608 watch.go:374] error removing watch for C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\738157006\.gitignore: GetFileAttributes: The system cannot find the file specified.
  [odo] I0502 04:56:25.324182   10608 watch.go:339] filesystem watch event: REMOVE        "C:\\Users\\Administrator.ANSIBLE-TEST-VS\\AppData\\Local\\Temp\\738157006\\.odo\\devstate.10608.json"
  [odo] I0502 04:56:25.324326   10608 watch.go:374] error removing watch for C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\738157006\.odo\devstate.10608.json: GetFileAttributes: The system cannot find the path specified.
  Unable to delete C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\738157006 on attempt #11, trying again...
  [FAILED] in [AfterEach] - C:/Users/Administrator.ANSIBLE-TEST-VS/3862/tests/helper/helper_filesystem.go:45 @ 05/02/23 04:58:31.285
  << Timeline

  [FAILED] Expected
      <*url.Error | 0xc000790e40>: {
          Op: "Post",
          URL: "http://127.0.0.1:60860/api/newuser",
          Err: <*errors.errorString | 0xc000184100>{s: "EOF"},
      }
  to be nil
  In [It] at: C:/Users/Administrator.ANSIBLE-TEST-VS/3862/tests/e2escenarios/e2e_test.go:431 @ 05/02/23 04:56:24.933

  There were additional failures detected.  To view them in detail run ginkgo -vv
------------------------------
+ [258.337 seconds]
E2E Test starting with non-empty Directory should verify developer workflow from non-empty Directory
C:/Users/Administrator.ANSIBLE-TEST-VS/3862/tests/e2escenarios/e2e_test.go:197

  Captured StdOut/StdErr Output >>
  Spawning 'C:\Users\Administrator.ANSIBLE-TEST-VS\3862\bin\odo.exe init' from C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\3054344395
  Spawning 'C:\Users\Administrator.ANSIBLE-TEST-VS\3862\bin\odo.exe delete component' from C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\3054344395
  << Captured StdOut/StdErr Output
------------------------------

Summarizing 1 Failure:
  [FAIL] E2E Test starting with non-empty Directory add Binding [It] should verify developer workflow of using binding as env in innerloop
  C:/Users/Administrator.ANSIBLE-TEST-VS/3862/tests/e2escenarios/e2e_test.go:431

rm3l · 2023-05-02T11:25:38Z

 [FAILED] in [It] - /go/odo_1/tests/e2escenarios/e2e_test.go:431 @ 05/02/23 10:59:13.238
  Deleting project: e2e-test462dcn
  Running oc with args [oc delete project e2e-test462dcn --wait=false] and odo env: []
  [oc] project.project.openshift.io "e2e-test462dcn" deleted
  Setting current dir to: /go/odo_1/tests/e2escenarios
  Deleting dir: /tmp/473881285
  Deleting dir: /tmp/75135834
  << Timeline

  [FAILED] Expected
      <*url.Error | 0xc0006b1080>: {
          Op: "Post",
          URL: "http://127.0.0.1:42263/api/newuser",
          Err: <*errors.errorString | 0xc0001100f0>{s: "EOF"},
      }
  to be nil
  In [It] at: /go/odo_1/tests/e2escenarios/e2e_test.go:431 @ 05/02/23 10:59:13.238
...
Summarizing 1 Failure:
  [FAIL] E2E Test starting with non-empty Directory add Binding [It] should verify developer workflow of using binding as env in innerloop
  /go/odo_1/tests/e2escenarios/e2e_test.go:431

Ran 4 of 4 Specs in 247.598 seconds
FAIL! -- 3 Passed | 1 Failed | 0 Pending | 0 Skipped

Flaky E2E test (#6582)

/override OpenShift-Integration-tests/OpenShift-Integration-tests

openshift-ci · 2023-05-02T11:25:42Z

@rm3l: Overrode contexts on behalf of rm3l: OpenShift-Integration-tests/OpenShift-Integration-tests

In response to this:

[FAILED] in [It] - /go/odo_1/tests/e2escenarios/e2e_test.go:431 @ 05/02/23 10:59:13.238
 Deleting project: e2e-test462dcn
 Running oc with args [oc delete project e2e-test462dcn --wait=false] and odo env: []
 [oc] project.project.openshift.io "e2e-test462dcn" deleted
 Setting current dir to: /go/odo_1/tests/e2escenarios
 Deleting dir: /tmp/473881285
 Deleting dir: /tmp/75135834
 << Timeline

 [FAILED] Expected
     <*url.Error | 0xc0006b1080>: {
         Op: "Post",
         URL: "http://127.0.0.1:42263/api/newuser",
         Err: <*errors.errorString | 0xc0001100f0>{s: "EOF"},
     }
 to be nil
 In [It] at: /go/odo_1/tests/e2escenarios/e2e_test.go:431 @ 05/02/23 10:59:13.238
...
Summarizing 1 Failure:
 [FAIL] E2E Test starting with non-empty Directory add Binding [It] should verify developer workflow of using binding as env in innerloop
 /go/odo_1/tests/e2escenarios/e2e_test.go:431

Ran 4 of 4 Specs in 247.598 seconds
FAIL! -- 3 Passed | 1 Failed | 0 Pending | 0 Skipped

Flaky E2E test (#6582)

/override OpenShift-Integration-tests/OpenShift-Integration-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rm3l · 2023-05-02T11:29:27Z

[odo]  ✗  failed to execute (command: deploy-exec)
  [FAILED] in [It] - /go/odo_1/tests/integration/cmd_devfile_deploy_test.go:620 @ 05/02/23 10:31:02.257
  Deleting project: cmd-devfile-deploy-test616vzz
  Running kubectl with args [kubectl delete namespaces cmd-devfile-deploy-test616vzz --wait=false] and odo env: []
  [kubectl] namespace "cmd-devfile-deploy-test616vzz" deleted
  Setting current dir to: /go/odo_1/tests/integration
  Deleting dir: /tmp/2798433139
  Deleting dir: /tmp/3293352902
  << Timeline

  [FAILED] Expected
      <string>: I0502 10:30:46.251561   13421 version.go:28] executing [podman version --format json]
      I0502 10:30:46.251967   13421 implem.go:110] The path for preference file is /tmp/3293352902/preference.yaml
      I0502 10:30:46.258937   13421 context.go:159] absolute devfile path: '/tmp/2798433139/devfile.yaml'
      I0502 10:30:46.258956   13421 context.go:110] absolute devfile path: '/tmp/2798433139/devfile.yaml'
      I0502 10:30:46.259731   13421 content.go:48] converted devfile YAML to JSON
      I0502 10:30:46.259833   13421 apiVersion.go:60] devfile schemaVersion: '2.2.0'
      I0502 10:30:46.259858   13421 helper.go:56] devfile apiVersion '2.2.0' is supported
      I0502 10:30:46.263101   13421 schema.go:61] validated devfile schema
      I0502 10:30:46.264993   13421 validate.go:45] Successfully validated devfile sections
      I0502 10:30:46.265008   13421 validate.go:45] Successfully validated devfile sections
      I0502 10:30:46.265055   13421 component.go:87] name of component is "sggkea", and sanitized name is "sggkea"
      I0502 10:30:46.265076   13421 kclient.go:224] Checking if "projects" resource is supported
      I0502 10:30:46.289163   13421 oc_server.go:26] Trying to connect to server c110.eu-de.containers.cloud.ibm.com:31454
      I0502 10:30:46.292930   13421 oc_server.go:33] Server https://c110.eu-de.containers.cloud.ibm.com:31454/ is up
      I0502 10:30:46.300837   13421 oc_server.go:66] Unable to get OpenShift Version: the server could not find the requested resource
      I0502 10:30:46.426244   13421 jobs.go:44] Waiting for Job sggkea-app-deploy-exec to complete successfully
      I0502 10:31:02.101896   13421 jobs.go:67] Failed to execute the job, reason: &JobCondition{Type:Failed,Status:True,LastProbeTime:2023-05-02 10:31:02 +0000 UTC,LastTransitionTime:2023-05-02 10:31:02 +0000 UTC,Reason:BackoffLimitExceeded,Message:Job has reached the specified backoff limit,}
...
  not to contain substring
      <string>: counter 1 counter
  In [It] at: /go/odo_1/tests/integration/cmd_devfile_deploy_test.go:620 @ 05/02/23 10:31:02.257
...

Summarizing 1 Failure:
  [FAIL] odo devfile deploy command tests deploying devfile with exec when using devfile where the exec command is bound to fail [It] should print the last 100 lines of the log to the output
  /go/odo_1/tests/integration/cmd_devfile_deploy_test.go:620

Ran 478 of 860 Specs in 1520.872 seconds
FAIL! -- 477 Passed | 1 Failed | 0 Pending | 382 Skipped

Previous run of this test passed.

/override Kubernetes-Integration-Tests/Kubernetes-Integration-Tests

openshift-ci · 2023-05-02T11:29:31Z

@rm3l: Overrode contexts on behalf of rm3l: Kubernetes-Integration-Tests/Kubernetes-Integration-Tests

In response to this:

[odo]  ✗  failed to execute (command: deploy-exec)
 [FAILED] in [It] - /go/odo_1/tests/integration/cmd_devfile_deploy_test.go:620 @ 05/02/23 10:31:02.257
 Deleting project: cmd-devfile-deploy-test616vzz
 Running kubectl with args [kubectl delete namespaces cmd-devfile-deploy-test616vzz --wait=false] and odo env: []
 [kubectl] namespace "cmd-devfile-deploy-test616vzz" deleted
 Setting current dir to: /go/odo_1/tests/integration
 Deleting dir: /tmp/2798433139
 Deleting dir: /tmp/3293352902
 << Timeline

 [FAILED] Expected
     <string>: I0502 10:30:46.251561   13421 version.go:28] executing [podman version --format json]
     I0502 10:30:46.251967   13421 implem.go:110] The path for preference file is /tmp/3293352902/preference.yaml
     I0502 10:30:46.258937   13421 context.go:159] absolute devfile path: '/tmp/2798433139/devfile.yaml'
     I0502 10:30:46.258956   13421 context.go:110] absolute devfile path: '/tmp/2798433139/devfile.yaml'
     I0502 10:30:46.259731   13421 content.go:48] converted devfile YAML to JSON
     I0502 10:30:46.259833   13421 apiVersion.go:60] devfile schemaVersion: '2.2.0'
     I0502 10:30:46.259858   13421 helper.go:56] devfile apiVersion '2.2.0' is supported
     I0502 10:30:46.263101   13421 schema.go:61] validated devfile schema
     I0502 10:30:46.264993   13421 validate.go:45] Successfully validated devfile sections
     I0502 10:30:46.265008   13421 validate.go:45] Successfully validated devfile sections
     I0502 10:30:46.265055   13421 component.go:87] name of component is "sggkea", and sanitized name is "sggkea"
     I0502 10:30:46.265076   13421 kclient.go:224] Checking if "projects" resource is supported
     I0502 10:30:46.289163   13421 oc_server.go:26] Trying to connect to server c110.eu-de.containers.cloud.ibm.com:31454
     I0502 10:30:46.292930   13421 oc_server.go:33] Server https://c110.eu-de.containers.cloud.ibm.com:31454/ is up
     I0502 10:30:46.300837   13421 oc_server.go:66] Unable to get OpenShift Version: the server could not find the requested resource
     I0502 10:30:46.426244   13421 jobs.go:44] Waiting for Job sggkea-app-deploy-exec to complete successfully
     I0502 10:31:02.101896   13421 jobs.go:67] Failed to execute the job, reason: &JobCondition{Type:Failed,Status:True,LastProbeTime:2023-05-02 10:31:02 +0000 UTC,LastTransitionTime:2023-05-02 10:31:02 +0000 UTC,Reason:BackoffLimitExceeded,Message:Job has reached the specified backoff limit,}
...
 not to contain substring
     <string>: counter 1 counter
 In [It] at: /go/odo_1/tests/integration/cmd_devfile_deploy_test.go:620 @ 05/02/23 10:31:02.257
...

Summarizing 1 Failure:
 [FAIL] odo devfile deploy command tests deploying devfile with exec when using devfile where the exec command is bound to fail [It] should print the last 100 lines of the log to the output
 /go/odo_1/tests/integration/cmd_devfile_deploy_test.go:620

Ran 478 of 860 Specs in 1520.872 seconds
FAIL! -- 477 Passed | 1 Failed | 0 Pending | 382 Skipped

Previous run of this test passed.

/override Kubernetes-Integration-Tests/Kubernetes-Integration-Tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Apr 24, 2023

openshift-ci bot added the kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation label Apr 24, 2023

openshift-ci bot requested review from feloy and kadel April 24, 2023 06:58

valaparthvi force-pushed the custom-address branch 2 times, most recently from f67d319 to b92e852 Compare April 24, 2023 10:30

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label Apr 25, 2023

valaparthvi force-pushed the custom-address branch from 5fa1b15 to 66c2455 Compare April 26, 2023 12:50

valaparthvi force-pushed the custom-address branch from 66c2455 to 9a6ce8a Compare April 26, 2023 14:16

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label Apr 26, 2023

valaparthvi force-pushed the custom-address branch from 9a6ce8a to bc587b8 Compare April 26, 2023 14:32

valaparthvi changed the title ~~WIP: Use custom address for port forwarding~~ Use custom address for port forwarding Apr 27, 2023

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Apr 27, 2023

feloy reviewed Apr 27, 2023

View reviewed changes

tests/integration/cmd_dev_test.go Outdated Show resolved Hide resolved

rm3l requested changes Apr 27, 2023

View reviewed changes

pkg/kclient/port_forwarding.go Show resolved Hide resolved

openshift-ci bot assigned rm3l Apr 27, 2023

rm3l reviewed Apr 27, 2023

View reviewed changes

pkg/util/util.go Outdated Show resolved Hide resolved

rm3l requested changes Apr 27, 2023

View reviewed changes

rm3l requested changes May 2, 2023

View reviewed changes

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label May 2, 2023

valaparthvi and others added 10 commits May 2, 2023 14:17

Custom address for port forwarding

cd0e2a2

Signed-off-by: Parthvi Vala <pvala@redhat.com>

Add integration tests

3071578

Signed-off-by: Parthvi Vala <pvala@redhat.com>

Use private variables for custom address and ports

f5a15d3

Signed-off-by: Parthvi Vala <pvala@redhat.com>

Update pkg/util/util.go

374d450

Co-authored-by: Armel Soro <armel@rm3l.org>

Assign custom address to HostIP for podman

e062933

Signed-off-by: Parthvi Vala <pvala@redhat.com>

Add validation for free port when --port-forward is provided in the V…

ca73346

…alidate() method, add integration test for running parallel dev sessions on same platform, same port and different addresses Signed-off-by: Parthvi Vala <pvala@redhat.com>

Fix unit test failure

e5807f2

Signed-off-by: Parthvi Vala <pvala@redhat.com>

Attempt at fixing windows failure

ede7e22

Signed-off-by: Parthvi Vala <pvala@redhat.com>

Add documentation

e9eb471

Signed-off-by: Parthvi Vala <pvala@redhat.com>

Use default value for --address flag

934db96

Signed-off-by: Parthvi Vala <pvala@redhat.com>

valaparthvi force-pushed the custom-address branch from 0353bb6 to cac1785 Compare May 2, 2023 08:59

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label May 2, 2023

rm3l approved these changes May 2, 2023

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label May 2, 2023

rm3l reviewed May 2, 2023

View reviewed changes

Changes from review

8c510d9

Co-authored-by: Armel Soro <asoro@redhat.com> Signed-off-by: Parthvi Vala <pvala@redhat.com>

valaparthvi force-pushed the custom-address branch from cac1785 to 8c510d9 Compare May 2, 2023 10:24

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label May 2, 2023

rm3l approved these changes May 2, 2023

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label May 2, 2023

openshift-merge-robot merged commit 010e963 into redhat-developer:main May 2, 2023

feloy mentioned this pull request May 4, 2023

[MacOS] Cannot run 2 dev sessions simultaneously on cluster #6744

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use custom address for port forwarding #6766

Use custom address for port forwarding #6766

valaparthvi commented Apr 24, 2023 •

edited

Loading

netlify bot commented Apr 24, 2023 •

edited

Loading

odo-robot bot commented Apr 24, 2023 •

edited

Loading

odo-robot bot commented Apr 24, 2023 •

edited

Loading

odo-robot bot commented Apr 24, 2023 •

edited

Loading

odo-robot bot commented Apr 24, 2023 •

edited

Loading

odo-robot bot commented Apr 24, 2023 •

edited

Loading

odo-robot bot commented Apr 24, 2023 •

edited

Loading

odo-robot bot commented Apr 24, 2023 •

edited

Loading

valaparthvi commented Apr 24, 2023

odo-robot bot commented Apr 26, 2023 •

edited

Loading

valaparthvi commented Apr 27, 2023

openshift-ci bot commented Apr 27, 2023

feloy left a comment •

edited

Loading

rm3l left a comment •

edited

Loading

rm3l May 2, 2023 •

edited

Loading

valaparthvi May 2, 2023

rm3l left a comment

rm3l May 2, 2023 •

edited

Loading

sonarcloud bot commented May 2, 2023

valaparthvi commented May 2, 2023

rm3l commented May 2, 2023

openshift-ci bot commented May 2, 2023

rm3l commented May 2, 2023

openshift-ci bot commented May 2, 2023

Use custom address for port forwarding #6766

Use custom address for port forwarding #6766

Conversation

valaparthvi commented Apr 24, 2023 • edited Loading

netlify bot commented Apr 24, 2023 • edited Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

odo-robot bot commented Apr 24, 2023 • edited Loading

odo-robot bot commented Apr 24, 2023 • edited Loading

odo-robot bot commented Apr 24, 2023 • edited Loading

odo-robot bot commented Apr 24, 2023 • edited Loading

odo-robot bot commented Apr 24, 2023 • edited Loading

odo-robot bot commented Apr 24, 2023 • edited Loading

odo-robot bot commented Apr 24, 2023 • edited Loading

valaparthvi commented Apr 24, 2023

odo-robot bot commented Apr 26, 2023 • edited Loading

valaparthvi commented Apr 27, 2023

openshift-ci bot commented Apr 27, 2023

feloy left a comment • edited Loading

Choose a reason for hiding this comment

rm3l left a comment • edited Loading

Choose a reason for hiding this comment

rm3l May 2, 2023 • edited Loading

Choose a reason for hiding this comment

valaparthvi May 2, 2023

Choose a reason for hiding this comment

rm3l left a comment

Choose a reason for hiding this comment

rm3l May 2, 2023 • edited Loading

Choose a reason for hiding this comment

sonarcloud bot commented May 2, 2023

valaparthvi commented May 2, 2023

rm3l commented May 2, 2023

openshift-ci bot commented May 2, 2023

rm3l commented May 2, 2023

openshift-ci bot commented May 2, 2023

valaparthvi commented Apr 24, 2023 •

edited

Loading

netlify bot commented Apr 24, 2023 •

edited

Loading

odo-robot bot commented Apr 24, 2023 •

edited

Loading

odo-robot bot commented Apr 24, 2023 •

edited

Loading

odo-robot bot commented Apr 24, 2023 •

edited

Loading

odo-robot bot commented Apr 24, 2023 •

edited

Loading

odo-robot bot commented Apr 24, 2023 •

edited

Loading

odo-robot bot commented Apr 24, 2023 •

edited

Loading

odo-robot bot commented Apr 24, 2023 •

edited

Loading

odo-robot bot commented Apr 26, 2023 •

edited

Loading

feloy left a comment •

edited

Loading

rm3l left a comment •

edited

Loading

rm3l May 2, 2023 •

edited

Loading

rm3l May 2, 2023 •

edited

Loading