Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use custom address for port forwarding #6766

Merged
merged 11 commits into from
May 2, 2023
Merged

Use custom address for port forwarding #6766

merged 11 commits into from
May 2, 2023

Commits on May 2, 2023

  1. Custom address for port forwarding 

    Signed-off-by: Parthvi Vala <pvala@redhat.com>
    @valaparthvi
    valaparthvi committed May 2, 2023
    Configuration menu
    Copy the full SHA
    cd0e2a2 View commit details
    Browse the repository at this point in the history

  2. Add integration tests 

    Signed-off-by: Parthvi Vala <pvala@redhat.com>
    @valaparthvi
    valaparthvi committed May 2, 2023
    Configuration menu
    Copy the full SHA
    3071578 View commit details
    Browse the repository at this point in the history

  3. Use private variables for custom address and ports 

    Signed-off-by: Parthvi Vala <pvala@redhat.com>
    @valaparthvi
    valaparthvi committed May 2, 2023
    Configuration menu
    Copy the full SHA
    f5a15d3 View commit details
    Browse the repository at this point in the history

  4. Update pkg/util/util.go 

    Co-authored-by: Armel Soro <armel@rm3l.org>
    @valaparthvi @rm3l
    valaparthvi and rm3l committed May 2, 2023
    Configuration menu
    Copy the full SHA
    374d450 View commit details
    Browse the repository at this point in the history

  5. Assign custom address to HostIP for podman 

    Signed-off-by: Parthvi Vala <pvala@redhat.com>
    @valaparthvi
    valaparthvi committed May 2, 2023
    Configuration menu
    Copy the full SHA
    e062933 View commit details
    Browse the repository at this point in the history

  6. Add validation for free port when --port-forward is provided in the V… 

    …alidate() method, add integration test for running parallel dev sessions on same platform, same port and different addresses

Signed-off-by: Parthvi Vala <pvala@redhat.com>
    @valaparthvi
    valaparthvi committed May 2, 2023
    Configuration menu
    Copy the full SHA
    ca73346 View commit details
    Browse the repository at this point in the history

  7. Fix unit test failure 

    Signed-off-by: Parthvi Vala <pvala@redhat.com>
    @valaparthvi
    valaparthvi committed May 2, 2023
    Configuration menu
    Copy the full SHA
    e5807f2 View commit details
    Browse the repository at this point in the history

  8. Attempt at fixing windows failure 

    Signed-off-by: Parthvi Vala <pvala@redhat.com>
    @valaparthvi
    valaparthvi committed May 2, 2023
    Configuration menu
    Copy the full SHA
    ede7e22 View commit details
    Browse the repository at this point in the history

  9. Add documentation 

    Signed-off-by: Parthvi Vala <pvala@redhat.com>
    @valaparthvi
    valaparthvi committed May 2, 2023
    Configuration menu
    Copy the full SHA
    e9eb471 View commit details
    Browse the repository at this point in the history

  10. Use default value for --address flag 

    Signed-off-by: Parthvi Vala <pvala@redhat.com>
    @valaparthvi
    valaparthvi committed May 2, 2023
    Configuration menu
    Copy the full SHA
    934db96 View commit details
    Browse the repository at this point in the history

  11. Changes from review 

    Co-authored-by: Armel Soro <asoro@redhat.com>
Signed-off-by: Parthvi Vala <pvala@redhat.com>
    @valaparthvi @rm3l
    valaparthvi and rm3l committed May 2, 2023
    Configuration menu
    Copy the full SHA
    8c510d9 View commit details
    Browse the repository at this point in the history