-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Alizer to fix potential panic when analyzing large projects #6926
Bump Alizer to fix potential panic when analyzing large projects #6926
Conversation
🔨 Deploy Preview deleted from internal cluster!
|
9bf274d
to
3a76856
Compare
e2d9f53
to
81ceaa3
Compare
Amongst other things, this fixes an issue when analyzing large projects, by preventing potential panics when trying to detect application ports. [1] redhat-developer/alizer@14114f0
…d 'k8s.io/*' to the previous versions we had Bumping Alizer bumped these packages to upper versions, which seems to cause build errors due to Service Binding Operator libraries not compatible with those new versions. See the error below. Since we don't want to update SBO libraries at this time (as SBO is currently in maintenance mode only), this makes sure we are using the versions it builds against. Build error for reference: ``` go install -mod=vendor -ldflags="-X github.com/redhat-developer/odo/pkg/version.GITCOMMIT=cb9c13900" ./cmd/odo/ # github.com/redhat-developer/service-binding-operator/apis/spec/v1alpha3 vendor/github.com/redhat-developer/service-binding-operator/apis/spec/v1alpha3/servicebinding_webhook.go:44:27: cannot use &ServiceBinding{} (value of type *ServiceBinding) as type admission.Validator in variable declaration: *ServiceBinding does not implement admission.Validator (wrong type for ValidateCreate method) have ValidateCreate() error want ValidateCreate() (warnings admission.Warnings, err error) # github.com/redhat-developer/service-binding-operator/apis/binding/v1alpha1 vendor/github.com/redhat-developer/service-binding-operator/apis/binding/v1alpha1/servicebinding_webhook.go:37:27: cannot use &ServiceBinding{} (value of type *ServiceBinding) as type admission.Validator in variable declaration: *ServiceBinding does not implement admission.Validator (wrong type for ValidateCreate method) have ValidateCreate() error want ValidateCreate() (warnings admission.Warnings, err error) make: *** [Makefile:90: install] Error 2 ```
81ceaa3
to
bf436eb
Compare
bf436eb
to
8ac52eb
Compare
Kudos, SonarCloud Quality Gate passed! |
Issue with interactive tests - addressed in #6830 /override OpenShift-Integration-tests/OpenShift-Unauth-Integration-tests |
@rm3l: Overrode contexts on behalf of rm3l: OpenShift-Integration-tests/OpenShift-Unauth-Integration-tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this:
/kind task
/area dependency
/area init
What does this PR do / why we need it:
This bumps Alizer to the latest commit at this time, which fixes an issue when analyzing large projects,
by preventing potential panics when trying to detect application ports (see redhat-developer/alizer#220).
Note:
As explained in the second commit, I had to downgrade and pin the versions of
sigs.k8s.io/controller-runtime
andk8s.io/*
to the previous versions we had, because of build errors with Service Binding Operator libraries (which I did not want to upgrade).Build error for reference
Which issue(s) this PR fixes:
Fixes #6921
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer:
Try to run
odo analyze -o json
against Backstage. It would panic before the changes here, but now it should return properly: