Skip to content
This repository has been archived by the owner on May 11, 2022. It is now read-only.

Issue144 adding startup setting #153

Merged
merged 7 commits into from
Aug 19, 2020
Merged

Issue144 adding startup setting #153

merged 7 commits into from
Aug 19, 2020

Conversation

bfitzpat
Copy link
Collaborator

No description provided.

@bfitzpat bfitzpat requested review from apupier and lhein August 13, 2020 18:31
@bfitzpat bfitzpat self-assigned this Aug 13, 2020
@bfitzpat bfitzpat mentioned this pull request Aug 13, 2020
Closed
lhein
lhein reviewed Aug 17, 2020
View reviewed changes
src/extension.ts Outdated Show resolved Hide resolved
@lhein lhein added the BASED ON OTHER PR This PR is based on another open PR. Please review after the other PR has been merged. label Aug 17, 2020
@lhein
Copy link
Collaborator

lhein commented Aug 17, 2020

based on #152

sunix
sunix reviewed Aug 17, 2020
View reviewed changes
src/utils.ts Outdated Show resolved Hide resolved
@bfitzpat bfitzpat force-pushed the issue144-adding-startup-setting branch from eeb1bc9 to 86e1d27 Compare August 17, 2020 18:21
@bfitzpat bfitzpat requested review from lhein and sunix August 17, 2020 18:23
sunix
sunix approved these changes Aug 18, 2020
View reviewed changes
Copy link
Contributor

@sunix sunix left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works great. The only problem is when you refresh the workspace, it reopens the didact tutorial a second time ... but this is very minor. Thanks a lot. #chejoy tweet on the way 😂

lhein
lhein reviewed Aug 18, 2020
View reviewed changes
src/utils.ts Outdated Show resolved Hide resolved
@bfitzpat
Copy link
Collaborator Author

It works great. The only problem is when you refresh the workspace, it reopens the didact tutorial a second time ... but this is very minor. Thanks a lot. #chejoy tweet on the way joy

When you "refresh" the workspace? Is there a way to catch that particular case @sunix ?

@bfitzpat bfitzpat requested a review from lhein August 18, 2020 12:33
@bfitzpat
adding open default tutorial at startup setting
c92d92c 
Signed-off-by: bfitzpat@redhat.com <bfitzpat@redhat.com>
@bfitzpat
changes based on PR review suggestions
4c1dcbb 
Signed-off-by: bfitzpat@redhat.com <bfitzpat@redhat.com>
@bfitzpat
addressing last round of PR comments
cdf3b97 
Signed-off-by: bfitzpat@redhat.com <bfitzpat@redhat.com>
@bfitzpat
fixing broken test
342ce26 
Signed-off-by: bfitzpat@redhat.com <bfitzpat@redhat.com>
@bfitzpat
one more try to fix broken test
a7f0fda 
Signed-off-by: bfitzpat@redhat.com <bfitzpat@redhat.com>
@bfitzpat
test cleanup
eca40c1 
Signed-off-by: bfitzpat@redhat.com <bfitzpat@redhat.com>
@bfitzpat bfitzpat force-pushed the issue144-adding-startup-setting branch from 64408b6 to eca40c1 Compare August 18, 2020 14:00
@bfitzpat bfitzpat force-pushed the issue144-adding-startup-setting branch from 3767a64 to b2068e1 Compare August 18, 2020 14:07
@bfitzpat
Copy link
Collaborator Author

@sunix I'd like to look into the refresh issue: "The only problem is when you refresh the workspace, it reopens the didact tutorial a second time ... but this is very minor. " Can you spin off a new issue for that and provide any details? Is it possible to detect a refresh vs. starting up the first time on che?

@bfitzpat bfitzpat merged commit 0ef293a into redhat-developer:master Aug 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sunix sunix sunix approved these changes

@lhein lhein lhein approved these changes

@apupier apupier Awaiting requested review from apupier

Assignees

@bfitzpat bfitzpat

Labels
BASED ON OTHER PR This PR is based on another open PR. Please review after the other PR has been merged. READY FOR REVIEW
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bfitzpat @lhein @sunix