Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide HTML support for Qute HTML templates #483

Closed
fbricon opened this issue Mar 25, 2022 · 3 comments · Fixed by #527
Closed

Provide HTML support for Qute HTML templates #483

fbricon opened this issue Mar 25, 2022 · 3 comments · Fixed by #527
Labels
enhancement New feature or request qute
Milestone

Comments

@fbricon
Copy link
Collaborator

fbricon commented Mar 25, 2022

Currently, Qute html templates only get Qute support. HTML validation and completion are missing. Would be nice if we could hook up the HTML LS to qute-html templates.

@fbricon fbricon added enhancement New feature or request qute labels Mar 25, 2022
@angelozerr
Copy link
Contributor

I have created the issue microsoft/vscode#131531

But it will be not perfect because we will have html completion in qute expression.

Is it really annoying?

An another solution is to create a custom langage server which managés html by using vscode html kanguage service. I fera that it us à big work.

If the first solution can be acceptable I will try to create a pr in vscode

@angelozerr
Copy link
Contributor

I created a PR in vscode microsoft/vscode#146731

Let's wait feedback.

angelozerr added a commit to angelozerr/vscode-quarkus that referenced this issue Jul 22, 2022
Fixes redhat-developer#483

Signed-off-by: azerr <azerr@redhat.com>
@angelozerr
Copy link
Contributor

My PR from vscode microsoft/vscode#146731 has been merged!

For the moment VSCode Insiders doesn't contains this feature. I'm wiating for that to test my draft PR #527

angelozerr added a commit to angelozerr/vscode-quarkus that referenced this issue Jul 25, 2022
Fixes redhat-developer#483

Signed-off-by: azerr <azerr@redhat.com>
@rgrunber rgrunber added this to the 1.12.0 milestone Jul 27, 2022
rgrunber pushed a commit that referenced this issue Jul 28, 2022
Fixes #483

Signed-off-by: azerr <azerr@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request qute
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants