Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace vscode dependency with @types/vscode #99

Merged
merged 1 commit into from
Oct 7, 2019
Merged

Replace vscode dependency with @types/vscode #99

merged 1 commit into from
Oct 7, 2019

Conversation

xorye
Copy link
Contributor

@xorye xorye commented Sep 30, 2019

@types/vscode provides a more up-to-date VS Code API that is needed for #53

The postinstall script was removed from package.json, because it is unecessary for @types/vscode. Source: microsoft/vscode#70175, microsoft/vscode-iot-workbench#596

Signed-off-by: David Kwon dakwon@redhat.com

@xorye
Copy link
Contributor Author

xorye commented Sep 30, 2019

Fixing the cause for failed travis test now

@xorye
Copy link
Contributor Author

xorye commented Sep 30, 2019

Fixed

@xorye xorye mentioned this pull request Sep 30, 2019
Signed-off-by: David Kwon <dakwon@redhat.com>
@xorye xorye merged commit cd3839d into redhat-developer:master Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants