Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Basic & Advanced Examples (Json/Search) #112

Merged
merged 13 commits into from
Apr 23, 2023

Conversation

shacharPash
Copy link
Contributor

@shacharPash shacharPash commented Apr 17, 2023

Closes #108
Closes #109
Closes #110
Closes #111

@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (f3595b9) 93.27% compared to head (ed3464d) 93.27%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #112   +/-   ##
=======================================
  Coverage   93.27%   93.27%           
=======================================
  Files          77       77           
  Lines        4582     4582           
  Branches      424      424           
=======================================
  Hits         4274     4274           
  Misses        186      186           
  Partials      122      122           
Impacted Files Coverage Δ
src/NRedisStack/Search/SearchResult.cs 92.15% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@shacharPash shacharPash added the documentation Improvements or additions to documentation label Apr 17, 2023
@shacharPash shacharPash requested review from uglide and a team April 17, 2023 10:38
@shacharPash shacharPash marked this pull request as ready for review April 20, 2023 09:04
shacharPash and others added 3 commits April 23, 2023 13:17
* add Basic Query Operations Exampele

* fix error

* fix order error

* remove unused usings

* add sleep

* Query and Search Advanced Examples (#115)

* start working

* using StringBuilder

* Change to List<string>

* finish test

* using HashSet

* add sleep to failed search test

* comment problematic assert

* change to Assert.Equal

* Assert.Equal(expectedResSet, resSet);

* change vec 4 to 5 inorder to make result deterministic
@shacharPash shacharPash merged commit ccae59f into master Apr 23, 2023
@shacharPash shacharPash deleted the Issue108/AdvancedJsonExamples branch April 23, 2023 10:47
@shacharPash shacharPash changed the title Advanced Json Examples Add Basic & Advanced Examples (Json/Search) Apr 23, 2023
@chayim chayim added maintenance and removed documentation Improvements or additions to documentation labels May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aggregation Query and Search advanced Query and Search basic Documents (JSON) advanced examples
4 participants