Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query and Search Advanced Examples #115

Merged

Conversation

shacharPash
Copy link
Contributor

@shacharPash shacharPash commented Apr 20, 2023

Closes #110
Closes #111

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (26036f2) 93.27% compared to head (04329de) 93.27%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #115   +/-   ##
=======================================
  Coverage   93.27%   93.27%           
=======================================
  Files          77       77           
  Lines        4582     4582           
  Branches      424      424           
=======================================
  Hits         4274     4274           
  Misses        186      186           
  Partials      122      122           
Impacted Files Coverage Δ
src/NRedisStack/Search/SearchResult.cs 92.15% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@shacharPash shacharPash requested review from chayim, uglide and a team April 20, 2023 14:46
@shacharPash shacharPash marked this pull request as ready for review April 20, 2023 15:07
@shacharPash shacharPash changed the base branch from master to Issue109/QueryAndSearchBasic April 23, 2023 10:14
@shacharPash shacharPash merged commit c81acd1 into Issue109/QueryAndSearchBasic Apr 23, 2023
@shacharPash shacharPash deleted the Issue110/QueryAndSearchAdvanced branch April 23, 2023 10:15
shacharPash added a commit that referenced this pull request Apr 23, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* add Basic Query Operations Exampele

* fix error

* fix order error

* remove unused usings

* add sleep

* Query and Search Advanced Examples (#115)

* start working

* using StringBuilder

* Change to List<string>

* finish test

* using HashSet

* add sleep to failed search test

* comment problematic assert

* change to Assert.Equal

* Assert.Equal(expectedResSet, resSet);

* change vec 4 to 5 inorder to make result deterministic
shacharPash added a commit that referenced this pull request Apr 23, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* adding basic json example

* finish BasicJsonExamplesTest

* fix test

* Remove Unnecessary usings

* start adding AdvancedJsonExamples

* add to Newtonsoft.Json csproj

* finish test

* last fixes

* Update ExamplesTests.cs

* Delete "Lab 4 - "

* Query and Search Basic Examples (#113)

* add Basic Query Operations Exampele

* fix error

* fix order error

* remove unused usings

* add sleep

* Query and Search Advanced Examples (#115)

* start working

* using StringBuilder

* Change to List<string>

* finish test

* using HashSet

* add sleep to failed search test

* comment problematic assert

* change to Assert.Equal

* Assert.Equal(expectedResSet, resSet);

* change vec 4 to 5 inorder to make result deterministic

* last fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aggregation Query and Search advanced
3 participants