Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding JSON commands #29

Merged
merged 6 commits into from
Sep 7, 2022
Merged

adding JSON commands #29

merged 6 commits into from
Sep 7, 2022

Conversation

slorello89
Copy link
Member

No description provided.

shacharPash
shacharPash suggested changes Sep 4, 2022
View reviewed changes
Copy link
Contributor

@shacharPash shacharPash left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
couple things,

  1. Need to add Async version for the function & tests.
  2. I wrote some comments about things that I didnt understand, please have a look.

@slorello89
Copy link
Member Author

Added async commands, added multi-path get, added debug memory command, other cleanup

shacharPash
shacharPash approved these changes Sep 7, 2022
View reviewed changes
Copy link
Contributor

@shacharPash shacharPash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 👍

@shacharPash shacharPash merged commit 572c7ab into redis:master Sep 7, 2022
shacharPash added a commit that referenced this pull request Oct 2, 2022
@slorello89 @shacharPash
adding JSON commands (#29)
71f264d 
* adding JSON commands

* Change commands names

* some fixes

* adding missing commands, removing visibility modifiers in interface

* async breakout

Co-authored-by: shacharPash <s.pashchur@gmail.com>
shacharPash added a commit that referenced this pull request Oct 12, 2022
@shacharPash @chayim @slorello89
Add Redis Search Commands (#32)
62dbedd 
* Add Alias command

* Start FT.CERATE Command

* Start FTCreateParams class for FT.CERATE

* Add FT.CERATE command

* Fixing Schema and FieldName Classes

* Work on Schema class

* Add FT.SEARCH command

* Add FT.ALTER command

* Linking to the latest pre-release (#30)

* Linking to the latest pre-release

* spelling and a link

* Updading the version to v0.2.1 (#31)

* adding JSON commands (#29)

* adding JSON commands

* Change commands names

* some fixes

* adding missing commands, removing visibility modifiers in interface

* async breakout

Co-authored-by: shacharPash <s.pashchur@gmail.com>

* Implement new TDIGEST commands and TDIGEST.CREATE compression (#33)

* Update Tdigest Commands

* Fix Rank Commands Tests

* Test Commit

* Add Async Commands & tests

* Working on FT.INFO Command

* Finish FT.INFO Command

* Add AggregationRequest Class for FT.AGGREGATE Command

* Add FT.AGGREGATE Command + Tests

* Adding TODOs to commands that have not yet been implemented

* Add FT.CONFIG GET/SET Commands + Tests

* Add FT.CURSOR READ/DEL Commands

* Add FT.DICT(ADD/DEL/DUMP) Commands

* Add FT.DICT(ADD/DEL/DUMP) Async Commands + Tests

* Add FT.DROPINDEX Sync/Async Commands + Tests

* Fix Aggregate & Add more Commands

* Add FT.TAGVALS Sync/Async Command + Tests

* Add Sync/Async Tests for FT.ALIAS

* Fixing Tdigest.Add Command and Tests

Co-authored-by: Chayim <chayim@users.noreply.github.com>
Co-authored-by: Steve Lorello <42971704+slorello89@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shacharPash shacharPash shacharPash approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slorello89 @shacharPash